From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Adrian Bunk <bunk@stusta.de>
Subject: Re: [PATCH] Fix roundup_pow_of_two(1)
Date: Mon, 4 Jun 2007 14:13:11 +0200
User-Agent: KMail/1.9.7
Cc: linux-kernel@vger.kernel.org,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Andrew Morton <akpm@linux-foundation.org>, stable@kernel.org
References: <200705172356.57620.eike-kernel@sf-tec.de> <20070604114900.GS5500@stusta.de>
In-Reply-To: <20070604114900.GS5500@stusta.de>
MIME-Version: 1.0
Content-Type: multipart/signed;
  boundary="nextPart1384675.3ayNLpsYU8";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <200706041413.20477.eike-kernel@sf-tec.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1206
Lines: 40

--nextPart1384675.3ayNLpsYU8
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Adrian Bunk wrote:
> On Thu, May 17, 2007 at 11:56:56PM +0200, Rolf Eike Beer wrote:
> > Fix roundup_pow_of_two(1)
> >
> > 1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It
> > does in case the argument is a variable but in case it's a constant it
> > behaves wrong and returns 0. Probably nobody ever did it so this was
> > never noticed.
>
> I'm not getting the problem.
> 2^0 = 1

Yes. But it returned 0 (not 1 << 0).

Eike

--nextPart1384675.3ayNLpsYU8
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQBGZAHgXKSJPmm5/E4RApOLAJ9Ei4vCfN3uZ118XpaVZGlzOQfUSQCeKnTr
sbVgUeGt+BR6keT6x2lOs/M=
=wBIZ
-----END PGP SIGNATURE-----

--nextPart1384675.3ayNLpsYU8--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/