Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp660515imi; Thu, 21 Jul 2022 08:30:09 -0700 (PDT) X-Google-Smtp-Source: AGRyM1urNz8wDbm8P2ubpNlOdSw7IWHHK8WPLf0sExCIlSBAr1y5IEy0HcJp3tZX1I16a+nNrUeF X-Received: by 2002:a05:6808:198c:b0:33a:a9eb:c66b with SMTP id bj12-20020a056808198c00b0033aa9ebc66bmr2679805oib.247.1658417408374; Thu, 21 Jul 2022 08:30:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658417408; cv=none; d=google.com; s=arc-20160816; b=pZPnUDHUx6VnqjfGtr8DTDYsObU8EaMkRfHKWCxj6euAN5bq+zS2R9BhMc2ndlSqTp wWMj5PFh85BRHtYX5wEJH+LNrp17JQ+ZrK5J19ex0ZXjDqCcwhNLLMdWQnk0A6hpw5Y2 KTKlOHVfJd7NIcQ9dyG12nOuTUg0pe28cmCETyhn1bWmmZCF9LHwHf7KneDGUsglLKNt LQyYYC1+c4WH4NtOUrXqphMFIgY5ZWq7CSovTU6lZm8kB/aqkW9dyk8rheqGXUiDS1M8 CuS6eUDY9DmtYRumNXI7ATNbC6U6GIYvB0/DpRTAtmBkMwlsgRUT3Dt56kISNxiYM8/N y/oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=18IhroUGeHEx3M1LazyEz3WKWJiZ0ox5uDr8Q7r9CWs=; b=LXpvtBJJd3GZXngp/xvFAZOrJb2GF0shaRBQSZStNmps9HaN5+igOUItVdnH1/cEwy m8YZ7ufKpcSB4I6ywkr6Iw3UBM88xw2web2E2KyEvjYdeshg5e1HsOvRPJQxth9Kq/xz 29028s2CLGwCQDmBbEGO6xQGvbQoPvAxH641Sc8Ua94qmJFRtW8fMHc6j3oDl3w9EovY ca0TPErGmDOrfPRm8tUqfHv02S43c/D3T3tOGSytrd2Ct0RWwGJAWVf3uCfg2jK5XTI/ b3NANBSrtP8Vl59VZXy3CobvCsZsIRm9XN7Mt3eWEcWvRVNN7b7qckQll5e9YE+ps45v HDLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Otxg257F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v17-20020a056830091100b0061cb44a8592si2124377ott.342.2022.07.21.08.29.54; Thu, 21 Jul 2022 08:30:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Otxg257F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230428AbiGUPWm (ORCPT + 99 others); Thu, 21 Jul 2022 11:22:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229616AbiGUPWl (ORCPT ); Thu, 21 Jul 2022 11:22:41 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 635381FCE3 for ; Thu, 21 Jul 2022 08:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=18IhroUGeHEx3M1LazyEz3WKWJiZ0ox5uDr8Q7r9CWs=; b=Otxg257FRhjTZXr/F9G32USeeU YO6rDzZYNOwkDC2Hw+ye13Fq0mVPzmkLT/qDrdTJDq2S1AucVRI4b4ogvxl9bkkldRLS7+ibiK1Ec MzpY6HITq3D8C9B4gatb2M/wmT84it5/0AKN8WDHqzjlKjCBsStuRCwZXn4o8gnfojrLBDqlGZKfb 6y5SGdg6ofkOP6q0NW1J8HNlL9ERpZoyFaUpYPTYvuWrgmy96eIdcNMoELZuYCynuEBgr3ju70Aim klQFejTFVipdAwwDe2QK4y8HPPOxWjJ7c2qkJJxi44xsp15enBd081XWpyF9UAdAXv3DOz7A9Wys8 bAzYSOlg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEY0d-0090jY-1C; Thu, 21 Jul 2022 15:22:39 +0000 Date: Thu, 21 Jul 2022 08:22:39 -0700 From: Christoph Hellwig To: Ben Dooks Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] kallsyms: make arch_get_kallsym() static Message-ID: References: <20220721151040.359389-1-ben-linux@fluff.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220721151040.359389-1-ben-linux@fluff.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2022 at 04:10:40PM +0100, Ben Dooks wrote: > The arch_get_kallsym() function is not used anywhere in the kernel > now, so it should at-least be static or just be removed as there > are no users. Making it static fixes the following sparse warning: > > kernel/kallsyms.c:590:12: warning: symbol 'arch_get_kallsym' was not declared. Should it be static? It fixes the warning, but isn't exactly useful. Please just remove it, get_ksymbol_arch and iter->pos_arch_end entirely instead.