Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH net-next v3 27/47] net: fman: Inline several functions
 into initialization
To:     Camelia Alexandra Groza <camelia.groza@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc:     Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Russell King <linux@armlinux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220715215954.1449214-1-sean.anderson@seco.com>
 <20220715215954.1449214-28-sean.anderson@seco.com>
 <VI1PR04MB580732B9CE46E1099C56B2A9F2919@VI1PR04MB5807.eurprd04.prod.outlook.com>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <1f35b2b9-107b-0755-e083-d8988c9fb673@seco.com>
Date:   Thu, 21 Jul 2022 11:33:34 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <VI1PR04MB580732B9CE46E1099C56B2A9F2919@VI1PR04MB5807.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzd6a0J4Rk9CdHhuY2NwRmdFcDhUUDVNTlhyNUlqTWkzaGRqQUQvYmlKNEdY?=
 =?utf-8?B?aDFRa1kyVVdoMU5wUWMzOXpGWFNFSVZYWTRVVmJjS3RyS0REaXIzSGNPRkdm?=
 =?utf-8?B?dnlVaDlLbVRsYlNRSzRTOGJIQWlaR3pzOFZubGdyNVZSWlpnWWZJaVNTQ2to?=
 =?utf-8?B?dkNIMWc1b1RZbTZPL20xMFM3RFZBN0xhZ2w5ODBwM2NlRFphQ1Nzdyt5Z1di?=
 =?utf-8?B?eW4yNTYwYWlYV2k4RWxkaFZFbUI3MFBCcXVJS3Z2WnVNWXRpb1NoendFR3Fo?=
 =?utf-8?B?eUt4NkpMRUtONno5dENqNjZOdS8waHhyMzRvUEErb084UDJOUDBKTXh1SG5w?=
 =?utf-8?B?QkRpRCszVGVqcmFXNStjTjQ3Y25LanJGbXQzMmVDQlR1d1NjSW9lT0dIREpV?=
 =?utf-8?B?WHNic1ZEbEdKd3l4VVJOdmgyMFJwZ1JvVlFQL0U1dlNJRlVHOXYybUZjSlpr?=
 =?utf-8?B?Ylo5YTVWeHZRQjR1REk2L2pWTTFUN1FrbmhjcDR3YVExanRoL1ZnRXEzK2NO?=
 =?utf-8?B?cjd2WUFmYnd4RVU3UmFISGorWnB3L3BtaHZNbm5HaUpDMjVmUDh0YkxWMGtI?=
 =?utf-8?B?QTcwS1loblFjNEFrckpGaDVZRE9QamtscXU2R3duLzNBU01CSk1PT2xVcjFn?=
 =?utf-8?B?TDlqeUVKdUlOYkFqTzAyYWhOcVVTaXlOcm9kZmU2STUyNWpQZ3Zud2NPWUx4?=
 =?utf-8?B?MHRMMjFHTXU3Mzl6OEVSUE9iY3M1Tkx4ZG1VdkNQNS96T2ZBQjVISEhxTVZn?=
 =?utf-8?B?Q1BwKzByRkl6b3k1T2ZuK2dzREpHQnM1bGxKNWZSSGhiQVJNenRxN2ttZHA5?=
 =?utf-8?B?d0JBUk9QWXVxYnlrUHRTblpBSmVGbzM0dm5rUUFMMkZUaTllM1ozOVNzcUpN?=
 =?utf-8?B?Mm51RUZCZGhxSG5XNDZPeXF0UnFHaDZBTnRWRjN1L3owUWpPK2VYUExQbndQ?=
 =?utf-8?B?ZXZuZm1kQ3dqdFptRTlzZEZzZ1prTVZTUWhKQncxRkhiNXpNeWpySlBzdExD?=
 =?utf-8?B?eWcvNHpQS1pzamoraDg0aFFGL1orc1RzbDZGbEVCcVdYWEpyLzNIODlyejlm?=
 =?utf-8?B?Qm9MSmN6Mk5QN2JnOHZFVHNaL2FxTVh0RVFiN0JhK0pqSkEyT1VuQ3V3ZHBv?=
 =?utf-8?B?U0hnMXZtTHZlcnNLdnlScFhxTm9WaFdoOHhVZldDU1VNVEp0NVFtQXdYdFNo?=
 =?utf-8?B?V1pENU1IUURPQWZpUGlLZEthUm41QnJjTDRxcFBleFJSeWorRnVVYnp6UnpT?=
 =?utf-8?B?ekVYV1VKY2IyYkJ3cWVpTlEyR1U2OG1COXRMUWFUTUVYelBwVEFrZXJDNzFJ?=
 =?utf-8?B?MmVZTjhZN3Y2Q0Rod1cvejRyZUNRd1hSZWIrdmtCUEZMcE9veEJibVhKV1RS?=
 =?utf-8?B?S2xzcWdjaHFCYnYwZWptbS9RUUR4RnpSWjliU2lKV1E5ZTRjMDBJZnlDak9H?=
 =?utf-8?B?dEpTcUxpd3hqUHFxR004ckFrckpYeEI4MHZ3aSs1aXp0QUE5VllMMUpYbHY1?=
 =?utf-8?B?M0lBMDZhcVRwQk04U3FtYUYvZ2pGQ1M2QmZMS0hKck0rZGRKV093bWdpSUM3?=
 =?utf-8?B?WE1pcC9lNmMzdUV4QkVzc1JTOEtqOTJNUWhPQ2lqYkViSlA5akI5Wm1sZkRL?=
 =?utf-8?B?WXFXNDRVRDZxRUw3d1psZHhXdFdqanJsdk1oSnVpejhodWM4eDV1bG93bDdB?=
 =?utf-8?B?ZW9OZVQ4YTNmMDNYM0R4WTRISW9IMU1aWkFQK0VoMSthYjNNcUZaYkJ4VTJR?=
 =?utf-8?B?K0JJZXd6NEoxelplVW5TSFUyUkhJWFVZaG5oQkUwNVpnN0R5aytKWlF0VVFO?=
 =?utf-8?B?d1JaVFNuRi9hNHB3ZnRjTElxc25QZ0RSZEhMN1U2WFpaZlBZeTdmRFliQzJp?=
 =?utf-8?B?dVBUZmlPUDJ2MDNGRFF1RlZnenVpNGJUbHFNZDlWcWZtbU14OXNTaVFOZDZZ?=
 =?utf-8?B?ektNYmI1MkhZVlp5Ull5SllwRG5jWWR0dnR4amErSDdET0xTZnVlREJBUWdX?=
 =?utf-8?B?N0F2V3VVTmM2bFBtM3QyZjd2L0prWUVHQVV0OUxDTFptT0lrOWd1YnY5eTRG?=
 =?utf-8?B?QnlRbkRDRCtEK3J0a2VOaHhZbEowaWlxbjBRNmIrN1VySURocWJNZXZMYW9p?=
 =?utf-8?B?bWprM1NsRFNZdGJ4UEdhUW1ZWnFBWGdISS9EeVlBcDM1SW5TM3pVN0p4MVZO?=
 =?utf-8?B?OHc9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3aee0789-823d-4666-875f-08da6b2e61e1
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 15:33:38.2902
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zxk3J08cIt9MIluU/yJWF+2NycrKySEYRAtNxataxRiZKxiO7SQySgCL86Ggo4yW8+ACWHI9VZq1ux6Zrx9DbQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4076
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/21/22 9:01 AM, Camelia Alexandra Groza wrote:
>> -----Original Message-----
>> From: Sean Anderson <sean.anderson@seco.com>
>> Sent: Saturday, July 16, 2022 1:00
>> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
>> <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>;
>> netdev@vger.kernel.org
>> Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
>> <edumazet@google.com>; linux-arm-kernel@lists.infradead.org; Russell
>> King <linux@armlinux.org.uk>; linux-kernel@vger.kernel.org; Sean Anderson
>> <sean.anderson@seco.com>
>> Subject: [PATCH net-next v3 27/47] net: fman: Inline several functions into
>> initialization
>> 
>> There are several small functions which weer only necessary because the
> 
> *were* typo.

Hm, I thought commit messages were supposed to be written as if the patch hadn't
yet been applied (e.g. the current state as the patch is reviewed).

--Sean

>> initialization functions didn't have access to the mac private data. Now
>> that they do, just do things directly.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> 
> Acked-by: Camelia Groza <camelia.groza@nxp.com>
>