Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH net-next v3 20/47] net: fman: Store initialization
 function in match data
To:     Camelia Alexandra Groza <camelia.groza@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc:     Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Russell King <linux@armlinux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220715215954.1449214-1-sean.anderson@seco.com>
 <20220715215954.1449214-21-sean.anderson@seco.com>
 <VI1PR04MB580745EF94973A1468C9FE80F2919@VI1PR04MB5807.eurprd04.prod.outlook.com>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <3d490504-c03d-f418-cec2-c976831a224f@seco.com>
Date:   Thu, 21 Jul 2022 11:34:05 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <VI1PR04MB580745EF94973A1468C9FE80F2919@VI1PR04MB5807.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bG96OHcwNkRhajVrQi9GMHBDRkRTSFNINFloeGpWdHpIci9uV0kzak5PVUtS?=
 =?utf-8?B?RFRzeUNXd1JFTndjR1UySElTWlp5ejFHRVlvVlB1TXU0TWtFNnJnRWhnVHli?=
 =?utf-8?B?T0V5S0hRSXJlaG92VDhiWURXaVQzR3cxTUF2WXlNUUtZcHNzYmZERlJ5d0lz?=
 =?utf-8?B?L29YVTFnMTB6aGw4ZlJLNGhhalUxbzJNVmVPcHFpMkk2Sk12S1BsbUpsSTFH?=
 =?utf-8?B?aVZXc2JlV29oS1k0Ty9Kei8waVlSTDFZM0xEOWVGMm1FUXZ1bmlCQXQ5bkw4?=
 =?utf-8?B?T0YzU0JVWE9jQjhqVmY5ZVpWSTRzMDFyMDlNbGYwR0xmTWJOajQ0RWJkWk42?=
 =?utf-8?B?Wjd3RTB0WVRXZEVhNllUVlVIOUh3eXZXS3dmRVUyK3QvQWR4QUpSMVQwK3BV?=
 =?utf-8?B?dm9kUEFiN05iQ3dPcmlLemNuNjNwMGllQkJVMEFjNEh0WTdoODg1QWllcGxr?=
 =?utf-8?B?MzhkUUFzanNJUm1kQy90N3l5SU1udTRvYmFYalE5LzJMVzZXM3NEd01icVNq?=
 =?utf-8?B?blYxdjVkRENLQnJFajVXYnpDbWYrSVF6L1h1MzhoYm03bFJOUkNxQWp1YXFp?=
 =?utf-8?B?MFdxMmFINmVvT1BDSFM3Rll3V2xHb3BhazUrcWM0cTdMOXYwa3dPNWxCbGs1?=
 =?utf-8?B?ZXZ1VUhQUlVSeFRVeTVpVHk4NWdjUTJqblF6dGpCOHV2ZmhwazlaTjVJU0VF?=
 =?utf-8?B?WkhlYi9BMXNQbmRoeFZhZndsdklucjI5aUdZckRDT3NYVEhVUm0rZ3daU2RV?=
 =?utf-8?B?aSsyclR2MnlnZFNudGJ1ZHFCR1lkWlJKdlpuU0tkREVDWlVPcFRMaVU2UlJO?=
 =?utf-8?B?LzBlRmRDWG5td25pR2ZwZzlvQkNPQnZtN3pOcWdXbldOYmF4VEx3RGc1c2kz?=
 =?utf-8?B?RGNuWDdyK0Z2S1NWYmczTS9EdnRJcjBwdDlzemdNUlJubFJsWGVUUzZXV1U1?=
 =?utf-8?B?TWZLTElkcE9xV2srTCsreFRQM1VILzFQMExZYXFPU1REVEhzemJjQlQyc2xC?=
 =?utf-8?B?aUpjNVVETVpIZVFWbWNELzViQmhvZDNMMnhtekVwL0ZiRnRUVlBjUTRVanJt?=
 =?utf-8?B?Wm5zcGtKWHhxM2d2ampCWFBsd3RFWE9qaDE2WDFOY2VsWG5oelpFYjNLOTNT?=
 =?utf-8?B?NUN3SkM1SUNISmZOdXFya1RDejNheitET3crK0pIcmoybHd6aGhVc3BGTUtP?=
 =?utf-8?B?ZmZVdHJoVHI3WEUzYUlSSTNsNkVhVXVFZnJjaXZEb1pxQ2RQZTFkQWlLbjhF?=
 =?utf-8?B?Y3ZoZDM1emVSbVZtaW1WTWZ4YUtTZUp4RkIzOCsrRUVuSk56Y1l0T1RheDBO?=
 =?utf-8?B?dU1yREE2cDZibllVajVLNmNTbjdRUjM1ZkVQclVkMmJ2Nkw5cE9PT3JvODE0?=
 =?utf-8?B?MkVzL2ZVQzJQT3lsdEtVNTc1cXh5MFU0UFhmQ3JkOUY4dHZMZmxQdlBYSDl5?=
 =?utf-8?B?K2N3N2hxTGNlaDBYN1FRVXVIc3FzaU1HNlJab2hlUFJka2hsNGdad3dqN2Ra?=
 =?utf-8?B?bUJPVUp2S3MrYVBuK3p0NU9Ya3duYmhOUW50MWk4ODdJWUJyaWhPYStCQXhN?=
 =?utf-8?B?c3FIR1dzTTZiQWN3NFp1NWxkSWNlZVIyZzlXT1lqVTJ2Y0hOd211UmErNVdG?=
 =?utf-8?B?dVhiSkdPbEJrRGQwNHZHMlNueE9RL3FiaFZpbUVZY25wNEZlWE1uOEF6RTBK?=
 =?utf-8?B?K2tyTXdlbGJpMUZQUHh6dm9PaUd4M0sreXkvd0N3T2RHd3dIY3I5WUI2dUV5?=
 =?utf-8?B?aG9iUExQUFB3RlZpck5aNWZ6NHE0bEVuc0RaS3djeGZvOHd3c0IwTU5oNjhn?=
 =?utf-8?B?dS9vRDdLQTBZakovbUZ3c1Noa1hVYzk4MC8rWlNRaEs4dEliUG5NcTU3M2dF?=
 =?utf-8?B?YTJEUXhmaVdPL1hBRVFrT2ZETWpUbkNBNWl1UUc3b1hudXptRGIyeVB2ajJQ?=
 =?utf-8?B?cllQYWc3R3crUVpBdzFDTlpIWDB0QnpDaGNWRnFzcWtFcGR4WTdUK0ZuMVR2?=
 =?utf-8?B?RXdvem1PSi9tTlk1N3FlSkpOUEM2blRqVW1sRy9ocUdLNHVoRGFXVVFCVXZj?=
 =?utf-8?B?eUc4azYwTmlsbDJhS1VNZmdOTDhCMXVCZGh4SUlnSGRKa1Nudy90cXBJNFJG?=
 =?utf-8?B?N3ZGUnFLcUdzVnNTYlVtU3EwaHIvd2lsZFY2TUFaN2srdXR0ZWhOcHZTdk9V?=
 =?utf-8?B?UkE9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 002010fb-a693-498b-6bd1-08da6b2e7499
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 15:34:09.6319
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DYABBiKkquTTJkPXaAMs/HDv/3jqmdmveEo15lD2tRSw+zPMrGnRvsLCHYbsc8Ij0YhM3tYvH9hp1syiybZhnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4076
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/21/22 8:51 AM, Camelia Alexandra Groza wrote:
>> -----Original Message-----
>> From: Sean Anderson <sean.anderson@seco.com>
>> Sent: Saturday, July 16, 2022 0:59
>> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
>> <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>;
>> netdev@vger.kernel.org
>> Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
>> <edumazet@google.com>; linux-arm-kernel@lists.infradead.org; Russell
>> King <linux@armlinux.org.uk>; linux-kernel@vger.kernel.org; Sean Anderson
>> <sean.anderson@seco.com>
>> Subject: [PATCH net-next v3 20/47] net: fman: Store initialization function in
>> match data
>> 
>> Instead of re-matching the compatible string in order to determine the
>> init function, just store it in the match data. This also move the setting
>> of the rest of the functions into init as well. 
> 
> This last sentence can be rephrased to be clearer. Maybe something like:
> The separate setup functions aren't needed anymore. Merge their content
> into init as well.

You're right, this is not really clear. I will revise the wording.

--Sean

>> To ensure everything
>> compiles correctly, we move them to the bottom of the file.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> 
> Acked-by: Camelia Groza <camelia.groza@nxp.com>
>