Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH net-next v3 37/47] soc: fsl: qbman: Add CGR update
 function
To:     Camelia Alexandra Groza <camelia.groza@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc:     Leo Li <leoyang.li@nxp.com>, Russell King <linux@armlinux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
References: <20220715215954.1449214-1-sean.anderson@seco.com>
 <20220715215954.1449214-38-sean.anderson@seco.com>
 <VI1PR04MB58075DFACE3A36F4FDCF7ED7F2919@VI1PR04MB5807.eurprd04.prod.outlook.com>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <17e8e50a-efbf-0cfd-e9b3-756f527f1f25@seco.com>
Date:   Thu, 21 Jul 2022 11:36:39 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <VI1PR04MB58075DFACE3A36F4FDCF7ED7F2919@VI1PR04MB5807.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3RTNko4MFlvVzNTdzBxQ0dXS0Y0TDdSeHluQUFjYTA0a3oyZDM5KzhJQXZk?=
 =?utf-8?B?cVdlZUtoNk5ZeFJYUXZBYm00VXBqSlM2WEJRV1ZaVUhwS1JuTEVWVm5ZM1Jk?=
 =?utf-8?B?ZzRWdVNTZ2ZCdGZ4VnRZWnYyWkhQd3VkQ25YTmFrN01JeThzZmlmS0hJRU41?=
 =?utf-8?B?Vm85cDVJcGl2ODNaSVBmMnM1ZTJLVmdNblpnR1pFeW8rOUJYQUhqckRGcXpZ?=
 =?utf-8?B?TTlidklaWnQwSTQyaTVsK2toT2tlWVZVUG9BMHV5c3M4YTlXNVRQQ3V1aTJX?=
 =?utf-8?B?a1RYcGFwYXNQTyttMzhsbWZpclR1WldjWXdTeEZNaDJ5K0YrUml6S2lWQlYy?=
 =?utf-8?B?cG15b21tU3QwNllJcm9PN1VJbThyelJkdEg1cnhrTmNwNHk3cTk5YzE0ejBE?=
 =?utf-8?B?KzV4TUF0eVM3dEZFNHY2VndVM2tXVzZJa0lEL3ZCNHJpUThqeGNhMmp2bkdH?=
 =?utf-8?B?Z1dPcHJFbUhQWm85ZXFTNkFKaDV4MGJUMDRrMllybjIrTWxma1hnUmdFSWRz?=
 =?utf-8?B?Wk5ZUStXRDdBaUdHd0lqOXJGTk45Ni9paUo5dERTQ1pCazBRRjFTVkRqL1Z2?=
 =?utf-8?B?dkpsMUt1OVFBbzVxQW9OdDdIN29XY2tqQWVaL2dlb3BBZ1JiekdncS9sdEhq?=
 =?utf-8?B?Mkw1MWF5Si9wMW1RRFA2SWRUOW02RUlYOFE5RzY0UXVtdTBpcWZvSWlUa0Yw?=
 =?utf-8?B?SFR2L0tualJlOUFxcVlOZDNoTHVBUHVMMWV6RERLMVE3TFA3ZXJFZ1g2NHc4?=
 =?utf-8?B?bWtxcDEwMDFmQnRDNmRXZWp5bUN2WEt3bU9zMlBmR25tYk5zSEJFVzY2WmVw?=
 =?utf-8?B?RDFraXh6bzdMQTN2Y05aQVJOY3BqUjFxZEZxNTdNWlBpUWVacmRWbWNNMm5u?=
 =?utf-8?B?ME12eXltWlQ4V2RsUU12Ui9aQURwOGd3K3QydXE3YUo0MkdMcDhON2VZOUZI?=
 =?utf-8?B?Z2d6bUMwWEN4QlpnSWlzRVd1VmF5L0QvUjQvckkyMWp1NFN5UHNPQzRiT0Rv?=
 =?utf-8?B?NzBVczJRcU9xaDZuTE5YSE9QbmIwbEhYaFNwNWRTUVJJdXk4a0lnMVNGbTg2?=
 =?utf-8?B?K3QxYXFpcVdyeGpHaE5jWmF0ZUNHYXBRY0lpUUVVMFg4NVZTaGpsVTNMaVpk?=
 =?utf-8?B?ckNGSHR1eER5Y3dkZDhjc3RzYUhONVVxNnozUU5pd1o2YTdobmt1YWR2ajd0?=
 =?utf-8?B?SlMrUzdJQkxBSEY2enZzeCt0T2dqUGRLNkl5U1ZaV2s4WmtNeXJvRzd4R3VS?=
 =?utf-8?B?UUQrU0pOSnVoWjJQR3MxeVloU055U3F4ekhTbzVETlNvS0p1dmVLb2IvQWVD?=
 =?utf-8?B?SS9VckRkWHB4NWQxZDhzUjA5R3M5SGdjUHNNdG9aUk5yTjVSZnZoNSswQjFM?=
 =?utf-8?B?VlppZFBpVTlUTkFUYVk3emQwaTV6MkZzaU9OZVVwSTVsUDNwT0I5S2xqR2lG?=
 =?utf-8?B?dUMrNDlNOU1YQm8wM2Q0M3U2WVo2ZmhaU3FiWHhWZUQ2bVVHSlh1aGRQU1RQ?=
 =?utf-8?B?d0tGN2JZMitxSkwyTC9EY2o4VSt0NTRGMkhpbmd5TzdaQjBhY0U1aldXemxq?=
 =?utf-8?B?QnNuZmxReHdpRHQ1OG81NkV2YWVwSTBxSEFQajNRRy9ZSDVXdE1ScndGQ1hr?=
 =?utf-8?B?RXlSVDNJeFhMalZVM0NPVStpbjA1WGNMRGJ5Zlc5OFpTYjFDZmx3QXNEeWZ4?=
 =?utf-8?B?bEdQN3RFMzZmendpT3dOeFNxd250QnJnUVdXSlllaC96bHZtVFpIdVh3TGtE?=
 =?utf-8?B?Z1NRbmRHMUdUMUsrSXBSNzVSYXdWNGk0cUlDN2F0TU9vUCsySkkrR0NvNnZ3?=
 =?utf-8?B?eEV3KzA3ckRJd296dzJGWFB1bUJmT2d2U2xxUWNEYXhueWtxWldWQk9zRk91?=
 =?utf-8?B?V3Q3azgraXA0S2tHMnpkWWRwNXpDWDJzSEhPR0dRNVBxcWpPQ3llMzNPNE10?=
 =?utf-8?B?M2VjS3VXZUtCRDZBRWdqRG5vdldKREZzOG12NnNVWXRMcmpRelpwZmlDeEw0?=
 =?utf-8?B?LzFPZ3FxN2VZVm9SdFpHRGpKdjRiWWlqbmNHL1pDd0N4dVdFTDZ5ckdPbzhW?=
 =?utf-8?B?Rk1WOFRQcDZxTldkYk9BRUFGVGoyZ1hQV0ppY1ZhYWhzbmlzeFVFQ1FFR3pF?=
 =?utf-8?B?Z2NvdmVUa3FjYU1HT0swbVE1eUw1K1JQekNMdmV4VUpUaHgveUxLMFVwRlhX?=
 =?utf-8?B?ekE9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b93d3fad-2eb8-4c19-eba2-08da6b2ecfdc
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 15:36:42.8094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RIwY2NE0qtYnLQOtjr7i3ADzv6IVi4QOJvEtQagA069d/Khb648Fzu273fscPVU4Zh/4h17h8F0ITRgfpsImKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB3280
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/21/22 9:18 AM, Camelia Alexandra Groza wrote:
>> -----Original Message-----
>> From: Linuxppc-dev <linuxppc-dev-
>> bounces+camelia.groza=nxp.com@lists.ozlabs.org> On Behalf Of Sean
>> Anderson
>> Sent: Saturday, July 16, 2022 1:00
>> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
>> <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>;
>> netdev@vger.kernel.org
>> Cc: Leo Li <leoyang.li@nxp.com>; Sean Anderson
>> <sean.anderson@seco.com>; Russell King <linux@armlinux.org.uk>; linux-
>> kernel@vger.kernel.org; Eric Dumazet <edumazet@google.com>; Paolo
>> Abeni <pabeni@redhat.com>; linuxppc-dev@lists.ozlabs.org; linux-arm-
>> kernel@lists.infradead.org
>> Subject: [PATCH net-next v3 37/47] soc: fsl: qbman: Add CGR update
>> function
>> 
>> This adds a function to update a CGR with new parameters.
>> qman_cgr_create can almost be used for this (with flags=0), but it's not
> 
> It's qman_create_cgr, not qman_cgr_create.

Thanks, will fix.

>> suitable because it also registers the callback function. The _safe
>> variant was modeled off of qman_cgr_delete_safe. However, we handle
>> multiple arguments and a return value.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> 
> Acked-by: Camelia Groza <camelia.groza@nxp.com>
>