Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH net-next v3 46/47] arm64: dts: ls1046ardb: Add serdes
 bindings
To:     Camelia Alexandra Groza <camelia.groza@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc:     Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Russell King <linux@armlinux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Leo Li <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>, Vinod Koul <vkoul@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>
References: <20220715215954.1449214-1-sean.anderson@seco.com>
 <20220715215954.1449214-47-sean.anderson@seco.com>
 <VI1PR04MB58077A401571734F967FAF12F2919@VI1PR04MB5807.eurprd04.prod.outlook.com>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <5f32679a-3af3-f3ba-d780-5472c4d08a81@seco.com>
Date:   Thu, 21 Jul 2022 11:40:40 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <VI1PR04MB58077A401571734F967FAF12F2919@VI1PR04MB5807.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1haemZIZmhJc0d1UWRhZlZpNWxTTDUvWitJeFZNU3M2WFFkOHU2b29UMmpM?=
 =?utf-8?B?K1lld0haRkdBWDE0L05scmNBZi8zdlJ3c2dVUGtKT0xtZVRzbnNvZmVjWGJv?=
 =?utf-8?B?ME5uSGpGNC9uRzU1Y1BKNE1zd0Z4WTlBdVlvaVZQY1J4M1ZqK2FGQmI2cEJV?=
 =?utf-8?B?N0FsaGRSb0NJZWtkVUJiazkrQ0xHSGo1aGFvbFFCdEovQ3RyUldmejJiV01G?=
 =?utf-8?B?bmZCRGllMmpNcW9sdk0xRldNV2VlZzZqRGw1T0pIeGRqNzFmSTYyNnlMNWxo?=
 =?utf-8?B?QUxEVmdIQWdyYUNETkVyQ3FRMm1jU3RIYXJRT3BvN2RHT09zVFVwb2pHRndI?=
 =?utf-8?B?K2pUMDZzYkhOOVdBYVpRNzBWaThVUGM0LzBTdDZObjNrMDU3NXA4TG9yc1V5?=
 =?utf-8?B?SE9DOW54bVBuazA2OS8yUHV2VFU1MnpJWGdYVVNmdU5pVTFzSzk4Q1JpVGFy?=
 =?utf-8?B?TTArZHhvYTAzeXhoWS9XMk5QRFhxd0FHNEVKSW9xb3cxaWUyNU5EKzJRNVpC?=
 =?utf-8?B?WGpQWFo0UzcvT3lLK29YZTI3aXFUYTBZbWpUb0kyZHE4cVNDTlQraHJhNGp0?=
 =?utf-8?B?N2FjS1FMR0JiMlFIdHZyNUpJbEZLMzFXV1lLQW5TSW5WTGZNNkdiV1Y3SWQz?=
 =?utf-8?B?ZERkeWN6cFhlYTJPNDVBbDQySStRTEtYV1RZb3hMRGZTK3BRRm9icUxzOExF?=
 =?utf-8?B?d01TalpZMXF5VU9PK2U5ay9ZS2NhUXp5djJHc3B3OTdKaEZSWEFGUDdRVGZW?=
 =?utf-8?B?UTd1SkpMUUMxWUN5aTYxcGVHbUJNWjEzSU5SaU83MnZpVEwydFk5YzRuOEFz?=
 =?utf-8?B?MENuNmdGQTZFWTRPYmpLU2E5Ryt0TXUvRkZGV3NueGFMYlQzQ3ZuS3FXRHM2?=
 =?utf-8?B?M1JmSUhGWG9veDhkSVlpbkVFTE5wQjVTWlBjWVkxNW41UTN0VHkveDExZytS?=
 =?utf-8?B?NUJUN1llR3crZUowUTRjd1E0QXQ1L3dIbzJyY2QvRWJvZ3E5dFZPemlqd0RO?=
 =?utf-8?B?WmpOUVRCOVcyVmdsUWV0VkVKSXdlT05RQzExV0E2akRKOVpqa2tBY0dwYjlC?=
 =?utf-8?B?WmM0WGtaL2tRV3hLMVhGUGNNNldncXF5TFZJQ0VxL01mUi9lNlFtWUgrUkgx?=
 =?utf-8?B?ZjVFT0piM2pyS2J3MEdDajFQVlRJTjUwU3dveGxtZHRwdkRkUlNWT3ZadHpQ?=
 =?utf-8?B?aFFCOHg2SytNTU1ZSlpGMXQ2U1kyd3pzamM1WElrMERoaWRLRE5ySTEvUlVx?=
 =?utf-8?B?bHJKQUlVMnZxYjNTejJTTlRpTWVoYktKaWdzdmVvWkZlNUdKbVpybTVCeEJw?=
 =?utf-8?B?dWw3UHIwOXBpZTc0SnA5RjNEeDhkN09RODQ5ZlV4NjhRb3JPWEtXcEkzVDJl?=
 =?utf-8?B?QklRdm1rNDhyOUF3Y3Rld0JUMjJuYk02cm1DaXZ4NUZiRHFuVkZFeVc5ZFpr?=
 =?utf-8?B?aGpJVk1iY3lUc1I5NW03R3ZncVFXQXpKRDJIc0FrcnprZGZQU08zWEpVdnRh?=
 =?utf-8?B?RDNVc00zdW15dVhYY3hSYjErc0N1NnZUMnhYME1NSGNpV0VNUVdyUitTdHVO?=
 =?utf-8?B?dFpMcFlVYWxFcm5QN0I5MXdIMUJzbk05NnNkUUoxOEVrbERWV2hjY0psZSsz?=
 =?utf-8?B?cWltMzk2QmpwOWVMZ1BmeTkrblpIdllkWG1HUEpLWE91cHBOQ3V3a3F0YXI4?=
 =?utf-8?B?YzJUdDRTL2JjbGhMYVIwR2krRjBQMXR0N1pCb3lIcUxUSHJ3NUtMbDlzL25v?=
 =?utf-8?B?S1JIZFF5ckZKMk9EcXI2Tjk2Q1IrR0szazhQa1ZReThiUGM3QytMWnBlbzM3?=
 =?utf-8?B?WnZGeWpUMmkyRUd4TS9raTViUTMyZ0xXMm9aZW1DK2VxUXc4MkQzU0ozOWlM?=
 =?utf-8?B?QU94TVFHbjVVRUNDcy9JenJRdGdIRnBoUS9jeE5FaHhsM1ZxZktObXNpbGlS?=
 =?utf-8?B?RmJMY1dWVnJxYXlXVHEwUjBuQTFCcHdnTzVLTXVWbHp1ZktwR2doQ1pkaW50?=
 =?utf-8?B?NUZyNmg3TnFYU1MwbDd1TndHVmxVSlhyaDRsbkFTRFRqd24wUTFadDc4djAw?=
 =?utf-8?B?cng1ZFJjTkxsYlFLL2I3SzBkR3N2MGdRZXA1MlBXK0h5MlFtZFRaQmdadlZl?=
 =?utf-8?B?QnE1VS9lczRzczUrbHNaU0huVGw3QVYreDFsWmpzSm54d2FUTFg4OUVTR1dU?=
 =?utf-8?B?OGc9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed303953-cfb8-4b45-5a54-08da6b2f60b1
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 15:40:45.7935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fQGx2vi5laloRfF7trp9DHbwK4lr4CoTowV/IRTj2N+qQj0ajxrUYZhU1abZOg6c5m7njfLKRCnQ9akfapiI1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB3840
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/21/22 10:20 AM, Camelia Alexandra Groza wrote:
>> -----Original Message-----
>> From: Sean Anderson <sean.anderson@seco.com>
>> Sent: Saturday, July 16, 2022 1:00
>> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
>> <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>;
>> netdev@vger.kernel.org
>> Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
>> <edumazet@google.com>; linux-arm-kernel@lists.infradead.org; Russell
>> King <linux@armlinux.org.uk>; linux-kernel@vger.kernel.org; Sean Anderson
>> <sean.anderson@seco.com>; Kishon Vijay Abraham I <kishon@ti.com>;
>> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Leo Li
>> <leoyang.li@nxp.com>; Rob Herring <robh+dt@kernel.org>; Shawn Guo
>> <shawnguo@kernel.org>; Vinod Koul <vkoul@kernel.org>;
>> devicetree@vger.kernel.org; linux-phy@lists.infradead.org
>> Subject: [PATCH net-next v3 46/47] arm64: dts: ls1046ardb: Add serdes
>> bindings
>> 
>> This adds appropriate bindings for the macs which use the SerDes. The
>> 156.25MHz fixed clock is a crystal. The 100MHz clocks (there are
>> actually 3) come from a Renesas 6V49205B at address 69 on i2c0. There is
>> no driver for this device (and as far as I know all you can do with the
>> 100MHz clocks is gate them), so I have chosen to model it as a single
>> fixed clock.
>> 
>> Note: the SerDes1 lane numbering for the LS1046A is *reversed*.
>> This means that Lane A (what the driver thinks is lane 0) uses pins
>> SD1_TX3_P/N.
>> 
>> Because this will break ethernet if the serdes is not enabled, enable
>> the serdes driver by default on Layerscape.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>> ---
>> Please let me know if there is a better/more specific config I can use
>> here.
>> 
>> (no changes since v1)
> 
> My LS1046ARDB hangs at boot with this patch right after the second SerDes is probed,
> right before the point where the PCI host bridge is registered. I can get around this
> either by disabling the second SerDes node from the device tree, or disabling
> CONFIG_PCI_LAYERSCAPE at build.
> 
> I haven't debugged it more but there seems to be an issue here.

Hm. Do you have anything plugged into the PCIe/SATA slots? I haven't been testing with
anything there. For now, it may be better to just leave it disabled.

--Sean