Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bf488730-b464-5f1c-4eb8-a150900eb7fd@opensource.cirrus.com>
Date:   Thu, 21 Jul 2022 16:49:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] ALSA: hda/realtek: Enable speaker and mute LEDs for HP
 laptops
Content-Language: en-US
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
CC:     <tiwai@suse.com>, Stefan Binding <sbinding@opensource.cirrus.com>,
        Kailang Yang <kailang@realtek.com>,
        <linux-kernel@vger.kernel.org>, Meng Tang <tangmeng@uniontech.com>,
        <alsa-devel@alsa-project.org>,
        Werner Sembach <wse@tuxedocomputers.com>,
        Tim Crawford <tcrawford@system76.com>,
        Andy Chi <andy.chi@canonical.com>,
        Cameron Berkenpas <cam@neo-zeon.de>,
        Yong Wu <yong.wu@mediatek.com>, <patches@opensource.cirrus.com>
References: <20220719142015.244426-1-kai.heng.feng@canonical.com>
 <444a7ab6-d47e-6e0a-de0c-1efb292edb8a@opensource.cirrus.com>
 <CAAd53p45FkTMgV1_iGJfiya-EN7cuv_V1QCvOZirmy7CubxJAA@mail.gmail.com>
From:   Lucas Tanure <tanureal@opensource.cirrus.com>
In-Reply-To: <CAAd53p45FkTMgV1_iGJfiya-EN7cuv_V1QCvOZirmy7CubxJAA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 7/20/22 03:07, Kai-Heng Feng wrote:
> On Tue, Jul 19, 2022 at 11:27 PM Lucas Tanure
> <tanureal@opensource.cirrus.com> wrote:
>>
>> On 7/19/22 15:20, Kai-Heng Feng wrote:
>>> Two more HP laptops that use cs35l41 AMP for speaker and GPIO for mute
>>> LEDs.
>>>
>>> So use the existing quirk to enable them accordingly.
>>>
>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>>> ---
>>>    sound/pci/hda/patch_realtek.c | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>>> index 2f55bc43bfa9c..cdbee71e83216 100644
>>> --- a/sound/pci/hda/patch_realtek.c
>>> +++ b/sound/pci/hda/patch_realtek.c
>>> @@ -9109,6 +9109,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>>>        SND_PCI_QUIRK(0x103c, 0x89c3, "Zbook Studio G9", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
>>>        SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>>>        SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>>> +     SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>>> +     SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>>>        SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
>>>        SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED),
>>>        SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
>> Hi,
>>
>> Can you send us the ACPI dump (DSDT file) for review for both laptops?
> As attachment.
Your DSDT looks good, I will +1 your patch.
>
>> We want to ensure that the ACPI has the correct information so the
>> driver will work properly.
> One thing we noticed recently is that _all_ systems that are equipped
> with cs35l41 have rather weak speaker output.
> Sound is barely audible when the volume is around 50%.

Full speaker performance will be enabled with DSP support. The code for 
this has recently been merged and you may need to backport it to your 
code base.

Additionally, the appropriate firmware and tunings need to be available 
for your specific SKU.  We are in the process of pushing these to the 
linux-firmware repo now.  If there is a particular SKU you wish to 
prioritize, then please let us know.

>
> Kai-Heng
>
>> Thanks
>>
>> Lucas Tanure
>>