Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2 10/11] net: phy: aquantia: Add some additional phy
 interfaces
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Alexandru Marginean <alexandru.marginean@nxp.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S . Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>
References: <20220719235002.1944800-1-sean.anderson@seco.com>
 <20220719235002.1944800-11-sean.anderson@seco.com>
 <YtfodwyLc5pMw4Gb@shell.armlinux.org.uk>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <35c49437-c0fa-509f-f56a-530986891131@seco.com>
Date:   Thu, 21 Jul 2022 13:15:54 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YtfodwyLc5pMw4Gb@shell.armlinux.org.uk>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OStwcGFqWWx6UmJmT3FFbFViblhtazY2TFBDQlE0QU5UZmkrK2l2cFJBR1dR?=
 =?utf-8?B?enErZ3JiWW1GRmREUjZDUDd1VXZaWlUrOHByMDdMak9GbFc5ZGVIOHhGQWxj?=
 =?utf-8?B?eTcrdStzMzdoUFRweWpjK0dWcnUydUNzMXQ0M1pCVVJyTERqd2g1RHF5K3FX?=
 =?utf-8?B?YjQ0QStZa2xsVHJVZU1pK0F0U3h5enZ2NGpMYUsvS0dBVmU2V3pQZmVRTm5F?=
 =?utf-8?B?c1R4elIwYWxTbEFacmhxMzd6TkdEZ1RYdWkveHExZEI3VDhiSFNCMmVJRnJS?=
 =?utf-8?B?YWNobEdMQlNaRzM1QXNaZHJGZFRkZzB2dEk5V0JFUVNFNGtIYnNxVTlKQVpD?=
 =?utf-8?B?a2szL0kxTzZPRmNOZUpkd1BCSjNyVjVRcDU3djliY3ZwM0RJL2tUTlNDaGI0?=
 =?utf-8?B?NkttTXF6MTNtQkxBdG5kVjNFSE9rSGlkaDVyMU53OGZob2xJbGF0QnJxaXVE?=
 =?utf-8?B?OURmVFAzZnlMcEVXa2FhZzZFZ3NVU0RuTFRTRWYvS1hDclF1QnJwQ3dBckhW?=
 =?utf-8?B?VVlKTWpsY3FJaUo5UVVFclhWbFpQbU92dGFRSVd1Y1JpU2ROUGJsdVFaV2lS?=
 =?utf-8?B?YnNuQjJlSkx3K3RhNVRsODFndnZHSDFVTUFRVURCbU1KRG1QdXI1N3pKb0Yz?=
 =?utf-8?B?RXRwUUNEK3lhcnVhL3FPNndibVEzVjhuRmc1NmxMcDlNQVBsT2h1MFJhUUVB?=
 =?utf-8?B?dExhdk0vK1Q1a3c0eVlteXZTU0M1TVhFSnhOQnBUYi94UXd6MDVmZFArSUtS?=
 =?utf-8?B?eS80WkYwMS9ETUczbjdxOU56cTFsckQ0ZHIrTjFNVDEzd3F1bitxQ0hZNWVv?=
 =?utf-8?B?Q1JiV3ZjVzJPenlmQlZ4ZWZ2b3hmYXp4d2RSSmVmeGZhSGQ4VkJQcFdnY1NV?=
 =?utf-8?B?d1RReXl0OWxUOXJnYTlIeEM3Y2dZdUZFamI0c29kalNwNVhMNm9kQTJsOFFS?=
 =?utf-8?B?VHI1WjNiVzVreVJNS3FibTNQc1ByOVIrdmRmbC9KSitRbW9BbzRaMXhPcm5D?=
 =?utf-8?B?TXYvSm92SUtpbXdJczdLTTIrNUFBanVENlJPVWovRk14Wnd3MlYvSUNyaks4?=
 =?utf-8?B?bVZ2dktPRE1oeS9EZFVvdWFtWkN5bnRlZnhVbml5TjlLNnVYbmdta2xiOTg4?=
 =?utf-8?B?RFFDVW5UZHl0eUwwUEd0RzNkeU1UYzZ1YVd6VGF4amthNWtnc1BsNTlUWE9H?=
 =?utf-8?B?YWxMc2RqOG9OSGRWd1piMXZ0ci9GUXZmQ2lVNy9yRitCU01lVkMyVDNRelRo?=
 =?utf-8?B?cGlUNENwWWJIQWZsL1BUdVVWMVNTQ05iVG84a2gvZTJxUWcvSFJ3SldrZlNF?=
 =?utf-8?B?d005NjNJeTI0LzRFVVJtN3RyT3NNQkpZaTRLQmFXM1E4M0xrSEJjUGc5NFJJ?=
 =?utf-8?B?ZWVseUEzendvVVhxNVY1QWV2cmgxYW1CbTZSUnd6UVIyOTh0eWVBc1NEK3NZ?=
 =?utf-8?B?Si9rU3FHSUtzNVpFRTRWRzFKTTRnMko4ZGI4OUtnYnJNSlNVWTRjSXN3M2p3?=
 =?utf-8?B?OW5nVWxGYzgwYitwMnZGZEk3cVFLSHpScmJRcnFpZGNVQllYUUlISTU0TndX?=
 =?utf-8?B?VXh1M2ZlYlJXWHYvMms5VnZrWjRNK2VidHJBbURhR1o4enZRUFZ1SzRZL3Fv?=
 =?utf-8?B?a2JIODJTOXdKOUxhN0JjRjRoZGhPcGJMRUcydW0zMW1sc0lnK3Jhd1BUWGkz?=
 =?utf-8?B?MFYzU0xXWVNyV05jRnVGWjlnWGRsbVJzWEdJQkRWOGxadS9XeGd2MHoxUTVi?=
 =?utf-8?B?Ritwa3FQaEJSUjRWQW1VblBxK3Axb1lrYTRJamtXU2xQaUM5ZlRqZlBpb0p0?=
 =?utf-8?B?R2J0T0dvcjc2QS9SbWFXQ3J2MFY0MDh4ajk5SzFiSERnWmMxeFhjL0hMSlFL?=
 =?utf-8?B?eGswNkJDRXlNWllWaTVyeno0TXJJMzlaZ3JrQXA2NklGL2xEZmZTTVNoam8y?=
 =?utf-8?B?QS8xRkszMnFENERjd3NvZ1Y0Q3ZlbFNkdmpGY3lxclM3Y1IyUHQ2Um9VK0M4?=
 =?utf-8?B?QlhKblhxeElCTXZXelFSVmpScUI4TGNwUkZ3UlN0MFN3cWswaC9WUHBaeGVn?=
 =?utf-8?B?dEdlMnhFWDJTTmR3L3RldjZpUksxYXNDNzJJMjZNMG5QRkl5UFJFR0g3REhk?=
 =?utf-8?B?ck1CczFOd0tTR3BIWmdnanF0WW90UHVsTXpLaER1SlVoRlZ1bnhhdHdKaHJT?=
 =?utf-8?B?RXc9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61ff3f9f-1688-4f4d-2e4b-08da6b3cae04
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 17:15:58.9940
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6a+Uflh4+dHRYqXFgNJCubbeFCPUh4rWemo3ByprRfA7BkYShraiUIppYk6cVj+U9RJfSck18wNiAv5Flyy1UA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5126
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/20/22 7:35 AM, Russell King (Oracle) wrote:
> On Tue, Jul 19, 2022 at 07:50:00PM -0400, Sean Anderson wrote:
>> +/* The following registers all have similar layouts; first the registers... */
>> +#define VEND1_GLOBAL_CFG_10M			0x0310
>> +#define VEND1_GLOBAL_CFG_100M			0x031b
>> +#define VEND1_GLOBAL_CFG_1G			0x031c
>> +#define VEND1_GLOBAL_CFG_2_5G			0x031d
>> +#define VEND1_GLOBAL_CFG_5G			0x031e
>> +#define VEND1_GLOBAL_CFG_10G			0x031f
>> +/* ...and now the fields */
>> +#define VEND1_GLOBAL_CFG_RATE_ADAPT		GENMASK(8, 7)
>> +#define VEND1_GLOBAL_CFG_RATE_ADAPT_NONE	0
>> +#define VEND1_GLOBAL_CFG_RATE_ADAPT_USX		1
>> +#define VEND1_GLOBAL_CFG_RATE_ADAPT_PAUSE	2
>> +
> 
> Shouldn't these definitions be in patch 11? They don't appear to be used
> in this patch.

You're right. It looks like I added these too early.

--Sean