Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c13ddeb3-2b34-09b2-ffb7-6eb7b38e2859@amd.com>
Date:   Thu, 21 Jul 2022 15:07:14 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 0/5] drm/amd/display: FPU cleanup in clk_mgr files for
 powerpc
Content-Language: en-US
To:     Melissa Wen <mwen@igalia.com>, airlied@linux.ie,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        daniel@ffwll.ch, harry.wentland@amd.com, sunpeng.li@amd.com,
        Xinhui.Pan@amd.com
Cc:     Guenter Roeck <linux@roeck-us.net>,
        =?UTF-8?Q?Ma=c3=adra_Canal?= <mairacanal@riseup.net>,
        kernel-dev@igalia.com, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20220720193208.1131493-1-mwen@igalia.com>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <20220720193208.1131493-1-mwen@igalia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VURSQlRjQS9Kb0RMSXh3UTNZVmZnZW1xM2dBT1FtaXE0VGg0RVA1VU93bVFK?=
 =?utf-8?B?d0h3VmdGbnkrTDN4MnNBYkJJUGY3Y0ppTExNNXNiMmRjcGxyeU9DWDUvZFor?=
 =?utf-8?B?OTZXd3B2cStwcWo2UUhPR3UwK1pHdyttdFllT1FkVE0wZkl5bStDRjRKeUt6?=
 =?utf-8?B?M2Zvdk9nQ3lCWDU5Ky9DallxRWwxZk9RS2FQL2ZaZVlqZWhGNWlZbFZoZTJC?=
 =?utf-8?B?MjVBa1VJc1ZiL1BCVkQwaEtTUldBbDU0cDd0UVQwNFNoenY2eGxCZllGbndQ?=
 =?utf-8?B?QjkxZUR5UmFBb1VjMldhcU9NanN2ZUtBdnhKQ3Evb1NsNEZ4TTNybG9kdmxW?=
 =?utf-8?B?c0MwQ1dKV2lBSHN5V3ZEL3oxNHJKRXhrS0dmWWFaV2FtVjRPVzdHL0YxYTNJ?=
 =?utf-8?B?d0dRY3BZUURPWVBjYjlzRzdUdmt5bExRY1Y0VCtFTjJkVEMrSWNSMGdDOXhj?=
 =?utf-8?B?VmZaNXpUV3lqMFB2c002U1BwVjJ6QmJDdlBPOUNzeDZkVXBKUExCUjNEak9l?=
 =?utf-8?B?S1pxTEV1dlBldEc1K290WEU3TW9RSFdubkNxalhvODNCVFhRa0pNZkQxaVJy?=
 =?utf-8?B?YVBYSDZCaVRhcm80YWU1ek9Tby9pSlpyd0ZhSU0rQzNTQURNY2FYWDduUWVl?=
 =?utf-8?B?ODJJbTY0REhFRkFCTWVjY01XV3NHUFFHVnR2RGZmT002S1FWWDBlbmg3VFJM?=
 =?utf-8?B?d1ZsWWRsTXlVSWpiRnBISlg2RnYxL25zZkFMTEZrNzliWGlYZzhJRDVLek5G?=
 =?utf-8?B?eE5SNTRKQ0FHeW5jdzVQbUZORmZ6cTNUYnBPdHIzdFdZc2h4WlpONXVkWm1V?=
 =?utf-8?B?SWI5NkMxZVNzaDRaMW1JMHFjbWo3VzZOL3J3U0UyMUM3cmk5N2pXTHJ6RHlr?=
 =?utf-8?B?MHhNWmhJSXFDY1d2N2RRYUhiZlpzS2dMNFJ5bnExYjRJVHhKS2c5WjFoUGJM?=
 =?utf-8?B?Z3FEci9xRGEwSFFNTDRzOW9zUWVsK2ZzWDQ4d293cittUjZvZURZK1BuSWdm?=
 =?utf-8?B?MlQvSHhHRnVMeWlRTEZQZG1USHNmVFNOaDZKNlRVMEp5SWtTVkwrVUhhUi9a?=
 =?utf-8?B?QVNQdDFJdm81L0RESC9oQjQ5THd3WUxSZFlobU1PQk9nZ1NCR3RvV1NFZjFn?=
 =?utf-8?B?Tkd2azZOOGRoM2VGR2tKVmc0am5FOS9Xc0pPWnpPQ0ppWEZXOGZLa3kzN3Vj?=
 =?utf-8?B?amZ4Y1VRcDlNVmEyYWpQOU5TbjdJc2xqVkJuaFZXMUpQU2FpWWJ0MGhVZ1lI?=
 =?utf-8?B?cE9BVC9La1NMaldhTG9NTG9lcEpDTStJaUVrRmV6eGdhaUxwME1uc3RKcys5?=
 =?utf-8?B?NFRzUkltditjUkVRYXU0YTdpZlRpV21LdkYxaDMwekoyTWlGamptVVNFT01q?=
 =?utf-8?B?U0dtaEZISmhTQmRobWVWSSt3cjI1RHF2SERyTFB6Y2ZCNUxvT0xiVy8ydkJm?=
 =?utf-8?B?ZEZNOVA3azdaSTU5eWJ2UVQvRWtuekN0N3lVWHI0VXVQMUxSQkFudGNNTGpj?=
 =?utf-8?B?T1I1cUlUV0ZobzlPcysvZVJ1U3Ura05DalUyYkYreXlPRkFTejNOYXlGNERT?=
 =?utf-8?B?cTg3MWNDOEJxSkEwSmFGRldkcFdsZkNORjlBVGtXcFFaamUxdVkrZFZQamdk?=
 =?utf-8?B?aTB6SkRiTDIzK29ZNDlya2Z6L2ExQ0oyZkc0RnZjbjNrb3lVZVMyR05tdTN6?=
 =?utf-8?B?S05leHIzcWtkSDBEdDBJbWd6YUxIL29tekRtaCtiUS9QbzdGWmNLamQwNTVq?=
 =?utf-8?B?bk5wZmhrU3dZd00vV2M2dkdtVWlTOWtiSFhGRkFjeExCS3JOM0c5QWoyNUdB?=
 =?utf-8?B?OWptc2tZOEozYVBEQjM2Y2FDeWxQa0M3SER4RGZXTE5udmVOWlF3NTFzcUlh?=
 =?utf-8?B?VWVwd09kak5Fc3ZLdC9YOHZSZ3V4N0pPSkdvamZZQTFtSk9reEtzZWpTOG52?=
 =?utf-8?B?eFc5WUFPWUpod1l2K2NjblJmK2FYZHJKK1g3ZU96Tmx6aisyV2dOTmRaZDNi?=
 =?utf-8?B?eTZjeWVnVnM4S2hLOUFsMnEreHpPcFV0NE5IY0ZaQ3NvenJNNHZldmFESURR?=
 =?utf-8?B?YUFBTnZHOWV4N2V3Z0hOYXlqNVplK1JjVHgzZ1dob0ZVaDV5dWluNDZJRFhq?=
 =?utf-8?Q?H6RnZtXzJgX04stHnExKmmF50?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7dbc2177-3553-4174-b5c7-08da6b4c3ddb
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 19:07:22.6935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nmTyKh+dtHX2kSONbGTy6LvxGIz4PF+Z5pKcUfTAyw+6Nr4AGf4Mc/vP02tx/VZTXS+oIBCXG0gnlU0nuVMSqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5376
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-07-20 15:32, Melissa Wen wrote:
> An initial report from Guenter[1] shows some soft-fp vs hard-fp error
> from DCN31 clk mgr for powerpc. I was not able to reproduce it
> cross-compiling with gcc-powerpc-linux-gnu and gcc-11.3, but thanks to
> Maíra tips, I can reproduce the issue using make.cross, as follows:
> 
> - wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> - chmod +x ~/bin/make.cross
> - mkdir build_dir
> - COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 ~/make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash

Hi Melissa,

I didn't know about these steps, I was trying to reproduce this issue by 
using the standard cross compile package provided by my distro (Debian 
testing and ArchLinux), and as a result, I was never able to see the 
problem. Anyway, I can now reproduce this issue, thanks a lot.

> with a config file generate by allmodconfig
> 
> So, the first patch fix the issue reported by Guenter. The second is
> just a cleanup in dcn31_resource file to remove useless DC_FP_ wrapper.
> Finally, the last three patches I'm removing the -mno-gnu-attribute
> option, that was just hiding FPU-associated code in clk mgr files of
> dcn21/30/301, and moving them to DML folder. This series doesn't cover
> recent drivers dcn32/314.

I validated this series in our internal CI by running multiple IGT tests 
in numerous ASICs. Tomorrow we will also send some extra patches 
associated with this FPU effort; hopefully, after that, we will finally 
have all the FPU code under DML. Again, thanks a lot for your effort!

Thanks
Siqueira

> Thanks Guenter, Maíra, Siqueira and Alex for all inputs on this
> debugging process. Let me know your thoughts on this approach.
> 
> Melissa
> 
> [1] https://lore.kernel.org/amd-gfx/20220618232737.2036722-1-linux@roeck-us.net/>> 
> Melissa Wen (5):
>    drm/amd/display: fix soft-fp vs hard-fp on DCN 3.1 family for powerpc
>    drm/amd/display: remove useless FPU protection wrapper from
>      dcn31_resource file
>    drm/amd/display: move FPU code on dcn21 clk_mgr
>    drm/amd/display: move FPU code from dcn30 clk mgr to DML folder
>    drm/amd/display: move FPU code from dcn301 clk mgr to DML folder
> 
>   .../gpu/drm/amd/display/dc/clk_mgr/Makefile   |  18 --
>   .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 234 +----------------
>   .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.h |   7 +
>   .../display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c  |  63 +----
>   .../display/dc/clk_mgr/dcn301/vg_clk_mgr.c    |  86 +------
>   .../display/dc/clk_mgr/dcn301/vg_clk_mgr.h    |   3 +
>   .../drm/amd/display/dc/dcn31/dcn31_resource.c |  11 +-
>   .../amd/display/dc/dcn315/dcn315_resource.c   |   5 +-
>   .../amd/display/dc/dcn316/dcn316_resource.c   |   5 +-
>   .../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c  | 235 ++++++++++++++++++
>   .../drm/amd/display/dc/dml/dcn20/dcn20_fpu.h  |   2 +
>   .../drm/amd/display/dc/dml/dcn30/dcn30_fpu.c  |  63 ++++-
>   .../drm/amd/display/dc/dml/dcn30/dcn30_fpu.h  |   1 +
>   .../amd/display/dc/dml/dcn301/dcn301_fpu.c    |  74 ++++++
>   .../drm/amd/display/dc/dml/dcn31/dcn31_fpu.c  |  11 +
>   .../drm/amd/display/dc/dml/dcn31/dcn31_fpu.h  |   3 +
>   16 files changed, 423 insertions(+), 398 deletions(-)
>