Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d57bf8b6-f4f9-dda5-72e9-e5cc55081eb9@amd.com>
Date:   Thu, 21 Jul 2022 14:55:46 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 2/5] drm/amd/display: remove useless FPU protection
 wrapper from dcn31_resource file
Content-Language: en-US
To:     Melissa Wen <mwen@igalia.com>, harry.wentland@amd.com,
        sunpeng.li@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch
Cc:     Guenter Roeck <linux@roeck-us.net>,
        =?UTF-8?Q?Ma=c3=adra_Canal?= <mairacanal@riseup.net>,
        kernel-dev@igalia.com, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20220720193208.1131493-1-mwen@igalia.com>
 <20220720193208.1131493-3-mwen@igalia.com>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <20220720193208.1131493-3-mwen@igalia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SU9yUjg2Q3d1RCtBTzFQa2pIUkJCTmxrRGZ0dE9wQVpCbUtyQ2FyNitjNlAz?=
 =?utf-8?B?QXdWNllzamROT1d2RmxidThvRjF6MDdyZWdiRFdMUE5WYkpxV2NwWTlSZTNX?=
 =?utf-8?B?YlF4OFRzSy93Y1puaGdOazFlNlBaZXVBOVhzb1c1QVJrZFhmdEtpY1hoQloy?=
 =?utf-8?B?dEk5ZUdWeGRkN0dSN1RIdWdSUHYzaGpUYXhoRWtyU3ptUnowQmNzVW5KOWJl?=
 =?utf-8?B?SnZJdWRBTEtpemJOUXdodzh4Y09KMXJjalZkUTZMTkNtWGhtT3llYjN4QXZt?=
 =?utf-8?B?enR5N052RHN4SHpVa05DckNJb21nVlJuUEoreFRZMmtGdHNKdFdmRTVsMFk0?=
 =?utf-8?B?bWhadkZ3T2J6RUJxV1FtN0F3bS9aVlo0NExvOWZXNEFyT1VjSEhVakdGWnNY?=
 =?utf-8?B?RnNhQVJnY3c5SS9sSXJBTG0zem9RY0xBSnVQbHl0NS9YZ203aUt1cFcvQ3pS?=
 =?utf-8?B?d21aT1pXNnNzN005TnpZd0hVVXhFdFJYN2JzMkhoZjg0cWwvWHExd2pUVGhz?=
 =?utf-8?B?c1A5bHNtSE9qTlRsMXhvdEJveXdJMGY1YzRCbDVyTGVCRTl2citISG1iSGpD?=
 =?utf-8?B?NE1EMkpSTkdpSWtQdkxHTkpMaTY4VmRqMEdLY0JKZFh3UDYraW1WTG1YbXU1?=
 =?utf-8?B?d09VR1Zob0ZwaG4xeWhDeUdtbzdwc2MvSldUNzJlaklGUlJYdXZPSnBGeHNC?=
 =?utf-8?B?OFBicEUramR4cWc5UkhQQTY2VE1WZ05TV1BwZkQwVzR0WEVlWmNFdGhaOHIv?=
 =?utf-8?B?UVR4YjRtbDdJVEQrV0xVSkhYbCtacXZFbE9oTnpvbVowODN5NGlpckdNUFpi?=
 =?utf-8?B?VkRUVjQvN2NyeUpjV29xeUZEU3BncGJqQ05zay90NWVraGRvdmxPRExvajc5?=
 =?utf-8?B?V3RkODFHVEJHRmxQZHd4bi93S3RTaXpXM2dXdzJySVJBSTdWcE9aVDJuNkJC?=
 =?utf-8?B?R3NUK1BSeVdDU0JBcERtbUxIQVp0OFZzdTRQS2p5S3JxcnlWUVFIYWNidDg0?=
 =?utf-8?B?SVpxQ0NsaFB1VzhXRjZ6UWNqWlRrVEI2UW9SMFhpTUZSZkd6OElVbnNwaVBD?=
 =?utf-8?B?STlLL0tBS1NLMThOY2RORlhzLzYvYzg5aElLajBjdlFyb3NkVTg3VVdocjJx?=
 =?utf-8?B?aVBiWXIvWTZwL3VlR0NvaCtacVdjdXlNekJ3YVBCOGN0WUdJbXFjNDBLQmdI?=
 =?utf-8?B?bFVENEVTSkhsOGQ0c0RKVUhMcU54OUxheWlKKzZiOXl2a21xNGNHdC9iRW1u?=
 =?utf-8?B?TDkzTklOektmU09YZWFTczh0YTcvTllBRlVpOHRsL2p4RTZVSStnblByZHln?=
 =?utf-8?B?MzVqNk9Pc1YxM2ZzRW9vdDk2UTZOSlNRZ0hxRG1yYnIySkFxV3JiZDFxMzla?=
 =?utf-8?B?TGcvM25ycE9QcFBKUWxEa2FaMGVta2FTZGswQk9id1Z1ZmtxdWpHY2JDblNL?=
 =?utf-8?B?c29xUzdGVDFBT0haRUZtTGF0MDZWcDBnczR6bHRkK0V6MFJReHR3WDZtRzlD?=
 =?utf-8?B?VVpad3hSVFM1Z0ZrNk0xOEQwZm1WZWlTcm1oUjYvY1RUN3JjcVBzdDhOYWlx?=
 =?utf-8?B?UFcwYXZyNE5YWkpKbE1PYVQ2cXN3dHNibVFNZHhKRnIxRDhyUFR6ZDB1N0Er?=
 =?utf-8?B?NmlJQm5pdmRhRTVOVEVNMVpFT3pjWUFsOHlvWUxScUtjSUo4NlVqVUFBMnRC?=
 =?utf-8?B?eE9CM2lTVEc3L215U0J5UnNQNFdRTDBVc0JiZVNsOVNjYm4yYVIxVTQ4MVlH?=
 =?utf-8?B?WkdwMit2cGFMQTJ2WEJHMmxpVVIvQkFwVUtvNkxyYzVNWGFLUkRwTjlUeXN2?=
 =?utf-8?B?ZG9haDNneEYreFlsWnR4MnRTcGFYMXdMbk9kbm95VHpOci9BampuYlB5MVpq?=
 =?utf-8?B?TkxZTEhaV0xsQXRlWGhWMlJvL0thUGpvTzVkNVBNNjlhVDk2eENYMzZqRGlM?=
 =?utf-8?B?Z1h5N0N1cDM1QjlUWUR1bm5LQ1N3YWJzWTFHeDhxNzFKTXZ6bHNSbkVzYXd4?=
 =?utf-8?B?cDlrY3RPWGFvR05Wbk14TVVMb09jaE1SOWR4QnQ2OVN2SU5rWFJBVWFlaTQ0?=
 =?utf-8?B?Y3JhaUtoWklyTmlWMUx2Y1FZWmxZK1ZrM3V0V2JNZXNFb25SRGtIc1dieWxY?=
 =?utf-8?Q?XKTpW1AQjhivuttEUshSNS1jh?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b94aa84-597c-4c09-de2c-08da6b4a9fde
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 18:55:48.2000
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eNT2QOA9Src3giIv1HcUEluOiyRrOBYQhzryIRBGAtBkOmJirAR1wJUmtuUFuInW0PyoWjJ1/GdNFIRCcnIbzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3940
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-07-20 15:32, Melissa Wen wrote:
> Many lines of code in dcn31_resource_construct are wrapped by DC_FP
> macro to protect FPU operations; however, there is no FPU in this
> region. Therefore, just remove the wrapper for clarity.
> 
> Signed-off-by: Melissa Wen <mwen@igalia.com>
> ---
>   drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> index 929b712cbada..6d25fcf865bf 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> @@ -1863,8 +1863,6 @@ static bool dcn31_resource_construct(
>   	struct dc_context *ctx = dc->ctx;
>   	struct irq_service_init_data init_data;
>   
> -	DC_FP_START();
> -
>   	ctx->dc_bios->regs = &bios_regs;
>   
>   	pool->base.res_cap = &res_cap_dcn31;
> @@ -2175,13 +2173,9 @@ static bool dcn31_resource_construct(
>   
>   	dc->dcn_ip->max_num_dpp = dcn3_1_ip.max_num_dpp;
>   
> -	DC_FP_END();
> -
>   	return true;
>   
>   create_fail:
> -
> -	DC_FP_END();
>   	dcn31_resource_destruct(pool);
>   
>   	return false;

Very nice catch!

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>