Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c3b142ff-4a54-036d-320d-0b74410ba825@amd.com>
Date:   Thu, 21 Jul 2022 14:55:17 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] ACPI: PM: x86: Print messages regarding LPS0 idle support
Content-Language: en-US
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Len Brown <lenb@kernel.org>
References: <12039470.O9o76ZdvQC@kreacher>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <12039470.O9o76ZdvQC@kreacher>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0tHaVdxdTBuZ3R3SFBGZ0tkN2kvVWlBVHFYSmhKY0xTVyt0UjZLd21nUFVO?=
 =?utf-8?B?QzQ2NGpYNFFYRTBmTDZEM1hxTWhHSHdPd1ppb3BuNldOd2svSmdhcGhGNWsw?=
 =?utf-8?B?RFNEaFRpbWtrMmlvQlNuS29OSm0zeFJrWE1XeEl0T1owb2lvTmdwQ3JlRzE3?=
 =?utf-8?B?SDRUYVpGQzY3WnFCa2ZEbTJNbXRQZGNBd0poYmtFazV5VHFxaEhEN1hSZmVP?=
 =?utf-8?B?STdOemhYTytrbVNuamRaQWNFc0R5eCs0b0thRXJxWjVqSGVQN3VzSmpFWkxN?=
 =?utf-8?B?MTd4eG9zQWplR3VteUdqY3d2NjNCSE14eEpENU1tN1B6d1k3bVRTc083ZzVK?=
 =?utf-8?B?dlR1b1AyK2EwWFhNM2NjdjQvWm5LOURoS3RIbDhBU01WRWtZQ010SVVwS3RM?=
 =?utf-8?B?RHF5S1h4V2ZYRTNRWmg1OU5BS2VUVFcwM0lkclUzYWxWMGoyb1RtaElFRjVF?=
 =?utf-8?B?ZzQwajBsNjRUd0ovMDVGbG9TNmtxWHBGYzh4RmpjRkdCd2FHSDFJc2RWVVkx?=
 =?utf-8?B?dW5GQjdKbksxZG52cWduVURja1B2dms5RHA3bTBaREIyQTNxR2VlTzFSLzEw?=
 =?utf-8?B?QmtxUWdtT2V4SjZTSWYxbGFlaW94SDdCTHVwZlJFbURYeXc3UkVBdXcrNFRI?=
 =?utf-8?B?VkEzWnJWTnVkRzgwdVh6RWk5VjhDQnhHMlM0RjV2UnpaUG9sZ0RqazA4SUtk?=
 =?utf-8?B?RzNBMGRESGpLS040b0ZmemRPYmpYNXd5cWVBYU91MFFxYk1uQml3ZHBVYTFs?=
 =?utf-8?B?U1NTOUJsYUZ5aHducGwveWlHRU1QZzhMVVMwMzRmN3dkNGpEck16WXZuZmhu?=
 =?utf-8?B?TzgwdkhsSzhXOXZxeFNCdzc5ZEE1VHFNU3lzM1R5UFdHWWZsR25XMW1SeWxI?=
 =?utf-8?B?YUtBdkcvaWRLRVFvbVVNU1lhcExnbVYxUmRzSnczbGpjb1ozNkxrMXN5Vk1m?=
 =?utf-8?B?citBcXArZmdXVm04R3NqOGVVV25HUUxoTExVZ2U2QkRKdi9uSnBjWVZHcndB?=
 =?utf-8?B?S2VSMWtETTZqeXVmV0RlZEI2QmZER2ZBNTVobUZpUjBZSGlyV1l4ZXRDYjI2?=
 =?utf-8?B?TmcvSHNPRkpKWnFabDcxV1k1MWVoQkNNaVluVmhYektMcG9tZkNZTEp4OXoz?=
 =?utf-8?B?NTZJaVZkQlA1VU9oSFFUd3dIQXlHTGZOQmpoZU1pV0M1SlJIZlpHWDJOajRh?=
 =?utf-8?B?Ri9uZlFFaTM0bXlZR3BMbkREdlMvYnIvSGFXcDRGUDc3UnBCQmhlS0NBRG04?=
 =?utf-8?B?QlRGNS9Mc21QUlNISTBiS0xYdXJyRmJKNnQ0aGxjaVRkUGlVbTYzWkZVUVpx?=
 =?utf-8?B?MmdwZ1NubzQ3V09NZU5XVm9Wby9PbXYybGhQOXFuemxKSFl4UnU3cnEvdkto?=
 =?utf-8?B?VTRxMzMvakVrOFpVUUZrWXB2UGVEcnZXbkMwODRLd0t5ZFZhQTJ4bzVZbWhR?=
 =?utf-8?B?WG0zRlRvZk54bERXR0VmMjRuTldQdWliRmV2UGdVNXZ1am9NL283Sy9CcXBC?=
 =?utf-8?B?VVNlWERvQS9iNm4rbzE5V3ZCV0tOQ0ZKTnpVdVZybjNOZldNZWlSS28yNkNk?=
 =?utf-8?B?aGFSeUJzait4YlNRQ0JzWnlZd25Jelo5THprMnlGL3pBUHU5Q2JzTWZKejNw?=
 =?utf-8?B?WkhMVEpFdDQxZ0RvL1cyZnVGb0tkVnI2K21nZGExRFlsRTRSeVhBVlJMbmlU?=
 =?utf-8?B?OE1pdjMyeEk0WHFGeUN0MzhTbUU1OFYyOWtkbTRna0FmNnVFTDJjTWxtVmlo?=
 =?utf-8?B?TzZOMW1lclBMU2k0QjdjTW1vUTB0SEpKYVJFbjh5V1pacGJMNEVzRkloL3V6?=
 =?utf-8?B?N0RvcG5ucllvRUpzdXNDUlZ6c2YwNlZneWUvZGdqVWtWL2V4ZlU5MmQrdkhH?=
 =?utf-8?B?clQ4Ri8wQVVJdVNlb0pmdlZTbXJTYi9kQUxaZGJHMnIzb2xYVWJyb1JGOGl1?=
 =?utf-8?B?WUkrck5SeCtlbnRGZGFxdWhMMmxsbkVkVzVFejVmOTZqZWxydEJHV0dWNjVs?=
 =?utf-8?B?bXBYWEZjM1RrL2pzWnZEdWkxZ2UrZGptdG9PSWlidVF5WUlMYUNUYytuU3dh?=
 =?utf-8?B?YWtOVmw2NDUreUxUM21LQzBQeFNmb0F0REs5OXZVWGZILzNKdDBNaitSb2Vy?=
 =?utf-8?Q?au9Ea+dxCAjtSnbQTk/lUcDh/?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd3906d4-f443-4f50-305d-08da6b52f013
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 19:55:18.7344
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IG2TEIEEa7r0b21ZKtELpJbKHW4wLxj32gY1/WXPnNTyNjHpV6Q0oEtsva+Erb9Ezr1UqvT9H7Hr2EQJogDayA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1745
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/21/2022 11:13, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Because suspend-to-idle is always supported and on x86 it is the only
> way to suspend the system if S3 is not supported by the platform, the
> kernel attempts to enter low-power S0 idle in the suspend-to-idle flow
> regardless of whether or not the ACPI_FADT_LOW_POWER_S0 flag is set in
> the FADT.  However, if that flag is not set, residency counters
> associated with low-power S0 idle may not count and the platform may
> refuse to put the EC into a low-power mode, for example.
> 
> For this reason, print diagnostic messages when the platform should
> achieve significant energy savings in low-power S0 idle (because the
> ACPI_FADT_LOW_POWER_S0 flag is set in the FADT) and when
> suspend-to-idle becomes the default suspend method (because low-power
> S0 idle should be equally or more efficient than S3, if available).
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/acpi/sleep.c      |    3 +++
>   drivers/acpi/x86/s2idle.c |    4 +++-
>   2 files changed, 6 insertions(+), 1 deletion(-)
> 
> Index: linux-pm/drivers/acpi/sleep.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/sleep.c
> +++ linux-pm/drivers/acpi/sleep.c
> @@ -824,6 +824,9 @@ static const struct platform_s2idle_ops
>   
>   void __weak acpi_s2idle_setup(void)
>   {
> +	if (acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0)
> +		pr_info("Efficient low-power S0 idle declared\n");
> +
>   	s2idle_set_ops(&acpi_s2idle_ops);
>   }
>   
> Index: linux-pm/drivers/acpi/x86/s2idle.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/x86/s2idle.c
> +++ linux-pm/drivers/acpi/x86/s2idle.c
> @@ -423,8 +423,10 @@ static int lps0_device_attach(struct acp
>   	 * line.
>   	 */
>   	if ((acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0) &&
> -	    mem_sleep_default > PM_SUSPEND_MEM && !acpi_sleep_default_s3)
> +	    mem_sleep_default > PM_SUSPEND_MEM && !acpi_sleep_default_s3) {
>   		mem_sleep_current = PM_SUSPEND_TO_IDLE;
> +		pr_info("Low-power S0 idle used by default for system suspend\n");
> +	}
>   
>   	/*
>   	 * Some LPS0 systems, like ASUS Zenbook UX430UNR/i7-8550U, require the
> 
> 
>