Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yevhen Orlov <yevhen.orlov@plvision.eu>
To:     netdev@vger.kernel.org
Cc:     Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Stephen Hemminger <stephen@networkplumber.org>,
        linux-kernel@vger.kernel.org,
        Yevhen Orlov <yevhen.orlov@plvision.eu>
Subject: [PATCH net-next v2 3/9] net: marvell: prestera: Add strict cleanup of fib arbiter
Date:   Fri, 22 Jul 2022 01:11:42 +0300
Message-Id: <20220721221148.18787-4-yevhen.orlov@plvision.eu>
In-Reply-To: <20220721221148.18787-1-yevhen.orlov@plvision.eu>
References: <20220721221148.18787-1-yevhen.orlov@plvision.eu>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7NZkzGAoZyI8rjsZovSwIg51mP2VBUeGEGThLQNUIi0z1FUheSSakfX4JYxS?=
 =?us-ascii?Q?K8fWAQW0TDF6/lnmwl0u18f3OmaXjrdj1+DqEgW4we4D8wm1eQRTEydCw4xo?=
 =?us-ascii?Q?5f0OTBZ+84BXxj0jYhqtPijyhbvMDPbLCc2E3Ei91zTjDBaOadk4++4tpodK?=
 =?us-ascii?Q?puhgb5dyp+BmMP0rsYjHev2y23tLJ1Q7JywCfYpiNJ56HW86vGeyg2WWmFQx?=
 =?us-ascii?Q?5nbvXIOXUZQAVCVGQNa8fIpneeTMQI1pjPj/FeLCExTijL7ZeQnpDJeEl5mH?=
 =?us-ascii?Q?kj6P7F40SqgR2OtUGM2cCg9sggOk+OnptUM7c+MgY374+KMXEoA2OROvHyGy?=
 =?us-ascii?Q?61xJVzwcdVhgHFS4/BWN1PYwvm9g3NYGs/LpvOjp6hux9YbmU4zV2iI0erjE?=
 =?us-ascii?Q?L1dfcQPft0f9HOWY1Gd+c2uVUyDF6LYVWj3yJ+wDQqmv4DDSsKxErUPDBsQv?=
 =?us-ascii?Q?+6wgeCGdUGeVVm7PpGo5VijNJc3VOoaz/p9cabn8/219jJ/Kg3HYhPHcn6kO?=
 =?us-ascii?Q?XjkInTYgRVvR8iT6VaP7tOM+8ukpaB220bRdj9kFWZs0KRI46HxpZqIGVuz/?=
 =?us-ascii?Q?PGFK5m4TxpIW7tMJTyLsVufEoCqu0j9vhi+kN/X92VAKXWK+uzqRGkazUntD?=
 =?us-ascii?Q?lUOwOKG257hf9T5bz8HgXC7OT9UmnhTNKgMQGp46k1CBStiNBcGTo06l5p8t?=
 =?us-ascii?Q?LzNMGgAGJ9shNLIH3hbby32FE1xVSi85y01T09v6vx4AbqW5coecQPCiSOIq?=
 =?us-ascii?Q?FDp7HHSUjLSDlZFPj0dVWerU6zSgU7elVSnOzjfCapA4qlShwiOE0KKJy5EF?=
 =?us-ascii?Q?H0JcLxDqarmRdf/huOZ3TwKlhlU8BLqOqPi9Rmgnb47PDsegGZ/3TyhDS2rW?=
 =?us-ascii?Q?FcUQrp3WS1Q4Pp7zGMdaSXNv519NMsfZK0upC1eb3khcguGCYu3e6Coj+tF+?=
 =?us-ascii?Q?h+DbBXDwdzdX3HhRtSu0I1VaWY4kwDasQ26QNPOA8tepn6JjcyoM8VopUEoZ?=
 =?us-ascii?Q?uz6mURPCMWx+fPE2KPX1FFnwcNJtJ6GjsxoUpcjemAueWL0Ct5SZTtjfKg5J?=
 =?us-ascii?Q?4FBquLospi4uw7jxXuMv1hHfawyewmtlFUx/vHiiUtc0oJWcVuczADnOfUJg?=
 =?us-ascii?Q?Ao2T6cdwpRPP7EhRXet7CnbOsftGXNTMbG/qQpzud0anbQQDNBLUjQF/uJEH?=
 =?us-ascii?Q?dlqPAKZyCpYlDc5kVcexswpVUFXiOSXXXCEGmesdz5VI83aHJw279azNy4wY?=
 =?us-ascii?Q?CRCHy8tsl0VMic110k+TtUbwwcup/uHEeDv/E8Pb6jyhXAUoVograDwIu9Pt?=
 =?us-ascii?Q?+3JiE8RNO1FdwDID+ILjDtk6jIvG+alLty/TW5u8fSsktXYTI2daP05Necgc?=
 =?us-ascii?Q?gE8qDCjhRFyHt+t8SXSMXl0a3GSDYr+vzi8llAS7FNRx9o8mkBmwntlNuazL?=
 =?us-ascii?Q?wPbXaeBH+NUabCaDJkzRIwFoPRBPICd/8sJxqds2nhUCILHZdsRpQUZvV2I5?=
 =?us-ascii?Q?nidveBDXEfiVuyDdwEQ0FOKcHC/70Bz81AXX9k8pyU8kJrBG+6O8mbb8qKyJ?=
 =?us-ascii?Q?0O8HrYGEUMg/NiLv+qmFT0dXSKao6Z+ksj1ykyjcVgNhTS/v9CmC/5FNkFS6?=
 =?us-ascii?Q?Kg=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: dc77d1ef-790f-4de2-4b67-08da6b660df5
X-MS-Exchange-CrossTenant-AuthSource: PAXP190MB1789.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 22:12:09.2456
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jlFIDT+kFFn5zx+AR+BAv2cM+ogJ9AoUnd0kYafT3cbPfUVPfAQ3cfuvoR110qYHOV/ozNqVAMtfNcWo7XDOdZD5huFp/DAFDvdBaVsu4tU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1P190MB0302
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This will, ensure, that there is no more, preciously allocated fib_cache
entries left after deinit.
Will be used to free allocated resources of nexthop routes, that points
to "not our" port (e.g. eth0).

Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
---
 .../marvell/prestera/prestera_router.c        | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_router.c b/drivers/net/ethernet/marvell/prestera/prestera_router.c
index e9b08b541aba..41955c7f8323 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_router.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_router.c
@@ -334,6 +334,49 @@ prestera_k_arb_fib_evt(struct prestera_switch *sw,
 	return 0;
 }
 
+static void __prestera_k_arb_abort_fib(struct prestera_switch *sw)
+{
+	struct prestera_kern_fib_cache *fib_cache;
+	struct rhashtable_iter iter;
+
+	while (1) {
+		rhashtable_walk_enter(&sw->router->kern_fib_cache_ht, &iter);
+		rhashtable_walk_start(&iter);
+
+		fib_cache = rhashtable_walk_next(&iter);
+
+		rhashtable_walk_stop(&iter);
+		rhashtable_walk_exit(&iter);
+
+		if (!fib_cache) {
+			break;
+		} else if (IS_ERR(fib_cache)) {
+			continue;
+		} else if (fib_cache) {
+			__prestera_k_arb_fib_lpm_offload_set(sw, fib_cache,
+							     false, false,
+							     false);
+			/* No need to destroy lpm.
+			 * It will be aborted by destroy_ht
+			 */
+			prestera_kern_fib_cache_destroy(sw, fib_cache);
+		}
+	}
+}
+
+static void prestera_k_arb_abort(struct prestera_switch *sw)
+{
+	/* Function to remove all arbiter entries and related hw objects. */
+	/* Sequence:
+	 *   1) Clear arbiter tables, but don't touch hw
+	 *   2) Clear hw
+	 * We use such approach, because arbiter object is not directly mapped
+	 * to hw. So deletion of one arbiter object may even lead to creation of
+	 * hw object (e.g. in case of overlapped routes).
+	 */
+	__prestera_k_arb_abort_fib(sw);
+}
+
 static int __prestera_inetaddr_port_event(struct net_device *port_dev,
 					  unsigned long event,
 					  struct netlink_ext_ack *extack)
@@ -600,6 +643,9 @@ void prestera_router_fini(struct prestera_switch *sw)
 	unregister_fib_notifier(&init_net, &sw->router->fib_nb);
 	unregister_inetaddr_notifier(&sw->router->inetaddr_nb);
 	unregister_inetaddr_validator_notifier(&sw->router->inetaddr_valid_nb);
+
+	prestera_k_arb_abort(sw);
+
 	kfree(sw->router->nhgrp_hw_state_cache);
 	rhashtable_destroy(&sw->router->kern_fib_cache_ht);
 	prestera_router_hw_fini(sw);
-- 
2.17.1