Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b8539e31-b20a-6eb5-4b86-59a17d7c6939@axentia.se>
Date:   Fri, 22 Jul 2022 00:16:36 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 4/4] iio: afe/rescale: Implement write_raw
Content-Language: en-US
To:     Paul Cercueil <paul@crapouillou.net>,
        Jonathan Cameron <jic23@kernel.org>
Cc:     Lars-Peter Clausen <lars@metafoo.de>, list@opendingux.net,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220721191526.374152-1-paul@crapouillou.net>
 <20220721191526.374152-5-paul@crapouillou.net>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <20220721191526.374152-5-paul@crapouillou.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2FqaFFHU3pPRzBLT2lybzhMRnNZSHY5SWpPRGFmUS9qaGRUWkpIUW9POTIy?=
 =?utf-8?B?dGVjMUk5OGxzUzN5YWhXVFhOYld3ajdjYmFzb3ZtY213c3c0V2J3TWZ1RkJQ?=
 =?utf-8?B?b1Z0aklpVTB6Ri9MZmtTd1pWMmJoM1FuVkVhZWJTa3hobysvYXVrZnZkS0s0?=
 =?utf-8?B?aVloYTB4Wk5Zdjk1Zm9LclBaZmVVKzZ1OWVrY1F3NlNUYmlZa3hjY0VIcit0?=
 =?utf-8?B?ZlRwRjZHK29xTDFERjJ4c08wTFBQOXpXT0JLdjhiQjk4UVdCS1pTVlhmTHY5?=
 =?utf-8?B?V3dIczlTSWRwb0ZZMmFwd3VqZ1lGRExteXhIVWYvRW40QjM4OExyUU1TcHlG?=
 =?utf-8?B?ZVVWVEFWL1puM2xFdUVOdE9uZGxKTitsSFJ5eXl6OTBLUEZsTlIxZUc5dEJG?=
 =?utf-8?B?TWE1V01zazF6Um52UGlLaHlqK0tZK1Q5dStDdC9WQ1FmdFJpaG1CbXBjTFlp?=
 =?utf-8?B?MHd3eXVqQ255WktROFN0OWp4UXZvNUdNYXUzTE5lREp2QlFudXZXa0hidVU2?=
 =?utf-8?B?d3pvM3pyNk5keENyOTA4ZTUwWEJXQ0ljb0Q1c2tKOHBsNDZDK0lTWjdZOTMr?=
 =?utf-8?B?RmlsYUw2WmRqMFkxaVVhU0svWjYrb3VBNWI2NmQwUFZ3YXpMaDFJZTNHY2s4?=
 =?utf-8?B?NWRxNkoxbHJnUTZhaWJRZVJPSHZuOU5aRkdBdFBXVWhMdXJCdWRCbGgzOEZI?=
 =?utf-8?B?dmY3Ylg5TUJCOHBRSDdZb1lhL0JIQjh6Z3lILzVZY3lSVmkvZlAwMVNQbFJ6?=
 =?utf-8?B?NnpYSzB5SFF6UlFWeGZVejl3T0MwblBOaWFLVVlMWXQrd2R3bTcxT2pBY2Uv?=
 =?utf-8?B?ZTRxQjBWT3BBNVlzazJrd2Z3bEpsZmhiUlMwMGQ4a0NvVDdTZmxHa2FXcmhh?=
 =?utf-8?B?OCsxb2g5bS9od3FrenlON25Lemk1b3BlOGRkVVV6UGNzcmZVMnlRVDJmc1Nu?=
 =?utf-8?B?cmEwSHhKR1d5UHVzbjVJckJSTG0zQVBMZmtaRnQ1UmpoRVY5cmRsWnAvbVBx?=
 =?utf-8?B?Z0Y2THFTVFA1SUVQL1hGd1ZpbWMwM1dPc1FnT2d1N2hsWWdWWmJYb1hmcUNL?=
 =?utf-8?B?bVNNSnpXWXp0K0FwRldrd1dtSzNYQUtsSFpUT054WWZGV2tXRzhhOW1FV0No?=
 =?utf-8?B?dTByMURFcjdzSXFENWtlUkNMSDVFbGROak9rVmhJUkhrN3BpQzFWbWp0TzN5?=
 =?utf-8?B?RXliTHBzYkF1aEpQdWNLalFTTGNkclZsajFLZS9Uc3p6SXdXMFZ3eVdiMkZR?=
 =?utf-8?B?YmpvZTZ6cFZ5Qjd2YVZyVEQ3NHFGcHN0eUcwN3czT2xGanlXT0ExZk82RThX?=
 =?utf-8?B?T3AwZmh6eWVOcXk2dVMyQVZsNm1jbENJRnJIUDBhQTJTUFhrdThhRjFTVHFu?=
 =?utf-8?B?NEFjVUJsbEVYQWtpZ29IS09iUVRBZGxJQWZ3dUI5QmNDWTduUTl2R3BOK0tG?=
 =?utf-8?B?U2tSU3FXeVV1dHd4V2MweDdPUFNzZ25RQ3JPeFNJYU1iYy9TZ2FrNXp6eHhj?=
 =?utf-8?B?Z2tLRHNrZDdaTllxZjJ4VjFYbUxKdFhzK2E4SHNTd0dyWVZrNkt2bE1NZWdh?=
 =?utf-8?B?bEN5VVdOU1BMRzJ1REF5N0pBRFMrMWh4RlY3aGJ2NlgxNWprbHJ3UTVqK2l3?=
 =?utf-8?B?bHVseHBnRitCQlRZUXNWV1pMUDlPSytGSGc5SU1SUnJkQTdqWTJNY3lITi9D?=
 =?utf-8?B?eTRUSVk0THE5ZnNOVnRvQ2lBaElZeEV2eU90SHMvYVlVYjM0V2xVYmxJQlds?=
 =?utf-8?B?VWNGdzRuV1V2ZkVta3E4YmhRYnoxYTJIQURrQmpvZDJaMmg2SDRIWTdBTmtr?=
 =?utf-8?B?NElZNks1emJSSnU5dFFRKzgzR2x6WkV2WldkdHNzMitzejlwN3IyYXNtYy83?=
 =?utf-8?B?d3lQL1R2Ukh5bWh5Y2draTRNOFAwYmdWbDRnTlpIK3pBSUxWWXVGb2wxVkxw?=
 =?utf-8?B?TTRlYS9Ebzd5dEN2b0R3WGVXMlBROG9WYUFlc2dwaXBDUVF3MmUrRU5uRVVn?=
 =?utf-8?B?T3BsT0tFMldQUWNKczFWcHpMOHdycGNsVG4xTU8xT3lsMzhsK2VmUmt0b2hi?=
 =?utf-8?B?dGhIam82MkVaaDFlZFRLSVNCUVVhWFVadk5EeDNGUi94WTd1NEtXTGJGdi9m?=
 =?utf-8?Q?I8Gf48fLMoDG46BROMVDN0mCv?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 75f06c4a-1c96-4b40-8872-08da6b66a1eb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR02MB4445.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 22:16:17.4687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4W9/+HYjSmlAVZAOD6P3UKEun/XUqFs4D2GtKrOUQPV21tIm6tifr/U+vthfBufq
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR02MB6539
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

2022-07-21 at 21:15, Paul Cercueil wrote:
> Implement write_raw by converting the value if writing the scale, or
> just calling the managed channel driver's write_raw otherwise.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  drivers/iio/afe/iio-rescale.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescale.c
> index 5c9970b93384..0edb62ee4508 100644
> --- a/drivers/iio/afe/iio-rescale.c
> +++ b/drivers/iio/afe/iio-rescale.c
> @@ -141,6 +141,27 @@ int rescale_process_offset(struct rescale *rescale, int scale_type,
>  	}
>  }
>  
> +static int rescale_write_raw(struct iio_dev *indio_dev,
> +			     struct iio_chan_spec const *chan,
> +			     int val, int val2, long mask)
> +{
> +	struct rescale *rescale = iio_priv(indio_dev);
> +	unsigned long long tmp;
> +
> +	switch (mask) {
> +	case IIO_CHAN_INFO_SCALE:
> +		tmp = val * 1000000000LL;
> +		do_div(tmp, rescale->numerator);
> +		tmp *= rescale->denominator;
> +		do_div(tmp, 1000000000LL);

do_div is for unsigned operands. Can val never ever be negative?
What about the numerator and denominator, can those be negative? I
think this code should live in a new rescale_process_inverse_scale
function, or something like that (and a few tests could be added to
drivers/iio/test/iio-test-rescale.c)

> +		return iio_write_channel_attribute(rescale->source, tmp, 0,
> +						   IIO_CHAN_INFO_SCALE);
> +	default:

What if the source driver has a .write_raw_get_fmt callback? That bit
of info is silently dropped (with no comment that a shortcut has been
taken). How does inverse rescaling mix with a .write_raw_get_fmt that
returns e.g. IIO_VAL_INT_PLUS_MICRO_DB anyway? I think all cases might
get a bit hairy to support, so I think you need to do some filtering
and somehow fail the .write_raw call if the .write_raw_get_fmt of the
source returns something that gets too difficult to support.

Cheers,
Peter

> +		return iio_write_channel_attribute(rescale->source,
> +						   val, val2, mask);
> +	}
> +}
> +
>  static int rescale_read_raw(struct iio_dev *indio_dev,
>  			    struct iio_chan_spec const *chan,
>  			    int *val, int *val2, long mask)
> @@ -250,6 +271,7 @@ static int rescale_read_avail(struct iio_dev *indio_dev,
>  }
>  
>  static const struct iio_info rescale_info = {
> +	.write_raw = rescale_write_raw,
>  	.read_raw = rescale_read_raw,
>  	.read_avail = rescale_read_avail,
>  };