Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 21 Jul 2022 23:23:15 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
Cc:     alsa-devel@alsa-project.org, vsujithkumar.reddy@amd.com,
        Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, ssabakar@amd.com,
        Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] ASoC: amd: acp: Initialize list to store acp_stream
 during pcm_open
Message-ID: <YtnR05hxiWNKOGoC@sirena.org.uk>
References: <20220721062043.3016985-1-venkataprasad.potturu@amd.com>
 <20220721062043.3016985-3-venkataprasad.potturu@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="w/c1cvUq36ZEZHgE"
Content-Disposition: inline
In-Reply-To: <20220721062043.3016985-3-venkataprasad.potturu@amd.com>
Precedence: bulk


--w/c1cvUq36ZEZHgE
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 21, 2022 at 11:50:35AM +0530, Venkata Prasad Potturu wrote:
> From: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
>=20
> We are currently allocating acp_stream during pcm_open and saving
> it in static array corresponds to array index calculated based on
> cpu dai->driver id. This approach will fail if we have single dai
> linked to multiple pcm device as we will have same dai->driver id
> or array index for multiple pcm open. Initialize new linked list
> stream_list to store opened pcm stream info dynamically.

This breaks an x86 allmodconfig build:

/build/stage/linux/sound/soc/amd/acp/acp-platform.c: In function =E2=80=98i=
2s_irq_handler=E2=80=99:
/build/stage/linux/sound/soc/amd/acp/acp-platform.c:108:31: error: =E2=80=
=98struct acp_dev_data=E2=80=99 has no member named =E2=80=98stream=E2=80=99
  108 |                 stream =3D adata->stream[i];
      |                               ^~
make[5]: *** [/build/stage/linux/scripts/Makefile.build:249: sound/soc/amd/=
acp/acp-platform.o] Error 1

--w/c1cvUq36ZEZHgE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLZ0dMACgkQJNaLcl1U
h9A8gwf/fL6DbtvOtKpgGASfHBvRvfVnyGcb4t2YHbwtZTMnfB3M5vvhcARidz6E
z7OCU5ds6THN+zdyGcm5+z54vHpfdw1xW4MzRiz2zuUdviLPk+op/8FdiTFsuty3
hEqhv67RHBuvBOHQx1dB4CErspqEaL9+9jX+r5JtLQFyj2isoNGiont3x6I3M1FP
E/zkne2SyW/Hz466bTPewSdoiYMe5BTDIN6y4qqYiFLWd3wWPWFMMe+Hdv/WkYaX
CcbsgGy95KfyD6QYjr8AzyCDeu7WDEbs5HuXeCpIaa4JjHZ48ES8Eg1jDy3AlJcy
+HnorlsJYlXPqpDtIPhqiwhd+iM+4A==
=BIrc
-----END PGP SIGNATURE-----

--w/c1cvUq36ZEZHgE--