Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 21 Jul 2022 15:50:37 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
CC:     Eric Biederman <ebiederm@xmission.com>,
        <kexec@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] kexec: Replace kmap() with kmap_local_page()
Message-ID: <YtnYPeH8enERkI4V@iweiny-desk3>
References: <20220707231550.1484-1-fmdefrancesco@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220707231550.1484-1-fmdefrancesco@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ni8OKC/UDbWQ8ii3YkGEr//be4UL64XNA0WLddsZvyRKHQ6kvEGxcTaAMQ/F?=
 =?us-ascii?Q?hhP7qErNU8uj5Cx01RIM8fruXxgbK+12EFQEZWpiazZ+f0XN0jsxZsQAiUAD?=
 =?us-ascii?Q?POnuBPVOYkxDSsYFtNnpH2nedqsaBgLMqg9a00C99NePacwphYRAyX5GLZsc?=
 =?us-ascii?Q?EjBkZi7QCiOTXSdZGaiKjtVjxWGy9eFJS3R1BQd1btpy1WAhwr6w72I6mvv+?=
 =?us-ascii?Q?YM4zqRuGzuzHqvfANqGCEAT13/ZZUGyYr9wYPU/WaWBRLXQiz6jvr5Jybvxe?=
 =?us-ascii?Q?MbDFDW9WDIw1Qi+GMezUsWwRfk9Z/5yNg1M5jTXEVPGLvnrWSOOiSo4GA2kM?=
 =?us-ascii?Q?jCStnYVhC9X9J8Ldy/Pw/EbpUWyaMXTyFE4TeqCFSAb0V9N5RaTMMroUMWl0?=
 =?us-ascii?Q?56RN9w0a+g2ja1mGwuiG3lrQGcJjI/pTr8kPDRiueiLmHfGrbWwGUT5i1+Wc?=
 =?us-ascii?Q?vFjpaBkvmsHULytGEWtM2ca5/VTSuvXhC+k0EwCN0vGSuQvnZD/F3sQnq38s?=
 =?us-ascii?Q?t6WgywWYsDExeFEJJoKGqJ0I0O9b2tb1qB/iBDkRWSqViE1O6YtTJXs3mCao?=
 =?us-ascii?Q?sC6YxXXTUCM71qVTLjAQmxlVCzkKEID/dJk6gix3vK+qb9YHzvKjBihISZ4v?=
 =?us-ascii?Q?Py6Ave0m/chokWjKA4OuukHMTRHQ9ZBj1ShmpzAD6lkmfMMSHkkvjyX84c8y?=
 =?us-ascii?Q?+G+R8HmM4WmLXahXKsK8+hpwtHgWp2tz/gQBJrNnzTzDqNfrXoLIGmKOulev?=
 =?us-ascii?Q?8an29HxnDe0Bj0xr5LIEb6BFf6N0j/YMTwrYgf/TJJ2z5F6/OvaYgxAhZdRB?=
 =?us-ascii?Q?JVsHlo6Ky+Y68SF4zV4z/sMh7laSpDVPzQJaxIph7HzPxjfEfJwAgWi4k23m?=
 =?us-ascii?Q?QvVbWgWht7uvDenhR1MBNNvkmdTZPIKL5cOjEqcfpSYJqKGKVyq4/t5Ucvyd?=
 =?us-ascii?Q?ev8HmhkfpxKhP8m22RL2zlzR1E/ZNeF8gydvWqdkkseWjfjCnqYsu0sQmeU+?=
 =?us-ascii?Q?lAO1Rxjb/dUVTY4eql9E1s2NdSp+16Y2PJdZXG4sZSXriFiyqnGwFd9GKmgS?=
 =?us-ascii?Q?+aRkV9TGLyLsyoeTWxhywpiKGyEYCNQ0Ikz1gWwSuUBY7NocVaGF8RpkEddq?=
 =?us-ascii?Q?ENzz/L/ZXw8oKtlwexeS01xSbgUWKAqgOzbRvpYO1eqG0itC2s52kX4o3QjT?=
 =?us-ascii?Q?/8jXRI+Q8n1x20bY4OK6F54PU2K8Y08U0SfgxVcghhduHwVzLtTNugBibhgm?=
 =?us-ascii?Q?znyU0nmWSGOv3baKoVE0qc3p17YLkdggaFyk0+lDMxQaWbY6vSJNmm9bJoVe?=
 =?us-ascii?Q?2rqPLuDYGnfK9d74oBFR3AEF5BaJtCcaexWuBHsNePctfcQLipMw8/jW/VgF?=
 =?us-ascii?Q?nH5try0bQg/ZFapZa5PqxA6sE9D/VW8Y4OpS8ut+BpoeVi9ciR9pW/lx8GIa?=
 =?us-ascii?Q?5pN7bbnpYx6QsllQwEOanylCuuGkMyBJFAqjoe4LeaIwx4gTCFAWsSRQSC86?=
 =?us-ascii?Q?3RH08Q3B1fMj4XDMcAeTbbYAZcvrydIk/ykvOz/Il9OG+0UDWlSq1TIuK98Y?=
 =?us-ascii?Q?Quwd2bc4jcYkYGRLkchk+E0yDXtMiTUpccj1ZOf5?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ce8b3964-fc41-46fd-2be4-08da6b6b70f5
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 22:50:42.8540
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cZvhq19puYoP+P/zatWTlLQS/4jDU+WVMLj4Xw44kUR1KaVupM5Xxe0H90K7hmhEN13ZtU8v2tRIHmrzVaNdjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5867
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 08, 2022 at 01:15:50AM +0200, Fabio M. De Francesco wrote:
> The use of kmap() and kmap_atomic() are being deprecated in favor of
> kmap_local_page().
> 
> With kmap_local_page(), the mappings are per thread, CPU local and not
> globally visible. Furthermore, the mappings can be acquired from any
> context (including interrupts).
> 
> Therefore, use kmap_local_page() in kexec_core.c because these mappings are
> per thread, CPU local, and not globally visible.
> 
> Tested on a QEMU + KVM 32-bits VM booting a kernel with HIGHMEM64GB
> enabled.
> 
> Suggested-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> 
> v1->v2: A sentence of the commit message contained an error due to a
> mistake in copy-pasting from a previous patch. Replace "aio.c" with
> "kexec_core.c".
> 
>  kernel/kexec_core.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index 4d34c78334ce..6f98274765d4 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -814,7 +814,7 @@ static int kimage_load_normal_segment(struct kimage *image,
>  		if (result < 0)
>  			goto out;
>  
> -		ptr = kmap(page);
> +		ptr = kmap_local_page(page);
>  		/* Start with a clear page */
>  		clear_page(ptr);
>  		ptr += maddr & ~PAGE_MASK;
> @@ -827,7 +827,7 @@ static int kimage_load_normal_segment(struct kimage *image,
>  			memcpy(ptr, kbuf, uchunk);
>  		else
>  			result = copy_from_user(ptr, buf, uchunk);
> -		kunmap(page);
> +		kunmap_local(ptr);
>  		if (result) {
>  			result = -EFAULT;
>  			goto out;
> @@ -878,7 +878,7 @@ static int kimage_load_crash_segment(struct kimage *image,
>  			goto out;
>  		}
>  		arch_kexec_post_alloc_pages(page_address(page), 1, 0);
> -		ptr = kmap(page);
> +		ptr = kmap_local_page(page);
>  		ptr += maddr & ~PAGE_MASK;
>  		mchunk = min_t(size_t, mbytes,
>  				PAGE_SIZE - (maddr & ~PAGE_MASK));
> @@ -894,7 +894,7 @@ static int kimage_load_crash_segment(struct kimage *image,
>  		else
>  			result = copy_from_user(ptr, buf, uchunk);
>  		kexec_flush_icache_page(page);
> -		kunmap(page);
> +		kunmap_local(ptr);
>  		arch_kexec_pre_free_pages(page_address(page), 1);
>  		if (result) {
>  			result = -EFAULT;
> -- 
> 2.36.1
>