Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 21 Jul 2022 18:25:46 -0600
From:   Rob Herring <robh@kernel.org>
To:     Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc:     christophe.jaillet@wanadoo.fr, krzysztof.kozlowski+dt@linaro.org,
        linux-usb@vger.kernel.org, robh+dt@kernel.org,
        amelie.delaunay@foss.st.com, linux-kernel@vger.kernel.org,
        alexandre.torgue@foss.st.com, heikki.krogerus@linux.intel.com,
        linux-stm32@st-md-mailman.stormreply.com,
        devicetree@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v3 1/3] dt-bindings: usb: typec: add bindings for stm32g0
 controller
Message-ID: <20220722002546.GA2240166-robh@kernel.org>
References: <20220713120842.560902-1-fabrice.gasnier@foss.st.com>
 <20220713120842.560902-2-fabrice.gasnier@foss.st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220713120842.560902-2-fabrice.gasnier@foss.st.com>
Precedence: bulk

On Wed, 13 Jul 2022 14:08:40 +0200, Fabrice Gasnier wrote:
> Add DT schema documentation for the STM32G0 Type-C PD (Power Delivery)
> controller.
> STM32G0 provides an integrated USB Type-C and power delivery interface.
> It can be programmed with a firmware to handle UCSI protocol over I2C
> interface. A GPIO is used as an interrupt line.
> It may be used as a wakeup source, so use optional "wakeup-source" and
> "power-domains" properties to support wakeup.
> The firmware itself may be flashed or later updated (optional). Choice is
> let to the application to allow firmware update. A default firmware could
> be already programmed in production and be customized (to not allow it).
> So the firmware-name is made optional to represent this option.
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> ---
> Changes in v3:
> - Add connector to the required properties as pointed out by Krzysztof.
>   Update commit message to explain why the firmware-name is optional.
> Changes in v2:
> - Krzysztof's review comments: update commit message, use ports, use
>   unevaluatedProperties: false for usb-connector schema, define maxItems
>   for power-domains, adopt generic node names, remove quotes
> ---
>  .../bindings/usb/st,typec-stm32g0.yaml        | 91 +++++++++++++++++++
>  1 file changed, 91 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/st,typec-stm32g0.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>