Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 22 Jul 2022 10:10:02 +0800
From:   Oliver Sang <oliver.sang@intel.com>
To:     "Darrick J. Wong" <djwong@kernel.org>
CC:     Dave Chinner <david@fromorbit.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "Darrick J. Wong" <darrick.wong@oracle.com>,
        <linux-xfs@vger.kernel.org>, <lkp@lists.01.org>, <lkp@intel.com>,
        <ying.huang@intel.com>, <feng.tang@intel.com>,
        <zhengjun.xing@linux.intel.com>, <fengwei.yin@intel.com>
Subject: Re: [xfs]  345a4666a7:  vm-scalability.throughput -91.7% regression
Message-ID: <YtoG+kcaC8yfMEZW@xsang-OptiPlex-9020>
References: <Ytlr9vZbF4SOfA2n@xsang-OptiPlex-9020>
 <20220721213337.GV3861211@dread.disaster.area>
 <YtnHa/IbHyD1QPh0@magnolia>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YtnHa/IbHyD1QPh0@magnolia>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BipvU6ctcRvFTD6g9bt4gBXckeK54vngMbO+W7/eeCypYxKKV2DlxbNlaZYT?=
 =?us-ascii?Q?pVLwPQEQKlIoD32oCmmlcms/QpH7UZsVu0HOXgPXaNboHLm+sTPFuxiCBaaD?=
 =?us-ascii?Q?Zw8b9GP9prrAeuSbUD0JLUGcavKMzd3IzO4n6TRqDiIOmFNsA0lc6UXF0YIS?=
 =?us-ascii?Q?GuRWYDCGTzbIZlT5t3XpjsFtKKuJKYS1Vp4yPTzAedegGdd9b056DrpcLuqR?=
 =?us-ascii?Q?7yvn2AEZlW4oRrpbn4wCStLFFx/abOpzehpjvabDlb01flBNdRuk/6PV1dP9?=
 =?us-ascii?Q?JDR+ZeAAMQfvabq0EG5qmQDPP7gwbmy+q7Za2CO+1Fgu0WZGedxEdBgYMOKt?=
 =?us-ascii?Q?/CbhzY+tEwCGMICK1P6SLxGS6T/A8DS4gbGGb1DavIgqOhJLOKgltgEKW7/b?=
 =?us-ascii?Q?FUke+y4cCJjPELFlkdnaJB3waBrQ1x1k0+3qfhA0QzsmCi3ifJ1m+H6zl/uS?=
 =?us-ascii?Q?Ho+A9eUc7tFyrqTIbQfj/TDJkaCPXrlnbqZrVD1ydXLvCQ3UMR6ZsTsWwvdC?=
 =?us-ascii?Q?//6v7FAoJy5CH4yTnHqdPy6ZagCxnLbVLz/axJ45Gg4esvfZRANRXAykWP+k?=
 =?us-ascii?Q?5HsKtDhvGDVzctM+ZzPYhIjSBCo+l0OFFkY0AhFckNzKVOjcpCk34q7auFDn?=
 =?us-ascii?Q?+hr7EvUDEc+4flanAui+CjbhZ8mBgMueOdfo7XWy4Bj/7a8PotmtloY0p3ro?=
 =?us-ascii?Q?VBEdJgFZyLCO/geETLoR5XzFc3K9e+ow+mAR/r0EyaSo11nhhq/Tty5lQS/a?=
 =?us-ascii?Q?1kvCkljkYwN7Vgeg44VaqVerKR5FlLDee417jbGo2J31eq0nN4/UwHHlNXHV?=
 =?us-ascii?Q?TC7Llsao1fg20ZsJ+iKVUNHCn1pW0fh+JtDnxBMr9I/eCiPR0sj6ILS7H2lG?=
 =?us-ascii?Q?My/6CZPDTkMfkrPg2VlKIM4oJHn3GEFXxT+VE7aBT14pOaaYiO6I2W8YTbKj?=
 =?us-ascii?Q?sUFGR4TE77I+PJrzdZyNAUp2z2SABJFQWS5xJZK5aSdHXAS4bUnZYRwqINaV?=
 =?us-ascii?Q?qNqmaIyng4k8AornDc6FrefjHWislMdG/ZDDyZWRjmAfdK2+QLj5gWDgppdL?=
 =?us-ascii?Q?+p0wMY1ZSTMOID6LP0PCTddz7bDXIQHkEIlmzmRCG3LhsKumWPnHxxTjFFAd?=
 =?us-ascii?Q?v3SN6OovGxxPMkYdKbyBkOYydqntuu2ejK0kohSnUSFhxKZ0ALXytZKZI+iF?=
 =?us-ascii?Q?TlCDHarzQgG2/p+UvsVz+HqR+08Ho6KVuRuX44LTelLaxPFdtztwfhl8Hmt0?=
 =?us-ascii?Q?AoojVLEnZ8MSk09M+8fiv8kN8wR5PYlGxglsvBO2GhZZcVK+j35Wr42AQNjB?=
 =?us-ascii?Q?/Kdl+sclTfoFVSWxk9NLeXevbP8FldQYjh3mtKHHm9eLgrnouwydjKTISMb8?=
 =?us-ascii?Q?rvcMGgUfe/0IE0CgfpGv4h6TeZUC7t4ieTkZD1dGhtlxKXqdTI+i2LyIFwPy?=
 =?us-ascii?Q?hVth4eu6pc5vhLs4zMRFC8cZ6KScJYBFkxlrJ6nSWfjyCSwYi0PI0ttGCXeL?=
 =?us-ascii?Q?BuXO+dyiabi9+DYUFKYppz4u2UoT9iNVlKgGLCt5of7DdPFdW72Cx5qH+Let?=
 =?us-ascii?Q?Gt/NmTAAVxvJ4PDJ4QFKy88hAKBdzIj3x2l33e5qjiMMuOXvqqhe2S/LSyqR?=
 =?us-ascii?Q?qg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6676fee5-d306-4c09-75d3-08da6b874ec3
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6297.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 02:10:11.4733
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vSCqHG4Wo+VdyWNyyzEHPYHpY6OuNk9/YYNteHFBojP8wL+OX5qYZwCVwzwVVYk0y9Xf9wmIBjMyVl/BWJhRUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1776
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Darrick, Hi Dave, and all,

sorry for this report is annoying according to Darrick and Dave's comments
below.
we will investigate this case and refine our report process.


On Thu, Jul 21, 2022 at 02:38:51PM -0700, Darrick J. Wong wrote:
> On Fri, Jul 22, 2022 at 07:33:37AM +1000, Dave Chinner wrote:
> > On Thu, Jul 21, 2022 at 11:08:38PM +0800, kernel test robot wrote:
> > > 
> > > (just FYI for the possible performance impact of disabling large folios,
> > > our config, as attached, set default N to XFS_LARGE_FOLIOS)
> > > 
> > > 
> > > Greeting,
> > > 
> > > FYI, we noticed a -91.7% regression of vm-scalability.throughput due to commit:
> > > 
> > > 
> > > commit: 345a4666a721a81c343186768cdd95817767195f ("xfs: disable large folios except for developers")
> > 
> > Say what? I've never seen that change go past on a public list...
> > 
> > > https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git xfs-5.20-merge
> > 
> > Oh, it's in a developer's working tree, not something that has been
> > proposed for review let alone been merged.
> 
> Correct, djwong-dev has a patch so that I can disable multipage folios
> so that I could get other QA work done while willy and I try to sort out
> the generic/522 corruption problems.
> 
> > So why is this report being sent to lkml, linux-xfs, etc as if it
> > was a change merged into an upstream tree rather than just the
> > developer who owns the tree the commit is in?
> 
> I was wondering that myself.
> 
> --D
> 
> > -Dave.
> > -- 
> > Dave Chinner
> > david@fromorbit.com