Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: idfb84289:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-755-g3e1da8b93f-fm-20220708.002-g3e1da8b9
Mime-Version: 1.0
Message-Id: <0503175d-944d-4ffa-ba39-ff99797e78a1@www.fastmail.com>
In-Reply-To: <20220603123904.30714-1-linmq006@gmail.com>
References: <20220603123904.30714-1-linmq006@gmail.com>
Date:   Fri, 22 Jul 2022 11:44:31 +0930
From:   "Andrew Jeffery" <andrew@aj.id.au>
To:     "Miaoqian Lin" <linmq006@gmail.com>,
        "Joel Stanley" <joel@jms.id.au>,
        "Chia-Wei, Wang" <chiawei_wang@aspeedtech.com>,
        "Patrick Venture" <venture@google.com>,
        "Robert Lippert" <roblip@gmail.com>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] soc: aspeed: Fix IRQ check in aspeed_lpc_snoop_config_irq
Content-Type: text/plain
Precedence: bulk


On Fri, 3 Jun 2022, at 22:09, Miaoqian Lin wrote:
> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
>
>     int irq = platform_get_irq(pdev, 0);
>     if (irq < 0)
>         return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>