Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220721134924.596152-1-shorne@gmail.com> <20220721134924.596152-4-shorne@gmail.com>
In-Reply-To: <20220721134924.596152-4-shorne@gmail.com>
From:   Guo Ren <guoren@kernel.org>
Date:   Fri, 22 Jul 2022 11:27:04 +0800
Message-ID: <CAJF2gTT1iWj-xoZYAYwawQkjTZkJfVL+tGb68gu0iB_ZP2XTAA@mail.gmail.com>
Subject: Re: [PATCH v5 3/4] csky: PCI: Define ARCH_GENERIC_PCI_MMAP_RESOURCE
To:     Stafford Horne <shorne@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Pierre Morel <pmorel@linux.ibm.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        linux-csky@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Acked-by: Guo Ren <guoren@kernel.org>

On Thu, Jul 21, 2022 at 9:50 PM Stafford Horne <shorne@gmail.com> wrote:
>
> This looks to be something that was left out on accident on the csky
> port.  Add the definition of ARCH_GENERIC_PCI_MMAP_RESOURCE to keep it
> inline with other ports.  Adding ARCH_GENERIC_PCI_MMAP_RESOURCE enables
> the definition of mordern pci_mmap_resource_range functions which is
> generally what new ports should be using.
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> Since v4:
>  - New patch.
>
>  arch/csky/include/asm/pci.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/csky/include/asm/pci.h b/arch/csky/include/asm/pci.h
> index 5c02454ec724..875bc028f8f6 100644
> --- a/arch/csky/include/asm/pci.h
> +++ b/arch/csky/include/asm/pci.h
> @@ -15,6 +15,8 @@
>  /* C-SKY shim does not initialize PCI bus */
>  #define pcibios_assign_all_busses() 1
>
> +#define ARCH_GENERIC_PCI_MMAP_RESOURCE 1
> +
>  #ifdef CONFIG_PCI
>  static inline int pci_proc_domain(struct pci_bus *bus)
>  {
> --
> 2.36.1
>


-- 
Best Regards
 Guo Ren