Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 22 Jul 2022 09:32:08 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
Cc:     Corentin Labbe <clabbe@baylibre.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: staging: media: zoran: Fixed Block comments
Message-ID: <20220722063208.GN2338@kadam>
References: <20220721173729.63844-1-abhijeet.srivastava2308@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220721173729.63844-1-abhijeet.srivastava2308@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M0XDarvqPez/LiWBqGGD6DxA0ARINiqCqhzmLslyynerRkXOAnPyklnwGPZ0?=
 =?us-ascii?Q?4CumX7hdcGmtjTX6c/jlWNGt0VV9tqkTh2xCMjKpOmsvI+eXOIfWCnQpmJkS?=
 =?us-ascii?Q?PvZfV0yX0DWdK78j2OCnq0cGJ9sPbpfPgUnIReC0b9xcJZ3sJSItZ6UvMn4H?=
 =?us-ascii?Q?mINjKxsE36tH85LZkY3Six6rUskYQErxDWuryaEkZaOpEVDMyjjenfOOwzAk?=
 =?us-ascii?Q?XtaGgnJjk9aTj8BFHpiPRiawXr0Ve5bYwLySkb2eCnIMgoObSDQ7SY48eQpA?=
 =?us-ascii?Q?jOJEmWikK4xShZE311Gx+td/K0wpN1GRZJEhEiGVEQLO2HC30d3kyHdexFP6?=
 =?us-ascii?Q?oeDGAwlwkxV1TKTZPoJEKNMfL8yeUrdu3nv9qKfdiYjmbEguq8T6Qjc4ZNbI?=
 =?us-ascii?Q?+Y83S6sgvaFAh8Hzj8E/Fm3cUibhLT+Q+R28Pomu0HqFAkEg+ca4KWPcBbKN?=
 =?us-ascii?Q?il6jH6km/KSFnbamYSRTzg0NjqfpIgN2i6Z14SzfTpGSxLC1m/kg18CXJXCa?=
 =?us-ascii?Q?N5X2Dj+WOTbV+t4oQH5xSnySgn860buZSDR4sUeCe/FsTTvykVbiFkLH12+i?=
 =?us-ascii?Q?Fr4MAASEVUSmnkW8CZQlzzpRLdbCLwilcM+tOEiPIZLtLq2+/CIKG0qCua+r?=
 =?us-ascii?Q?PeuVVMfcHdqpsYYcyTGFJmG/BU2Ps3bCPeFkDkCorwOdFevtbHneVd88jLz4?=
 =?us-ascii?Q?ZDC5J6Z7SVEjuusH55udQPIgn5f1HzhzoscMPoXt0sheEdXDapgW+4kmFo+j?=
 =?us-ascii?Q?YnM/vKQpLEPP4Wv0O/skE38sE3r7nPBQPAADOEGm7AiZRayDpxObEeinzIHx?=
 =?us-ascii?Q?kQ1fWAILHnmH1hLrkpopO9TulvPy6RaCzt5b7nGX5e6KM7Pz628wzpVWU6R8?=
 =?us-ascii?Q?uo3qcCt5RzT7PJ2QeeEepdLL0MN6nKX8j4TmliluG8dywNxr5KoNP57JzL/0?=
 =?us-ascii?Q?SWilHbUcKoUAZa+8r5u8EaU7m54mIEz8jMhPsMkkAdGhi/PqcdZsyHS7GAQF?=
 =?us-ascii?Q?dPROy6Ie6cNAbIQzFb32RQBHXVAcH3lCekKgFe+cTHXfVzRZICpu01fcQA7u?=
 =?us-ascii?Q?wVFo0+4gzHPfu5MNXRhaUYBYimHsjqLDrzx9cPoBoKkVfK5IMYCa74YtisCG?=
 =?us-ascii?Q?NmR95TJrYM5HxXq4xn4a+wqDBEV4NuitldUQhmiYFA6dpXgaPkBmzRd6950V?=
 =?us-ascii?Q?x7zLSFVvgCOMUR8YGIG8FhlJeUDufjudB4Yo/awNMC72Y+p/zFk+MSl5Ripz?=
 =?us-ascii?Q?zUjHr+Ny5M3FgdVf+IUgg8Ui9rVncAn0DOa2Faz3nYZrr5ZAk0YktzCOlXmJ?=
 =?us-ascii?Q?87xizxcMrGesf/ZyLdTnvCmF2H8OAAqPsBxlbEoBiOUELQSUHIV2+FgTxCKo?=
 =?us-ascii?Q?8SqbS4fCB44QACRfMvSD/K9GgI6AEX79vYv4B2KReUVT81TKEH24Ve4O0kIl?=
 =?us-ascii?Q?1m5ddpv9jx/wlBInuZ7K8pIz1+OTukhtlhUVVfIXwFivIaexITiakXGWlGkA?=
 =?us-ascii?Q?lWqacfzEbdLj0/7SdgMscv/O7+qkZM7K6jQ+fz0eAtec3WZx0KCBbDymGkD1?=
 =?us-ascii?Q?Pkkkf8PHgUqL7gWnZDD7/R6YQeviZB9IVo0i1vT72J0vwzx9FHT8GwD9w2W1?=
 =?us-ascii?Q?5w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66abe3af-506e-4744-ec29-08da6babf24d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 06:32:27.8400
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hnHh+OfPQd18jymt5XQHxBnm1in8Uf4RHCex8pZUv7b+ClcufnhoZKUhXRqhXE8qPoDyu1ZRyXK7x21L9IDLyXARS4Tg5/FlaoCy72d94XE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5744
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-21_28,2022-07-21_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 phishscore=0
 mlxlogscore=999 spamscore=0 malwarescore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207220026
X-Proofpoint-GUID: jiv_jnxbt3C2z4Fb_uXYT8ZBqYE5u1Fe
X-Proofpoint-ORIG-GUID: jiv_jnxbt3C2z4Fb_uXYT8ZBqYE5u1Fe
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 21, 2022 at 11:07:22PM +0530, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
> 
> Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
> ---
>  drivers/staging/media/zoran/zoran_driver.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> index 4304b7e21709..b408c1d4e0a7 100644
> --- a/drivers/staging/media/zoran/zoran_driver.c
> +++ b/drivers/staging/media/zoran/zoran_driver.c
> @@ -746,9 +746,11 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
>  	.vidioc_enum_input		    = zoran_enum_input,
>  	.vidioc_g_input			    = zoran_g_input,
>  	.vidioc_s_input			    = zoran_s_input,
> +
>  /*	.vidioc_enum_output		    = zoran_enum_output,
> -	.vidioc_g_output		    = zoran_g_output,
> -	.vidioc_s_output		    = zoran_s_output,*/
> + *	.vidioc_g_output		    = zoran_g_output,
> + *	.vidioc_s_output		    = zoran_s_output,
> + */

Always, just delete dead code.

regards,
dan carpenter