Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 22 Jul 2022 09:14:31 +0200
From:   Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To:     williamsukatube@163.com
Cc:     wim@linux-watchdog.org, linux@roeck-us.net,
        linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
        William Dean <williamsukatube@gmail.com>,
        Hacash Robot <hacashRobot@santino.com>
Subject: Re: [PATCH] watchdog: armada_37xx_wdt: check the return value of
 devm_ioremap() in armada_37xx_wdt_probe()
Message-ID: <20220722091431.1572e92c@dellmb>
In-Reply-To: <20220722030938.2925156-1-williamsukatube@163.com>
References: <20220722030938.2925156-1-williamsukatube@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 22 Jul 2022 11:09:38 +0800
williamsukatube@163.com wrote:

> From: William Dean <williamsukatube@gmail.com>
>=20
> The function devm_ioremap() in armada_37xx_wdt_probe() can fail, so
> its return value should be checked.
>=20
> Fixes: 54e3d9b518c8a ("watchdog: Add support for Armada 37xx CPU watchdog=
")
> Reported-by: Hacash Robot <hacashRobot@santino.com>
> Signed-off-by: William Dean <williamsukatube@gmail.com>
> ---
>  drivers/watchdog/armada_37xx_wdt.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/watchdog/armada_37xx_wdt.c b/drivers/watchdog/armada=
_37xx_wdt.c
> index 1635f421ef2c..854b1cc723cb 100644
> --- a/drivers/watchdog/armada_37xx_wdt.c
> +++ b/drivers/watchdog/armada_37xx_wdt.c
> @@ -274,6 +274,8 @@ static int armada_37xx_wdt_probe(struct platform_devi=
ce *pdev)
>  	if (!res)
>  		return -ENODEV;
>  	dev->reg =3D devm_ioremap(&pdev->dev, res->start, resource_size(res));
> +	if (!dev->reg)
> +		return -ENOMEM;
> =20
>  	/* init clock */
>  	dev->clk =3D devm_clk_get(&pdev->dev, NULL);

Reviewed-by: Marek Beh=C3=BAn <kabel@kernel.org>