Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Xin Ji <xji@analogixsemi.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Xin Ji <xji@analogixsemi.com>
Cc:     bliang@analogixsemi.com, qwen@analogixsemi.com,
        jli@analogixsemi.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] usb: typec: anx7411: fix passing zero to 'PTR_ERR'
Date:   Fri, 22 Jul 2022 16:18:34 +0800
Message-Id: <20220722081836.3380885-1-xji@analogixsemi.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U8x8+7gDKBUVQPhvRRnIh+/G0nQJXfWjCiMXZsa0mglyFpjrZbGAGukAVPM9?=
 =?us-ascii?Q?EG4Mvqkbc4A6azIkzbGhVgLLe70AU5Qmj63iVwrm+QO9LYzfKpJVR9lMRUOe?=
 =?us-ascii?Q?sRNIBa8EU8XSUGhpXMk9uSVGlfYucru9EIZk9hUa9ZXAuqRaIFcZUXsCWq3g?=
 =?us-ascii?Q?od6eMy2oV4mQJW/gSdfhdrGZZrqPu/g5QbXlk++06P2ijgdIf4yfDsNhrGpu?=
 =?us-ascii?Q?UBrwlQ6FJ2amC+hc7V8Hlm324FMQr2+r+BH3DquiJ8MAfTY2XC2T39HjKnfz?=
 =?us-ascii?Q?WSnXT5hL/FCPPXIsw8BX1fclM/n4ML1KzHcRq8iArdXcQuXhpMNgEn0MRuSR?=
 =?us-ascii?Q?OSBWShPKoVCqnfNRZsdjzEEHu5c2CygDQT0M5VMH6JzsdX+zQ7Dwne+R6rUH?=
 =?us-ascii?Q?NTnXKqGr8Qqtbz6XVHr1ZKw555ZS1xgqK+QbmgqihGhcHJO+W0wJYkbt9j7k?=
 =?us-ascii?Q?4fCSU6QDnzGPF5S8ovuBUM+Xk/KK5rPrfhS67qYu1r66GPNJIHj5PFYemmcs?=
 =?us-ascii?Q?kA1SLEEAvhzYAN0Cwm6oQo1nX012qVSRYw57cth84UAOyZS9/dLG94uq+76K?=
 =?us-ascii?Q?gUP/U5z/zl3zkotV+9+fnKUzKvk3OiAnhdzUW8FI49Gd4pznsFSS4pMrxOIv?=
 =?us-ascii?Q?1Gh0flof/z9Mp3RuAJPpSjsWZiE3hue4KG5busG+jbn3MyewhlFAozCLJ5Ud?=
 =?us-ascii?Q?2Hov7yiuHFB/2Uzdz5sng3y2/QxzyCWYsCxwgSQSHcNYjOdigD+sEWynbkBd?=
 =?us-ascii?Q?25PTRa85kSRXM5HU+jl1CZDRzaJu1qBmIL3ewZd5CiGBq6EQh+7o0b8SLDkS?=
 =?us-ascii?Q?mIlnCQuBlsDjcxEqb6F14jMAEj6rE0p5tIj7I7NdaajzcvpEZnmNPxGZkRtk?=
 =?us-ascii?Q?AbQs/508HWZllPF3zEKnTgNMzSh1OaavuobVkKrXEX3UofjKMSjqXMVmhQoi?=
 =?us-ascii?Q?ycuQL3ZIR0NDyi7y87gcYvEmIHUV+QimqcG2OZ5Ey2CYkav0ehvPgqbrBRLH?=
 =?us-ascii?Q?lV371uiMnuXZtvb2u5jtIHxKcKqgk5bAPNTNp4P1b5y02zMxUta/cWFEcjxg?=
 =?us-ascii?Q?+6B0Uyz6I7VmcQydVWi5JvJFUyJtMjc1uZ/GEKbhOysjkHBm7TbROgV/AgPC?=
 =?us-ascii?Q?le0nWE49PUYkLDjlstkjt2JBRIjIKgDymqIqoZfVWZe7jREJtawBLRwZj0kz?=
 =?us-ascii?Q?zO8nsrKYgwWXzvN4mLqHXJi25u39QkLY9970PCNfrsaGlxZQIAej6J5V7Wr6?=
 =?us-ascii?Q?GnjasoAjLWfm3GXrpofcSps6VT219h0uM5FP5GPTvEb+C6ERTUSdvhn02jeT?=
 =?us-ascii?Q?dzmCnn6DOZVRhmevX47eJ73ytQ8bHVSXIb7BzvatjL6+7fg7//EWMwzWKY6j?=
 =?us-ascii?Q?rL/CBjEWczKopA3LdaCQRFN88u7y6U/9TF6+j+xqIqJIF9598MXQpS0fzRYI?=
 =?us-ascii?Q?craePx+qi/W/38hOjp0ubHtydme66JZHPGEq82YTzHZ4DCXZIc3O33SUM2Q2?=
 =?us-ascii?Q?5HC9NxN9Y5DS6StfWUoAOM0bydhA2/YSoVW5yP5Qm7rGBbuK/4o6RbstR607?=
 =?us-ascii?Q?FSXLLFnh/u3ILvBs9vLoa94mlSpq/GcQ+MFP4W94?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51444700-8089-4749-1bf5-08da6bbacda1
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 08:18:48.6198
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: go6vw5LucQ2GynlV8c4MQkMsPyf2+437A60aJ5JPa7egkz8QcM7MZzQ0N749uvz3+P8AaH0E7XA3FAUMgVWFXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR04MB5986
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix anx7411_register_partner() warn: passing zero to 'PTR_ERR'

Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support")
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
 drivers/usb/typec/anx7411.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c
index b990376991f8..7b45d7440a9d 100644
--- a/drivers/usb/typec/anx7411.c
+++ b/drivers/usb/typec/anx7411.c
@@ -374,6 +374,7 @@ static int anx7411_register_partner(struct anx7411_data *ctx,
 				    int pd, int accessory)
 {
 	struct typec_partner_desc desc;
+	struct typec_partner *partner;
 
 	if (ctx->typec.partner)
 		return 0;
@@ -381,11 +382,11 @@ static int anx7411_register_partner(struct anx7411_data *ctx,
 	desc.usb_pd = pd;
 	desc.accessory = accessory;
 	desc.identity = NULL;
-	ctx->typec.partner = typec_register_partner(ctx->typec.port, &desc);
-	if (IS_ERR(ctx->typec.partner)) {
-		ctx->typec.partner = NULL;
-		return PTR_ERR(ctx->typec.partner);
-	}
+	partner = typec_register_partner(ctx->typec.port, &desc);
+	if (IS_ERR(partner))
+		return PTR_ERR(partner);
+
+	ctx->typec.partner = partner;
 
 	return 0;
 }
-- 
2.25.1