Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 22 Jul 2022 09:01:15 +0100
From:   Ben Dooks <ben@fluff.org>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Ben Dooks <ben-linux@fluff.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kallsyms: make arch_get_kallsym() static
Message-ID: <20220722080115.pzryb7dy2ijbp6p7@hetzy.fluff.org>
References: <20220721151040.359389-1-ben-linux@fluff.org>
 <YtlvP1toPTmv4brF@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YtlvP1toPTmv4brF@infradead.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Precedence: bulk

On Thu, Jul 21, 2022 at 08:22:39AM -0700, Christoph Hellwig wrote:
> On Thu, Jul 21, 2022 at 04:10:40PM +0100, Ben Dooks wrote:
> > The arch_get_kallsym() function is not used anywhere in the kernel
> > now, so it should at-least be static or just be removed as there
> > are no users. Making it static fixes the following sparse warning:
> > 
> > kernel/kallsyms.c:590:12: warning: symbol 'arch_get_kallsym' was not declared. Should it be static?
> 
> It fixes the warning, but isn't exactly useful.  Please just remove it,
> get_ksymbol_arch and iter->pos_arch_end entirely instead.

Ok, probably the best. I didn't have time to do any archeaology on it
to find out if it has ever been used.

-- 
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.