Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Xin Ji <xji@analogixsemi.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Xin Ji <xji@analogixsemi.com>
Cc:     bliang@analogixsemi.com, qwen@analogixsemi.com,
        jli@analogixsemi.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] usb: typec: anx7411: fix passing a valid pointer to 'PTR_ERR'
Date:   Fri, 22 Jul 2022 16:18:35 +0800
Message-Id: <20220722081836.3380885-2-xji@analogixsemi.com>
In-Reply-To: <20220722081836.3380885-1-xji@analogixsemi.com>
References: <20220722081836.3380885-1-xji@analogixsemi.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fS4SsYNRFzmx6wDrmqWDPkPNdzrXIwLXpmNOXCFdlGNujMR3/1tYWjoLyp8a?=
 =?us-ascii?Q?/ZUVMXDJKhoFrTp4Jer2koqt1oFglolskLoN5C4EaCma1eA7lnipdzKTtIny?=
 =?us-ascii?Q?2dIi0w3FPLB/FF0h9j6iWDiM1MyEekB9zF68pp7mWUCHJWNC11cs7G1ua4i7?=
 =?us-ascii?Q?DOoZk5V6/97WeBivv+LMIfcsIKCEUqxf//Ep7Afa7qh5ZjzShio6RijEaQrM?=
 =?us-ascii?Q?8CWeune8LpGrhwA76W9Qb1aUjqRkR4fwWp1itKKRvCXEmhtf3CUAXI/Fy9B1?=
 =?us-ascii?Q?t8Lg+YTlr6t2Y7w4Q3Jjp1i2eOrbuhx5rH+OtUQzq2XLIUDZ8P0rv1dN8HL5?=
 =?us-ascii?Q?LpQCYaDebwKfhxuec3ce6NanV+sWCSEElwE3zgoFJumaTejtp8xxdTC0SNmi?=
 =?us-ascii?Q?Sjap9/DdbFGxcE8cob4WYsvvEABw81KSVc++ehJ0DmorreD7YAz3/leoy+Xw?=
 =?us-ascii?Q?U4kdxPhrzJtB36GBDYjaBextvg6YNFf7qiM/nQnaHaEYhQSfm02R7Gn3IAbW?=
 =?us-ascii?Q?c7QuFfS/UXKhpA3dYpiSZMtDoBN7pGw3Ek+FE3poaAqbnLGj9I8O6Mb1nkYm?=
 =?us-ascii?Q?QuUX523TSP0hM/PAn8lewmMljngTy3sOv8k9wZa4pCmY4Sech7M3+jcUa+kL?=
 =?us-ascii?Q?8Re5UAt5lvGVfEP5x9ME/GrdvUtB9hiziP4KpEBoB1E0o8aoj4MA2BuCViTq?=
 =?us-ascii?Q?HCjnjEqhOGYhiEOEYRqJ6ZGgbLml4dGDpJc0VRtM3jTqLEEUxeBv1Ya/pbnx?=
 =?us-ascii?Q?HGH+2tTtTXfDkrD7x+94Rj+9jpFV2iwE4JRCvV/8qS5RLv4llUyxmS3DWOcv?=
 =?us-ascii?Q?bqZbz++Abdw9aHRs7dWD9LeQn6XqRSwz+Z2JAD80vB8ugKkPFHS6+W/OG7YN?=
 =?us-ascii?Q?WCpQMWulxmCy3nEZNmLYhE0s2FjqkqwjgIuiOWaX5yohi4EhZvOKjQ/SRZDH?=
 =?us-ascii?Q?Dp9pMpAe+XdLcjBmIsWKlvzR4OFnABMo5CNenlZwX7HGNRcsx0CauC2qVKBq?=
 =?us-ascii?Q?Ho4n1Cjxk297bmAwY8a9Y4p0xSCagpXBQh96e995s+8aEqrQuwfBnLHrvyYY?=
 =?us-ascii?Q?6B7fDKMbBovSQUhxPsJGvb8r5bzWpXOUmP3d/+hcBe7p+gTIpbZSkyCfDodU?=
 =?us-ascii?Q?6DPztBGIsRYEKg9Prnzw5vTV1uUQapudBmNhlJ+BjGLccSjc7IljXDKVXb1T?=
 =?us-ascii?Q?MyvSPRTwXBkIe5x8ZfIIEa9ldEVvZzIvSilEQzkhx9i+QMpTo9ZULW/H+9ps?=
 =?us-ascii?Q?GCkiZYAgMs2LLqOsRI/sUlcZvjRDPF9Gnw7jNCEAk3dVHsA54vamKcdoJbyF?=
 =?us-ascii?Q?9th1QTGBeOlopDkmlFF87qIeP4cMtKIwDbxnF/k0XHWWHb/mWx78Elf/Q2w3?=
 =?us-ascii?Q?sW/2seu36JhR7qhvvLaFEnPOT0Gyj1S0vzSbK4ycH1s/YGB2UKEk2Ev7JvWy?=
 =?us-ascii?Q?yg0IiNEaZ3bZHBe73EkxzovGRD9ErBvGHvrPtDmomWJVJFLsFJokjrrfxxp8?=
 =?us-ascii?Q?09kaaRPJiFXkzh9m3I7cB47qniivYMd9zuMCyVlxrEEvFO+bgJohGXAzDXkg?=
 =?us-ascii?Q?4aj3uyLw+vHVccDJMboTt8l2CwS2pIGrg7zUwFgR?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3445ade-6bb9-4473-dd9f-08da6bbad78a
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 08:19:05.4219
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t06QwyIyPH2KyKBUPh7Zc0/lnKFGwJyGRbtApYI8TUl33vhLRdxwtvUHGJ6f7YWiLJ2hAeIYJmQkxlHDbTOHcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR04MB5986
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix anx7411_typec_register_altmode() warn: passing a valid pointer to
'PTR_ERR'.

Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support")
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
 drivers/usb/typec/anx7411.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c
index 7b45d7440a9d..dc86b6704cbd 100644
--- a/drivers/usb/typec/anx7411.c
+++ b/drivers/usb/typec/anx7411.c
@@ -550,6 +550,7 @@ static int anx7411_typec_register_altmode(struct anx7411_data *ctx,
 {
 	struct device *dev = &ctx->spi_client->dev;
 	struct typec_altmode_desc desc;
+	struct typec_altmode *alt;
 	int i;
 
 	desc.svid = svid;
@@ -566,14 +567,14 @@ static int anx7411_typec_register_altmode(struct anx7411_data *ctx,
 		return -ENOMEM;
 	}
 
-	ctx->typec.amode[i] = typec_partner_register_altmode(ctx->typec.partner,
-							     &desc);
-	if (IS_ERR(ctx->typec.amode[i])) {
+	alt = typec_partner_register_altmode(ctx->typec.partner, &desc);
+	if (IS_ERR(alt)) {
 		dev_err(dev, "failed to register altmode\n");
-		ctx->typec.amode[i] = NULL;
-		return PTR_ERR(ctx->typec.amode);
+		return PTR_ERR(alt);
 	}
 
+	ctx->typec.amode[i] = alt;
+
 	return 0;
 }
 
-- 
2.25.1