Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6f18325e-cb40-b1f7-4236-3aa22e05694b@huawei.com>
Date:   Fri, 22 Jul 2022 09:41:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 2/2] scripts/faddr2line: Add CONFIG_DEBUG_INFO check
To:     Josh Poimboeuf <jpoimboe@kernel.org>, <x86@kernel.org>
CC:     <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
References: <cover.1658426357.git.jpoimboe@kernel.org>
 <ffa7734c929445caa374bf9e68078300174f09b4.1658426357.git.jpoimboe@kernel.org>
From:   John Garry <john.garry@huawei.com>
In-Reply-To: <ffa7734c929445caa374bf9e68078300174f09b4.1658426357.git.jpoimboe@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/07/2022 19:01, Josh Poimboeuf wrote:
> Otherwise without DWARF it spits out gibberish and gives no indication
> of what the problem is.
> 
> Suggested-by: John Garry <john.garry@huawei.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>

Seems to work fine, thanks

Tested-by: John Garry <john.garry@huawei.com>

> ---
>   scripts/faddr2line | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/faddr2line b/scripts/faddr2line
> index 57099687e5e1..5514c23f45c2 100755
> --- a/scripts/faddr2line
> +++ b/scripts/faddr2line
> @@ -61,6 +61,7 @@ die() {
>   READELF="${CROSS_COMPILE:-}readelf"
>   ADDR2LINE="${CROSS_COMPILE:-}addr2line"
>   AWK="awk"
> +GREP="grep"
>   
>   command -v ${AWK} >/dev/null 2>&1 || die "${AWK} isn't installed"
>   command -v ${READELF} >/dev/null 2>&1 || die "${READELF} isn't installed"
> @@ -271,6 +272,8 @@ LIST=0
>   [[ ! -f $objfile ]] && die "can't find objfile $objfile"
>   shift
>   
> +${READELF} --section-headers --wide $objfile | ${GREP} -q '\.debug_info' || die "CONFIG_DEBUG_INFO not enabled"
> +
>   DIR_PREFIX=supercalifragilisticexpialidocious
>   find_dir_prefix $objfile
>