Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757878AbXFDQCV (ORCPT ); Mon, 4 Jun 2007 12:02:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756013AbXFDQCK (ORCPT ); Mon, 4 Jun 2007 12:02:10 -0400 Received: from agminet01.oracle.com ([141.146.126.228]:45513 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755017AbXFDQCJ (ORCPT ); Mon, 4 Jun 2007 12:02:09 -0400 Date: Mon, 4 Jun 2007 09:01:19 -0700 From: Randy Dunlap To: Jesse Huang Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, akpm@osdl.org, jgarzik@pobox.com, jeff@garzik.org Subject: Re: [PATCH] sundance: PHY address form 0, only for device ID 0x0200 (IP100A) Message-Id: <20070604090119.488a2588.randy.dunlap@oracle.com> In-Reply-To: <1180991079.15274.1.camel@localhost.localdomain> References: <1180991079.15274.1.camel@localhost.localdomain> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.3.1 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 47 On Mon, 04 Jun 2007 17:04:39 -0400 Jesse Huang wrote: > From: Jesse Huang > > Change Logs: > Search PHY address form 0, only for device ID 0x0200 (IP100A). Other device are from PHY address 1. > > Signed-off-by: Jesse Huang > --- > > drivers/net/sundance.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > 5724a72722dfc9cafbb8f273cb82dbf577bd9ad0 > diff --git a/drivers/net/sundance.c b/drivers/net/sundance.c > index e1f912d..914ab29 100644 > --- a/drivers/net/sundance.c > +++ b/drivers/net/sundance.c > @@ -562,7 +562,9 @@ #endif > * It seems some phys doesn't deal well with address 0 being accessed > * first, so leave address zero to the end of the loop (32 & 31). > */ > - for (phy = 1; phy <= 32 && phy_idx < MII_CNT; phy++) { > + if(sundance_pci_tbl[np->chip_id].device == 0x0200) phy = 0; kernel style: if (sundance_pci_tbl[np->chip_id].device == 0x0200) phy = 0; else phy = 1; > + else phy = 1; > + for (; phy <= 32 && phy_idx < MII_CNT; phy++) { > int phyx = phy & 0x1f; > int mii_status = mdio_read(dev, phyx, MII_BMSR); > if (mii_status != 0xffff && mii_status != 0x0000) { > -- --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/