Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d73801f6-8476-074e-6af1-1b8cab95b817@arm.com>
Date:   Fri, 22 Jul 2022 11:29:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH] arm64: dts: arm: juno: Remove legacy Coresight
 'slave-mode' property
To:     Rob Herring <robh@kernel.org>, Liviu Dudau <liviu.dudau@arm.com>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220721212952.1984382-1-robh@kernel.org>
From:   Suzuki K Poulose <suzuki.poulose@arm.com>
In-Reply-To: <20220721212952.1984382-1-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/07/2022 22:29, Rob Herring wrote:
> The 'slave-mode' property is not valid under 'in-ports' as it was the
> legacy way to find input ports. Warnings are generated from the Coresight
> schema:
> 
> arch/arm64/boot/dts/arm/juno-r1.dtb: funnel@20150000: in-ports:port@0:endpoint: Unevaluated properties are not allowed ('slave-mode' was unexpected)
>          From schema: Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> index 2e43f4531308..fbcdf63ad56d 100644
> --- a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> @@ -67,7 +67,6 @@ in-ports {
>   			port@0 {
>   				reg = <0>;
>   				csys2_funnel_in_port0: endpoint {
> -					slave-mode;
>   					remote-endpoint = <&etf0_out_port>;
>   				};
>   			};
> @@ -75,7 +74,6 @@ csys2_funnel_in_port0: endpoint {
>   			port@1 {
>   				reg = <1>;
>   				csys2_funnel_in_port1: endpoint {
> -					slave-mode;
>   					remote-endpoint = <&etf1_out_port>;
>   				};
>   			};


Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>