Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp559918imi; Fri, 22 Jul 2022 05:01:50 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sJYWyDbRZm6O2LhAiN0wncXZ35SAlhwTyke5fy6ZAySph0c7I+JwmuxILC0Q5UR8vD/V4J X-Received: by 2002:a05:6402:448b:b0:43b:5ec6:8863 with SMTP id er11-20020a056402448b00b0043b5ec68863mr253501edb.377.1658491309819; Fri, 22 Jul 2022 05:01:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658491309; cv=none; d=google.com; s=arc-20160816; b=zSwGZTVdf65teq5FOG6d3sjS1DJm9L1zYBQKGFKQI1fqIXEfXuRJ+pmsGXaFVfaoDL oAgqgmZk56NPub6sVJFzB2LhSz7u+KwGQF8oyTqxUrn7fpe6B9002T2w8FhRYSlKgl9K epWcbetjE5Rl51E0eSDJjUmTY9PKGEth1cqPFQNX9f+PedVZOH7/SLQ/5uXie/FIAjUK ysrzo3xTrM4ZsUMGTaZ0e8UZpbztiOvE//wnldC4RSX5KMTQg1trje7ltyljEydUj/FA wuymK7GAR6u03xwYZUIS7CvSqVHFBt43lxiwSCVKHdWff1TfQ6rWm2yRVo8bAW+BabOS j9aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9+BL25b+9o5bNGbQRqsQ/hQI5OYoUlIBnuowxjnT98w=; b=OweXk5eXAKwjr+xk4uNNHwMBjukCEa0BtqYAmPStdid04t/yPrxB102IRcSmh7mc59 pzpn4GAFo176eqTK2YgXnlcTvJ2Bhw8Z3qp8+6lzx01coUO93SqgkCYgNu/fxnArrOvG mCLfRF50SAR+/qwa70eMlQ9PInVZaG1nESufwbO8GG32pa7UlToDh8Tz2xfDI2tjHe75 4ZV4FXBbLwCmu6ihEd7g0tpsiS5g5oXVt5GWB+8ZI1QfFfs0AuguvPBlqXEZaoqQXLeC njDXEuKKhd8Zlv59H9j5UwCUVWCudedAXHh9VdNL2YCuLsMgtsmbD2g9mpiOvamkpvg4 5Atw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=UK5tnF1b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb10-20020a170907160a00b0072b394cb930si6087465ejc.784.2022.07.22.05.01.24; Fri, 22 Jul 2022 05:01:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=UK5tnF1b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234722AbiGVMAV (ORCPT + 99 others); Fri, 22 Jul 2022 08:00:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230151AbiGVMAS (ORCPT ); Fri, 22 Jul 2022 08:00:18 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B171B7EA; Fri, 22 Jul 2022 05:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658491215; x=1690027215; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=nRBWTIjqR+EBo83QXnR7YxxBrSXGYH7OV2uGt4ob61E=; b=UK5tnF1bJF4MAafHTS53h023yyOiDai9Td1R19AwJYX8KoKZnl4YsSBv yNMF5LKIX4uAPkJfCoi2k8tmmvitqVH0eOO4r97J/spCFZFVQQjrnab5T M4g7/sb7BUCixn44w1yDsVVUGLhbwlOlHjHGC4CH+VGqP2kd32qjdcUo6 +7eqzQCD9nZ/I1l/PBkl3PZh6kpELhJpOr3hjWR+9uoUjVHqcW38bAuYX uwvoeApFqWUkqICPqotiz20l4T3Br85xI4uw5QLiC654ABI73t3uheOVK 6/spCJrBVEoYMG7+1vPWMrO7tktfl9PQkLDYpglMQPLgL4AcPdlEJBACP Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10415"; a="288470404" X-IronPort-AV: E=Sophos;i="5.93,185,1654585200"; d="scan'208";a="288470404" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 05:00:14 -0700 X-IronPort-AV: E=Sophos;i="5.93,185,1654585200"; d="scan'208";a="657189243" Received: from dstoll-mobl.ger.corp.intel.com (HELO intel.com) ([10.252.44.132]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 05:00:10 -0700 Date: Fri, 22 Jul 2022 14:00:09 +0200 From: Andi Shyti To: Mauro Carvalho Chehab Cc: Chris Wilson , Andi Shyti , Daniel Vetter , Daniele Ceraolo Spurio , Dave Airlie , David Airlie , Jani Nikula , Joonas Lahtinen , Lucas De Marchi , Matt Roper , Rodrigo Vivi , Tvrtko Ursulin , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Fei Yang , Thomas =?iso-8859-15?Q?Hellstr=F6m?= Subject: Re: [PATCH v2 05/21] drm/i915/gt: Skip TLB invalidations once wedged Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mauro, On Thu, Jul 14, 2022 at 01:06:10PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Skip all further TLB invalidations once the device is wedged and > had been reset, as, on such cases, it can no longer process instructions > on the GPU and the user no longer has access to the TLB's in each engine. > > That helps to reduce the performance regression introduced by TLB > invalidate logic. > > Cc: stable@vger.kernel.org > Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") > Signed-off-by: Chris Wilson > Cc: Fei Yang > Cc: Andi Shyti > Acked-by: Thomas Hellstr?m > Signed-off-by: Mauro Carvalho Chehab I haven't read any concern from Tvrtko here, in any case: Reviewed-by: Andi Shyti thanks, Andi