Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 22 Jul 2022 15:05:44 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Hilton Chain <hako@ultrarare.space>
cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        =?ISO-8859-15?Q?Jos=E9_Exp=F3sito?= <jose.exposito89@gmail.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: apple: Add "GANSS" to the non-Apple list
In-Reply-To: <y76wnc6o6w9.wl-hako@ultrarare.space>
Message-ID: <nycvar.YFH.7.76.2207221505380.19850@cbobk.fhfr.pm>
References: <y76wnc6o6w9.wl-hako@ultrarare.space>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 21 Jul 2022, Hilton Chain wrote:

> While using the name "SONiX USB DEVICE" for wired mode, my GANSS keyboard
> uses "GANSS" for bluetooth mode as well, so adding this to the list.
> 
> Signed-off-by: Hilton Chain <hako@ultrarare.space>
> ---
>  drivers/hid/hid-apple.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index 7fbde58e1219..6970797cdc56 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -320,7 +320,8 @@ static const struct apple_key_translation swapped_fn_leftctrl_keys[] = {
>  static const struct apple_non_apple_keyboard non_apple_keyboards[] = {
>  	{ "SONiX USB DEVICE" },
>  	{ "Keychron" },
> -	{ "AONE" }
> +	{ "AONE" },
> +	{ "GANSS" }
>  };
>  
>  static bool apple_is_non_apple_keyboard(struct hid_device *hdev)

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs