Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 22 Jul 2022 15:04:17 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Aashish Sharma <shraash@google.com>
cc:     "Daniel J . Ogorchock " <djogorchock@gmail.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Guenter Roeck <groeck@chromium.org>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: nintendo: Fix unused-const-variable compiler
 warning
In-Reply-To: <20220720054225.1623875-1-shraash@google.com>
Message-ID: <nycvar.YFH.7.76.2207221504020.19850@cbobk.fhfr.pm>
References: <20220720054225.1623875-1-shraash@google.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 20 Jul 2022, Aashish Sharma wrote:

> The following compiler warning is produced when CONFIG_NINTENDO_FF
> is not set:
> 
> >> drivers/hid/hid-nintendo.c:405:29: warning: 'JC_RUMBLE_ZERO_AMP_PKT_CNT'
>    defined but not used [-Wunused-const-variable=]
> 
> To fix this, move the variable 'JC_RUMBLE_ZERO_AMP_PKT_CNT' under the
> CONFIG_NINTENDO_FF's conditional compilation block.
> 
> Signed-off-by: Aashish Sharma <shraash@google.com>

Applied to for-5.20/ninitendo. Thanks,

-- 
Jiri Kosina
SUSE Labs