Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <quic_cang@quicinc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
        "quic_ziqichen@quicinc.com" <quic_ziqichen@quicinc.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>
CC:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Daejun Park <daejun7.park@samsung.com>,
        Jinyoung Choi <j-young.choi@samsung.com>,
        Kiwoong Kim <kwmad.kim@samsung.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
Thread-Topic: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
Thread-Index: AQHYmz2OvInxSH8TlUq8qOHvad4nHq2Ke1zw
Date:   Fri, 22 Jul 2022 14:42:23 +0000
Message-ID: <DM6PR04MB6575D84FB380A844DEA7CC3CFC909@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <1658214120-22772-1-git-send-email-quic_cang@quicinc.com>
 <1658214120-22772-2-git-send-email-quic_cang@quicinc.com>
In-Reply-To: <1658214120-22772-2-git-send-email-quic_cang@quicinc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?66nEkFsFHv+SpVyL7gq+nWp56d5A4qsqlegWFvuRTkdH9gZ21tAeRRcQMSFt?=
 =?us-ascii?Q?dFZpPjSzoYutAl2TOToWfv4LFVAxVpXSON27//ITYfccpJCX8yFwehW5D140?=
 =?us-ascii?Q?B+G+328EUA+8dFiibF+Qu8aOZ4GkuHN6nmEzFhfyp2p9HlnfMrDfDDPVfmBz?=
 =?us-ascii?Q?wCbWxyjnwXBkRkDEHRX+v1IW54Fvp15nR7ZCTgfmJvR8i+O6TTYvrXQjEKFt?=
 =?us-ascii?Q?itSJRA5tJxIrNdpLiDvPUHfOqfKEjm2kXndcZKOgiOO9vwGBCKjFl8vYTm67?=
 =?us-ascii?Q?zLGaozqeTCJXSBDvS5zBEA/SzAi5DfeGwQ72Xb0eqqjov5uH7tqb8kapSqal?=
 =?us-ascii?Q?pfbb87YXaUqFywdC62XTdkxIDnhhrBuW9+QEJEgET+U30OAvlAawQfh4TuG7?=
 =?us-ascii?Q?OmGbPf0qggbBklALjjSZ7sVwNhy7FLKB9+lxiWB3tB4jsFeSlFm3098O2x6I?=
 =?us-ascii?Q?ZPJ5sLZ3l7c9bT6brO32kUM6Rl6a81AIV/bbpPyauxtgYIo2hQRjJV2TZl8T?=
 =?us-ascii?Q?pKIVfqtRC43wjtOZ4q31TXrQZp1Wytbj8Zz/6yRuVo/TqkyCclJrWrhqL4IO?=
 =?us-ascii?Q?UhHy7XbVHR1mRdfbK/0pxSxkmIQ4shA4lCDwgsbKL4MkyuClGwdRUL2k0+VX?=
 =?us-ascii?Q?g06CIfNDeENiCPzGGTwWxM8wc4jnk3JTHqyEtl9Nnr0lQxNaC9dca4Pqbbo2?=
 =?us-ascii?Q?9ucRto6PMH3uCPQef8KjIBXHrhT7E9QT4ndvpCHbUupsuL0wJMRb38BTh8/N?=
 =?us-ascii?Q?3aqrBzCxaRBkrj0LRod3Z7n4G912bwNOpKaGg7dpJs20jRaHE/d3DdYDigMD?=
 =?us-ascii?Q?yq1ZeVyz007cRThAVzOO+Tl0UJhadLcgbK0r9TpZd2JWyz2Skmy7lvxusA/k?=
 =?us-ascii?Q?M2HfDhmCnBOJD3UReZsL99PSwD0RFOcGVX1bznz6j9iGkzRHSKObwtZbcqMX?=
 =?us-ascii?Q?eJUggI7cfp0++6gxU8GHCgp7CvrtBPoqkPFjjMCDrJiObC4W2hhGOlzejdfe?=
 =?us-ascii?Q?MX8cqq7C22XtsTBNPRQBiHjMf+7bWnaXjCEx8eoFNICa3yNwcgrL+KxBu/0X?=
 =?us-ascii?Q?AigZlIoXkrC3u4n8c2204osofRKK77hUJRWjicacKWdwE+l1F/ui59WvRay8?=
 =?us-ascii?Q?t3ntRB5kriqwZiyhRaObbaEykqguTqTWExmLdNG+CA5t1qgoDk6pNecq0qSE?=
 =?us-ascii?Q?U2L5/4pYr4J6vujhYQyCIzJLZrwTuK8sa7mzSZCtn5uPvAuwKxEryi9T/s/a?=
 =?us-ascii?Q?9K2cDr/aD9o1gqlcux0sc85h4lX7+AAiFCZXgN2UOtKDauumyC7QNDNDMSD/?=
 =?us-ascii?Q?pVbjXIJeC4LC+Fw88PVng9ZJMUNt6f1gTP4Uk1GUjj0LpsZcQfY9v6IiYMhD?=
 =?us-ascii?Q?xshsRrO7Q6d7sPANioUMi4OoENW21Vek680dchq/kaXyo6wM67CYCu17C013?=
 =?us-ascii?Q?BwxMa/1fGsOCfmLZQaPZx89xr9LVn33/NxMqMxiFfKAcnicTX1E7WPYlDbtZ?=
 =?us-ascii?Q?kTIuo1ubCgevC+Zq8X2Dp/7ag4aG3xLe+574zbC/J1bDpMNZwrkbiQeRUOfU?=
 =?us-ascii?Q?trcz9tzMCNf4eBISux29vdEjRZXsUFVoL6r/fjJ+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b4426eb-72c3-43e9-4a77-08da6bf063f8
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2022 14:42:23.9729
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UBsWu7GqfcLpb3ZjByc4cEpctZn2z116LDEI8GYEUv6jBR1rfEoqMVIpB4Sz6gfD6vqIMKr3ujQOBZvplQju7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1082
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>                                       desc_buf[DEVICE_DESC_PARAM_SPEC_VER=
 + 1];
> +
> +       dev_info->bqueuedepth =3D desc_buf[DEVICE_DESC_PARAM_Q_DPTH];
> +
>         b_ufs_feature_sup =3D desc_buf[DEVICE_DESC_PARAM_UFS_FEAT];
>=20
>         model_index =3D desc_buf[DEVICE_DESC_PARAM_PRDCT_NAME];
> @@ -8184,6 +8315,9 @@ static int ufshcd_probe_hba(struct ufs_hba *hba,
> bool init_dev_params)
>                 ret =3D ufshcd_device_params_init(hba);
>                 if (ret)
>                         goto out;
> +
> +               if (is_mcq_enabled(hba) && hba->dev_info.bqueuedepth)
> +                       ufshcd_mcq_config_mac(hba);
>         }
So what happens if the device does not implements the shared queueing archi=
tecture.
MCQ is still enabled?

Thanks,
Avri