Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp757604imi; Fri, 22 Jul 2022 08:49:27 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uoEzmVen6eEbVuO1t1i136nFDHF+5MJcgNHRx4dBkn4hGkr7/3efVvq8IC0a7M9Aa4NUWX X-Received: by 2002:a17:902:e747:b0:16c:3ffd:61e4 with SMTP id p7-20020a170902e74700b0016c3ffd61e4mr239643plf.12.1658504967117; Fri, 22 Jul 2022 08:49:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658504967; cv=none; d=google.com; s=arc-20160816; b=f7t/JaCquQpcOIZTHWYHltx2g2jlXLfbSwzSSZ51vUghD7tyMPpx7JyJSh/PX+dpMP nYbudFcg4+spusFPRZfS/+eNoOp4SJcj+KTm9IwdoP0m6vWsUu0PV203rrhxeoi+/7iR gvXmdE+n2c+BiKjx8cJ5PetddHkde8aujLsjJ3rn3g33f3OP2HzZtvt8YXelErdGnCLh 0+hPPVIumTyUpUzakmuSfZ4BEs2DNcWj1nPSXZWiv95eKRmvCPz9V5oRi/NEyvsrWEgv xD+4dlJDHUU9YZJF9Go8dadmkm9f348U7qKj6AMhsPQ1/2D5is0wc635itHIsH5Lr+m1 4V8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=E94iJ3qn1wvPR7QjZHDBoxED/WQlhga5Z9BvDtPyCes=; b=m8/TS9t0tA9nnGEzu41mQPzYwYnqg9E8JqdGZJFoCyb9KuvwwiC9UIJqNKVnILvrr1 JcwX7bSry+sLTR4+4XgF5auwOAK6iRE9nvjfjZ7hcO0GzKbIJp/QGk3IT9tfRXWt7NIE je7seY9FEcwLY+PpXEE0VLQ78GECipbPrDlpKP85rAoF/F28H1HMKeUJf6WPC2I9iEN4 1AmWfLr7+2zIud1lIo7Pe6mcvaRykMkVWmbwhbKX9qjv1H0ggqqNIUO3bLK9E7cSBMCf LsWp6atv0tsj9yzqMHBWTYcN2Sf69/eyCM8MTpbER94wJksduZpEECrnTqIYHmCcGoWL Xzcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Sea40vgU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y187-20020a6364c4000000b00415cb3d4bbcsi5800645pgb.727.2022.07.22.08.49.07; Fri, 22 Jul 2022 08:49:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Sea40vgU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235402AbiGVPHA (ORCPT + 99 others); Fri, 22 Jul 2022 11:07:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231700AbiGVPG7 (ORCPT ); Fri, 22 Jul 2022 11:06:59 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D836184EE1 for ; Fri, 22 Jul 2022 08:06:58 -0700 (PDT) Received: from [192.168.178.53] (82-71-8-225.dsl.in-addr.zen.co.uk [82.71.8.225]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbeckett) by madras.collabora.co.uk (Postfix) with ESMTPSA id 51B6F6601ACC; Fri, 22 Jul 2022 16:06:57 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658502417; bh=talAFwKKsaOv9iY2eGoXpz6PwEbul7ITq/1xEmofP3I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Sea40vgUTv/2odG8rMIWpOXdJwGZxjpHbdjjPbIlHeG4/UuNgRz0wAQmeQmtzc8g0 0SdX1O0A9MMzT7I8lvDwt1ZnVp5mMwaZKxGOHZKP7csI5d2BiNHfEszXz+GXwWhR42 tCxoG7NgynEIUIVto0T04imAzh8g1aq7o/xUUhq+SDjRiSQP9aWSxYNsaE1524zfyg vtEiwFj8kKBiVIMavZ0MDU14sIIfilNR8v25pKo6YLTNVwxQCD+s8Vw8Ir1iVvLcOK uEc8QMgXst2mWYKrK4Wg1fFt7YiIQnuRHyaDM3u8xle+rGs5Q6S+n+MJkQuAXSVvn6 /jaJUQDrYz93Q== Message-ID: <1b35338a-e189-2134-5c87-e2f2edc54cee@collabora.com> Date: Fri, 22 Jul 2022 16:06:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] drm/i915: stop using swiotlb Content-Language: en-US To: Christoph Hellwig Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , kernel@collabora.com, Thomas Hellstrom , Matthew Auld , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20220722145920.1513509-1-bob.beckett@collabora.com> <20220722150358.GA7152@lst.de> From: Robert Beckett In-Reply-To: <20220722150358.GA7152@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/07/2022 16:03, Christoph Hellwig wrote: >> + return max_t(size_t, UINT_MAX, dma_max_mapping_size(dev)); > > Shouldn't this be a min? eugh! yes. Stand by for v3