Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Chen, Tim C" <tim.c.chen@intel.com>
To:     Roman Gushchin <roman.gushchin@linux.dev>,
        "Sun, Jiebin" <jiebin.sun@intel.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
        "hannes@cmpxchg.org" <hannes@cmpxchg.org>,
        "mhocko@kernel.org" <mhocko@kernel.org>,
        "shakeelb@google.com" <shakeelb@google.com>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "Huang, Ying" <ying.huang@intel.com>,
        "amadeuszx.slawinski@linux.intel.com" 
        <amadeuszx.slawinski@linux.intel.com>,
        "Li, Tianyou" <tianyou.li@intel.com>,
        "Guo, Wangyang" <wangyang.guo@intel.com>
Subject: RE: [PATCH] mm: Remove the redundant updating of
 stats_flush_threshold
Thread-Topic: [PATCH] mm: Remove the redundant updating of
 stats_flush_threshold
Thread-Index: AQHYnaWE7yyZOgM2eEyGrUJNmSgBKa2Kn0CAgAAOJCA=
Date:   Fri, 22 Jul 2022 17:57:56 +0000
Message-ID: <DM6PR11MB410736BFD198D38BBCE9E064DC909@DM6PR11MB4107.namprd11.prod.outlook.com>
References: <20220722164949.47760-1-jiebin.sun@intel.com>
 <YtrY5V+dZl4+Gtz4@castle>
In-Reply-To: <YtrY5V+dZl4+Gtz4@castle>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-reaction: no-action
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vXeCIb3tu05ao2n5HtsVg45Ma/6NJ2s0OaTJzJBD55Lozj0z6OFFGtvtQr9I?=
 =?us-ascii?Q?7v+V2ClEOS1G+j0QjyKN5MbNq1GMnrT43V4MGD3eaIJ4z5ODYUlpvJLYMF5V?=
 =?us-ascii?Q?JjAuCMKYOVDsYpbkwTzNupYEc14iN1Zb3Uzjx/fzCIOZ8ySYb1N+sVeE0x7K?=
 =?us-ascii?Q?ZpZetihoNHDCwto+wl7TD+xQ7ncl0HzZUgyOimOPmZQVzzEBdVZ6ozMRTlNB?=
 =?us-ascii?Q?a1FBlQ4Zq0Zv8zT3KNcMtGgc5aPefqgRIMN3f99uE0r+NheTu31jBafRstVS?=
 =?us-ascii?Q?8BKcnVWSLeYEGjFBJXC66aM2ixZZhWRByAlhuBTJ6iCwt2T9eqxurV0wDGMh?=
 =?us-ascii?Q?LHsBcAQAjKJlo/inVhPVbOItIPF+Q8PW7yvXje2bKnDh5qlNaPvrLhSJt9Hl?=
 =?us-ascii?Q?DFnqDsJ1q9XquIg56MEZyFXjBGWq+b9FW+BGnDch8qemUgw5WFM+saeWl8KH?=
 =?us-ascii?Q?1AIgZYC2R7ejt+U8WFi845IGBKkQn9CNuF/gyHp5p4uT0zltxfg5WdX+vNvr?=
 =?us-ascii?Q?QZY1EScd7Oew6d94GJlymkhcudIGk1V39QeFPT2oEA7FrpMF1cAiHatdUgYS?=
 =?us-ascii?Q?nBS/x6EoKSUtYWLavjfdVYEaSdOoFoYciivUj3OYgF+3n23x4qRWDTeAmZAc?=
 =?us-ascii?Q?RBy1K2MaBNtHWjxUXANmfdvSj2cxFXvXHDXWOIyGlO8CfLTB4MppFgGRWBzB?=
 =?us-ascii?Q?+2Z5HFzskMuX0fKdFl6h8GJJrpsknwq3CmJ+hXI3t2AsmRw8JI9iHO4u+X8U?=
 =?us-ascii?Q?VRt3w9UmqoT8mYzKizCaVzBElkx8aKeN2qtOEOL08kFvmqJqHvy5XcESS9nJ?=
 =?us-ascii?Q?/tsZQ/12Oafh5exfN68NM7nS90wFLugtZumtX6ADZgtKb3+DJPFMEPPFxisJ?=
 =?us-ascii?Q?78NY1HlscA8VBJlMcy0ncH0fNj9rZhFcQLny0Mx/j0hZq4igWOlufvySOMJO?=
 =?us-ascii?Q?E45GWx1ShGW7US4SWjbhEjbcPDEf5gMK7i5JS74DrvHNE9uRk8Xljan1yzoq?=
 =?us-ascii?Q?AojUpDSL6sxRb7UL1AzHePfd2+3LuFjs3XLCHeKlcmf+nS4r8tctS2+4LmO7?=
 =?us-ascii?Q?sFGs7dUNnngJ31Leq1SgDDLJpKV2GXM6HDKAyZs88JrFHarQ7pmu4NybIYcE?=
 =?us-ascii?Q?+zKlWNnBhN+O93aBKPxXEAe7+455KzMO4sBE9wxKmw8PwAeoIP0YdZNZxq/A?=
 =?us-ascii?Q?beWux2pwil1TEet9MZZnuXIOUoD1GsAYJySSmeJwCx+o80eR/PY9gmu30P9B?=
 =?us-ascii?Q?My+ep2PZ01TWKFYncwmnsQHRkhlGHGqjDdGfzSHZZ687KgOp1H/kvfqJIHNF?=
 =?us-ascii?Q?qB6Um7S5A72AFIwaCFkV3JN/P2HYgHEZKc8KgG8UGMKpwFdDlCRXokGVJ7Fv?=
 =?us-ascii?Q?r+q4fKUEJtHAjTJqOBWzl6g1pWW9p+N9CkaygUM3KHnOzuBKvAsxrvwuxN42?=
 =?us-ascii?Q?FbCEWaDr4KTEeC2fHrjCKdUHsIP16jqmd4maBuy0Mj70SQE6FCBPzaT9jNAI?=
 =?us-ascii?Q?VUTZOrwPYKbCh4pu/a74md8K0jRuFLR8BiLNvLO25DMfZXM1JmlCIfwzk8G9?=
 =?us-ascii?Q?VZuC+dJ5DHvXdBeZ0MsdGnDyvYURykHT3n1ACW1S?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58dc55e7-ad14-4f38-9c2d-08da6c0bb52a
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2022 17:57:56.5942
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ojLXAPWEs7066FiQLOCmFHCU1LOVSipe0KfIZ8Hyh0nwzgj8o+WAaLdAIDEs5+nGzHbX07Pb/mijmo7QqX6b5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5005
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>
>On Sat, Jul 23, 2022 at 12:49:49AM +0800, Jiebin Sun wrote:
>> From: jiebin sun <jiebin.sun@intel.com>
>>
>> Remove the redundant updating of stats_flush_threshold. If the global
>> var stats_flush_threshold has exceeded the trigger value for
>> __mem_cgroup_flush_stats, further increment is unnecessary.
>>
>> Apply the patch and test the pts/hackbench-1.0.0 Count:4 (160 threads).
>>
>> Score gain: 1.95x
>> Reduce CPU cycles in __mod_memcg_lruvec_state (44.88% -> 0.12%)
>>
>> CPU: ICX 8380 x 2 sockets
>> Core number: 40 x 2 physical cores
>> Benchmark: pts/hackbench-1.0.0 Count:4 (160 threads)
>>
>> Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>
>
>Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
>
>Good optimization, thanks!

Looks good. Nice performance improvement.

Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>