Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 22 Jul 2022 19:43:23 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Tomer Maimon <tmaimon77@gmail.com>, avifishman70@gmail.com,
        tali.perry1@gmail.com, joel@jms.id.au, venture@google.com,
        yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, openbmc@lists.ozlabs.org,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] spi: npcm-pspi: Add NPCM845 peripheral SPI support
Message-ID: <YtrvyyMGm64hFG5j@sirena.org.uk>
References: <20220722114136.251415-1-tmaimon77@gmail.com>
 <20220722114136.251415-3-tmaimon77@gmail.com>
 <afae04e0-76a3-1bcb-5b47-9944fa9ab2c0@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ry/50fY3hlFre6NP"
Content-Disposition: inline
In-Reply-To: <afae04e0-76a3-1bcb-5b47-9944fa9ab2c0@linaro.org>
Precedence: bulk


--ry/50fY3hlFre6NP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jul 22, 2022 at 08:31:22PM +0200, Krzysztof Kozlowski wrote:
> On 22/07/2022 13:41, Tomer Maimon wrote:

> >  static const struct of_device_id npcm_pspi_match[] = {
> >  	{ .compatible = "nuvoton,npcm750-pspi", .data = NULL },
> > +	{ .compatible = "nuvoton,npcm845-pspi", .data = NULL },

> The devices look compatible, so why not reusing 750 compatible and
> adding more specific upfront only in the bindings instead?

...with a fallback list required by the bindings so the driver actually
binds.  Note that bindings are currently not in YAML format so there'd
be even less enforcement of that than normal, and as they're currently
written the bindings don't require fallback.

--ry/50fY3hlFre6NP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLa78sACgkQJNaLcl1U
h9AEwwf+OtPY0/qOhQEJ/2NsoSOb8GSd7aJy+EOe87QYuCJBD5JsoZiLHai6ubHa
0zs/2vrhlkyXG7cwFqmhim4KR5XhbU5vrBrqV3SLNb8tKfRF8EcUNpG8jK9S+Pih
GldFX6HoidQdZAZK7eGvXsWymaJavKEeLJ+jD/GQ15LnlNSVyxSYF/IW0rd9SP3L
5MdwDI3SLPefhUfFmSd/QEZ5ZbY3RLRvCkkUIaFLC/0VwC9mYV0NbBUQm2RbC5EO
ljTGswpc41I4VTgs9IAuLgPetUsqecivo4Q8Iriwb+7g2SMbIaHf6LtJQqaOGqvc
0BWDzIyUZDxzu3tiB6I3WNJupudE9A==
=7ol/
-----END PGP SIGNATURE-----

--ry/50fY3hlFre6NP--