Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <614ce7e3-ff4e-5d76-e940-2aa222535743@gmail.com>
Date:   Fri, 22 Jul 2022 20:52:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] media: staging: media: zoran: Deleted dead code
Content-Language: en-US
To:     Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
Cc:     Corentin Labbe <clabbe@baylibre.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20220722182622.23719-1-abhijeet.srivastava2308@gmail.com>
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <20220722182622.23719-1-abhijeet.srivastava2308@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/22/22 20:26, Abhijeet Srivastava wrote:
> Deleted part of code in block comment
> 
> Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
> ---
>   drivers/staging/media/zoran/zoran_driver.c | 9 ---------
>   1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> index b408c1d4e0a7..836edf623571 100644
> --- a/drivers/staging/media/zoran/zoran_driver.c
> +++ b/drivers/staging/media/zoran/zoran_driver.c
> @@ -746,11 +746,6 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
>   	.vidioc_enum_input		    = zoran_enum_input,
>   	.vidioc_g_input			    = zoran_g_input,
>   	.vidioc_s_input			    = zoran_s_input,
> -
> -/*	.vidioc_enum_output		    = zoran_enum_output,
> - *	.vidioc_g_output		    = zoran_g_output,
> - *	.vidioc_s_output		    = zoran_s_output,
> - */
>   	.vidioc_g_std			    = zoran_g_std,
>   	.vidioc_s_std			    = zoran_s_std,
>   	.vidioc_create_bufs		    = vb2_ioctl_create_bufs,
> @@ -762,13 +757,9 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
>   	.vidioc_streamon		    = vb2_ioctl_streamon,
>   	.vidioc_streamoff		    = vb2_ioctl_streamoff,
>   	.vidioc_enum_fmt_vid_cap	    = zoran_enum_fmt_vid_cap,
> -/*	.vidioc_enum_fmt_vid_out	    = zoran_enum_fmt_vid_out,*/
>   	.vidioc_g_fmt_vid_cap		    = zoran_g_fmt_vid_cap,
> -/*	.vidioc_g_fmt_vid_out               = zoran_g_fmt_vid_out,*/
>   	.vidioc_s_fmt_vid_cap		    = zoran_s_fmt_vid_cap,
> -/*	.vidioc_s_fmt_vid_out               = zoran_s_fmt_vid_out,*/
>   	.vidioc_try_fmt_vid_cap		    = zoran_try_fmt_vid_cap,
> -/*	.vidioc_try_fmt_vid_out		    = zoran_try_fmt_vid_out,*/
>   	.vidioc_subscribe_event             = v4l2_ctrl_subscribe_event,
>   	.vidioc_unsubscribe_event           = v4l2_event_unsubscribe,
>   };

Why does the subject line start with "media:" The subsystem is 
"staging:" so the subject should start with "staging: media: ..."

I have no clue if this is accepted.

Regards,

Philipp