Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp915866imi; Fri, 22 Jul 2022 12:28:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u3AF8MYKZQ5BivukIRHSApX2dx0SMg3z8puUgmiG7hCYYIC/cWFq5TXD0xiSoLM/ZDs/Oe X-Received: by 2002:a17:902:e749:b0:16c:3d6f:aba3 with SMTP id p9-20020a170902e74900b0016c3d6faba3mr1260720plf.135.1658518103397; Fri, 22 Jul 2022 12:28:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658518103; cv=none; d=google.com; s=arc-20160816; b=btyXw0YeK2ls5SvJscS9ViKB32hDbEgoBYhYUEoy6paQdwJ1PNRfVkrKPp4mt1mhwx XaRKsXM7ooDnMi9U4g2uzcvWrFdWY+2dN9NSYMuZS+fnT/IAZx48pEYK1S7CLH0Abi0b vc4lxgcqTTVDIfGEZ3X8iL7VlDO26McWQnu1KvCGFkiEGtcGuoVCcLp7aX6e+QBHQGcO UJaOdeRli9/wI/s0JlEW9nEPlcgQgWWAV8PMQDtq3Ya16cD+lvSM4qzxmoFXSsTBqGG3 46tMSN5+sHhBSgWZhOPpbCsNor8ARH+Io7iD+4gZn/E3yxXSw/+jGF+4A8CSrl5yKdJx /lpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=dMm+IIk7LsnaULBPtrulmSgNjAbQbMnMSaZg0iF1060=; b=bnzqWTYx1sNM5jaG/OQ/vSj2c6dQUMjY/2GPP1dF7Sgu0z/ocOYji6/1QHOkxt2Sfv 5UZqp9myrK99f5kqQQw3JUUZyiXNxsysnq/nLki6CH2ji0svPZVrLXJ/IPiHsrnC/BA9 CiSIwOIpFxEzxlQ+Hra/I1WecsQ/YjSxWFiW4MTal3lyqp1KIRcTZgp3iYfLjktboSQW ypQPc8P05Bdu7ZrjUgtrZi677pZTGP4EWN2rN+GJpxG+HL+oY/dGrxkUEoR6huU7WtJ6 hii7uGlta9dgRJxPXBmVsiSTuk5aEzhnbG6S2I0uavunRqaf/x/sUE34yQiTApE264wE yuag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lN3rWplU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f65-20020a625144000000b0052542cfb5c4si770193pfb.235.2022.07.22.12.28.07; Fri, 22 Jul 2022 12:28:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lN3rWplU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235397AbiGVTYg (ORCPT + 99 others); Fri, 22 Jul 2022 15:24:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbiGVTYf (ORCPT ); Fri, 22 Jul 2022 15:24:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C34161105; Fri, 22 Jul 2022 12:24:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1122A617B1; Fri, 22 Jul 2022 19:24:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42397C341C6; Fri, 22 Jul 2022 19:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658517873; bh=v9iFrD/QGUF5GFfCZcVltWib9BENP1EbeimH9tpGgd8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=lN3rWplUaT+yeB0zqHvh4zAjKVtmtuPF00xF+9Mj5RpwEL4b4sk7gZKy9qBsdQRW6 a2dvia0tswCPd8RxhzeE78mj0FZlWAQtw8+XOnLI1VcR3rNYBo9SSHxzCkamSlR2Q8 llSLWlBEgv9QSdx93+RKKQoJlhtRoVWsKp44hQMVO99gYmNQWlxfQ5jX1OhhZeFz6F k761INM3sgEXrwSHM1NLKXTyYnc25PPY6GA97bDBfz4PFxkgDIjPw+Yjfnm5vkvGkC Suu9tB4VvSUKTCV6aFj9XMexaBzKGAPXdZSgxKFTP/F7ceX2MClL9SVNYY0EroGYpF V1MShkjfCee6g== Date: Fri, 22 Jul 2022 14:24:31 -0500 From: Bjorn Helgaas To: Bharat Kumar Gogada Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, michals@xilinx.com Subject: Re: [PATCH v6 0/2] Add support for Xilinx Versal CPM5 Root Port Message-ID: <20220722192431.GA1923712@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220705105646.16980-1-bharat.kumar.gogada@xilinx.com> X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 05, 2022 at 04:26:44PM +0530, Bharat Kumar Gogada wrote: > Xilinx Versal Premium series has CPM5 block which supports Root Port > functioning at Gen5 speed. > > Xilinx Versal CPM5 has few changes with existing CPM block. > - CPM5 has dedicated register space for control and status registers. > - CPM5 legacy interrupt handling needs additional register bit > to enable and handle legacy interrupts. > > Changes in v6: > - Added of_device_get_match_data to identify CPM version. > - Used enum values to differentiate CPM version. > > Bharat Kumar Gogada (2): > dt-bindings: PCI: xilinx-cpm: Add Versal CPM5 Root Port > PCI: xilinx-cpm: Add support for Versal CPM5 Root Port > > .../bindings/pci/xilinx-versal-cpm.yaml | 38 ++++++++++- > drivers/pci/controller/pcie-xilinx-cpm.c | 64 ++++++++++++++++++- > 2 files changed, 98 insertions(+), 4 deletions(-) Applied to pci/ctrl/xilinx-cpm for v5.20, thanks! I tweaked the driver patch to test: if (port->variant->version == CPM5) instead of just: if (port->variant->version) so it doesn't depend on the enum values.