Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 22 Jul 2022 13:06:50 -0700 (PDT)
Subject:     Re: [PATCH] riscv: compat: vdso: Fix vdso_install target
In-Reply-To: <20220625154207.80972-1-emil.renner.berthing@canonical.com>
CC:     linux-riscv@lists.infradead.org, guoren@linux.alibaba.com,
        linux-kernel@vger.kernel.org
From:   Palmer Dabbelt <palmer@dabbelt.com>
To:     emil.renner.berthing@canonical.com
Message-ID: <mhng-f6f17824-3a4a-4461-9195-dec6695e03a1@palmer-mbp2014>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sat, 25 Jun 2022 08:42:07 PDT (-0700), emil.renner.berthing@canonical.com wrote:
> When CONFIG_COMPAT=y the vdso_install target fails:
>
> $ make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- vdso_install
>   INSTALL vdso.so
> make[1]: *** No rule to make target 'vdso_install'.  Stop.
> make: *** [arch/riscv/Makefile:112: vdso_install] Error 2
>
> The problem is that arch/riscv/kernel/compat_vdso/Makefile doesn't
> have a vdso_install target, but instead calls it compat_vdso_install.
>
> Signed-off-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> ---
>  arch/riscv/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> index 34cf8a598617..5cfbef613e34 100644
> --- a/arch/riscv/Makefile
> +++ b/arch/riscv/Makefile
> @@ -110,7 +110,7 @@ PHONY += vdso_install
>  vdso_install:
>  	$(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@
>  	$(if $(CONFIG_COMPAT),$(Q)$(MAKE) \
> -		$(build)=arch/riscv/kernel/compat_vdso $@)
> +		$(build)=arch/riscv/kernel/compat_vdso compat_$@)
>
>  ifeq ($(KBUILD_EXTMOD),)
>  ifeq ($(CONFIG_MMU),y)

Sorry for missing this, it's on fixes.