Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d8dfa68b-00d8-9853-e2ba-57c2bb54c05a@redhat.com>
Date:   Fri, 22 Jul 2022 15:20:10 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH] xfs: Fix comment typo
Content-Language: en-US
To:     Xin Gao <gaoxin@cdjrlc.com>, djwong@kernel.org
Cc:     dchinner@redhat.com, chandan.babu@oracle.com,
        linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220722193624.18002-1-gaoxin@cdjrlc.com>
From:   Eric Sandeen <sandeen@redhat.com>
In-Reply-To: <20220722193624.18002-1-gaoxin@cdjrlc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/22/22 2:36 PM, Xin Gao wrote:
> The double `for' is duplicated in line 3788, remove one.
> 
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
>  fs/xfs/libxfs/xfs_bmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index 6833110d1bd4..6f6d87ba29a3 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -3785,7 +3785,7 @@ xfs_bmapi_trim_map(
>  		mval->br_startblock = got->br_startblock +
>  					(*bno - got->br_startoff);
>  	/*
> -	 * Return the minimum of what we got and what we asked for for
> +	 * Return the minimum of what we got and what we asked for
>  	 * the length.  We can use the len variable here because it is
>  	 * modified below and we could have been there before coming
>  	 * here if the first part of the allocation didn't overlap what

NAK.

The comment is correct.