Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7e1182f7c01af15d47d7ee836a72bbd5e9b47d64.camel@HansenPartnership.com>
Subject: Re: [PATCH] hfsplus: Fix code typo
From:   James Bottomley <James.Bottomley@HansenPartnership.com>
To:     Xin Gao <gaoxin@cdjrlc.com>, linux-fsdevel@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
Date:   Fri, 22 Jul 2022 16:12:34 -0400
In-Reply-To: <20220722195133.18730-1-gaoxin@cdjrlc.com>
References: <20220722195133.18730-1-gaoxin@cdjrlc.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 2022-07-23 at 03:51 +0800, Xin Gao wrote:
> The double `free' is duplicated in line 498, remove one.
> 
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
>  fs/hfsplus/btree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/hfsplus/btree.c b/fs/hfsplus/btree.c
> index 66774f4cb4fd..655cf60eabbf 100644
> --- a/fs/hfsplus/btree.c
> +++ b/fs/hfsplus/btree.c
> @@ -495,7 +495,7 @@ void hfs_bmap_free(struct hfs_bnode *node)
>  	m = 1 << (~nidx & 7);
>  	byte = data[off];
>  	if (!(byte & m)) {
> -		pr_crit("trying to free free bnode "
> +		pr_crit("trying to free bnode "

What makes you think this message needs correcting?  The code seems to
be checking whether we're freeing an already free bnode, meaning the
message looks correct as is and the proposed change makes it incorrect.

James