Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp1127361imi; Fri, 22 Jul 2022 18:16:14 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ulUGYXXKrJMOpg/b3AGYRe5aHnZeOp+onxeSWPEwo1ljqGntID+S9wbeteED1ksfA0Fhm4 X-Received: by 2002:a17:90b:4a12:b0:1ef:fd9e:a02e with SMTP id kk18-20020a17090b4a1200b001effd9ea02emr20666595pjb.216.1658538974027; Fri, 22 Jul 2022 18:16:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658538974; cv=none; d=google.com; s=arc-20160816; b=JuhhzusZ4iLaGBxsJFlFfcAfjRGXNjLIJVsxaMbzomd715C4Cke5KIgbDS+n+rVHqI h402XGi05xiBneB0TpVfAioz5nblMXNjS87+PplMyvD2BVxlmFYahGJVLzcYUUEANuaX HUHDiK6qX+hFuKfrPyISXTRBkq1mARmIkkwRC9ADq9TxLtmsHa1vGeUZoCm33Ov5BLTw T/Spwzs1WyeRzgaET77i+rFtLC57FJrEcsyFN6/pVj3NZHiQKylnCvvjZEdcthu5fSMO t3Fg9+XUdUhJHh3WceuAqdA3Bqekh47NVsJou5Y6C5J3VnJr/odM7nSa1mIpH4CBfjnu p43g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:reply-to:dkim-signature; bh=RtVR2Tkco0tuXD7bLAFV7Fg1ldNSfzq0D9HUqql94JM=; b=1A1D0VjyawuUr+aXO/QF/3Duy4cTJcqKpW3bFkU/IQnOzeydJqIA8kAdSwmDwthfnf PWuP6XOH7JhOeOd4pylyrsLNGfY8sUtL1JYTsQVwL3TUAZX2Wux/iKcC5DMug7wu4Nt/ NviD/9N7QyKJq5tXxi/8stwmqa3dxr/wIcx7virqn6TnIYRJJlBPWkVYxhPueKzUftHL fNHiU3AvKU1Nh8V5YRerKT7R8+cGigdsm299X56fbZBxAUdwfcuefPWQn/4yvdXD/9ld 4G0PsZ+VeI6thsyUhaTy9K8StkA1VUdn7g6pGCDZ5agm8NehAb7SfmcJ9TCU5zNvxUa6 Ac7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=JlCKvFLu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 192-20020a6302c9000000b00412a01e9b07si7515149pgc.847.2022.07.22.18.15.59; Fri, 22 Jul 2022 18:16:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=JlCKvFLu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236580AbiGWAwV (ORCPT + 99 others); Fri, 22 Jul 2022 20:52:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236563AbiGWAv6 (ORCPT ); Fri, 22 Jul 2022 20:51:58 -0400 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F6838CC8F for ; Fri, 22 Jul 2022 17:51:54 -0700 (PDT) Received: by mail-pj1-x1049.google.com with SMTP id c12-20020a17090a8d0c00b001f20d603777so5015796pjo.4 for ; Fri, 22 Jul 2022 17:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=RtVR2Tkco0tuXD7bLAFV7Fg1ldNSfzq0D9HUqql94JM=; b=JlCKvFLufslNPFBb2FTFua18M+4EkJnw4RZBxfm4Kn7ZqfIDkj+uEaVJRC1D4a9UuG Bqkv1vEvi8eJ1dmoYbX8sOEyx0atakWIVMTcSn6S0oS0ONdVBGxmtB35y8BtmLNFwjFM Dr33xD2jTN9GLFmWh6aYzXEADCXXw19/QpupXTlCSSLSBQTXRMF/TviTi01uQ9oaCOBy XctvQJWiXIIW50Mg0Ld6F6SIMU0KRH3EVKNWFsp0I2Pg/az3oMZnCT1w4NkdzcP1dy6h 3tOeZjPdmMnhi8hAGvyd2n1Sx4aHvDGOBBd8JInbNURIUXHQFa7BJEt1jV9lxFbaHCbs 1Stw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=RtVR2Tkco0tuXD7bLAFV7Fg1ldNSfzq0D9HUqql94JM=; b=YNjWB/PZnI1l5J59yE0OplMwpVPK8HTOaxAHHB9peDDf2N4M9Js3ZqZXEtQiKq0Af2 c6bMfkqgwAVp92LvfO8WvS0P8nBpQzdKaSer7dmjgClBYHwGQfpnTkG3WY9wBEs9/NTh GfyzCqYKZfQO5394F6gkfPTSsZebCWi6crNj13sjJr1ijFtxCqMByoP170U+rMqJVafr hU9Mr/zuhnWAw4pXVFtomyLhWyBBE+9Ba2gvpmBul6vnIGuo074Oe09ESN4aeYulxJZY d1jmnyxDQXEjQl9+LVcYo8e6uqlLdxr5gXSqXTM9O7KklDfWFQF7VbNnqoi5/LWoAiFV KVUA== X-Gm-Message-State: AJIora/7ivnC14nFxNdnYwECBaFYcCFlLJr3TRy9RrmlIL0z0CTrsXVj LXI9Ph5Fh9vxSVSOzsWEZDpGFutuqJg= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90b:4c08:b0:1f2:977:c147 with SMTP id na8-20020a17090b4c0800b001f20977c147mr20329213pjb.6.1658537513521; Fri, 22 Jul 2022 17:51:53 -0700 (PDT) Reply-To: Sean Christopherson Date: Sat, 23 Jul 2022 00:51:20 +0000 In-Reply-To: <20220723005137.1649592-1-seanjc@google.com> Message-Id: <20220723005137.1649592-8-seanjc@google.com> Mime-Version: 1.0 References: <20220723005137.1649592-1-seanjc@google.com> X-Mailer: git-send-email 2.37.1.359.gd136c6c3e2-goog Subject: [PATCH v4 07/24] KVM: x86: Use DR7_GD macro instead of open coding check in emulator From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Jim Mattson , Maxim Levitsky , Oliver Upton , Peter Shier Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use DR7_GD in the emulator instead of open coding the check, and drop a comically wrong comment. Signed-off-by: Sean Christopherson Reviewed-by: Maxim Levitsky --- arch/x86/kvm/emulate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index bd9e9c5627d0..fdeccf446b28 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -4181,8 +4181,7 @@ static int check_dr7_gd(struct x86_emulate_ctxt *ctxt) ctxt->ops->get_dr(ctxt, 7, &dr7); - /* Check if DR7.Global_Enable is set */ - return dr7 & (1 << 13); + return dr7 & DR7_GD; } static int check_dr_read(struct x86_emulate_ctxt *ctxt) -- 2.37.1.359.gd136c6c3e2-goog