Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp1286676imi; Sat, 23 Jul 2022 00:42:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sPQO+W6dNDes9V2GzkcVmb4Lzi5vBS6P/oyjUZGuBM8KD1DIPar0e2dSIezrqy0hbIpLy7 X-Received: by 2002:a63:7849:0:b0:41a:3c3:90b8 with SMTP id t70-20020a637849000000b0041a03c390b8mr2938552pgc.265.1658562178420; Sat, 23 Jul 2022 00:42:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658562178; cv=none; d=google.com; s=arc-20160816; b=kbySE5DDAKZO7qDagPIH89qSvvRSQA1cgCb7pGC08Y8U70zusAVr6iS+FUrFPQPuTV TaI/0kCL8qGm32EQ+S6MdhcYFHtRSXJNe0yC+0moeNsBM4W+HiS4kI80YBezIqqw3WYT vJ2ZI/Zn3NUp0GOIBoUhEBuaKfq0QaNhGZ5ue/Eqz7+mtl3O33yNqXHEQFAdVp+Id6tR TReHallSDB1j+9VvyVwAsqqnZzAW2x/LwMeXxL9lOPLlnnq+dO4tb9zTNsKm+WHDyBvM znd2hHKX77TxFYtdPye0bgC7tBzqXzoSFxdtSEMJl8objplUhECr473JrsxtMW+uuMBO 2cJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=HpTtq1kwgOWGRwuUaoSk1q8RIxb81691UT35EXAh9N4=; b=fOAPsPtFKutRpBGkhuFt2HCBfIQXL/kQz6ANHAO43zp9yepFC8dOKKalzmzF1eu47Q QmANa/T+8d1mIgU6J5FXVXpyar/cJNeRoOUNCR+sjgc5zqJIL9D1P7Z22qh2Rmo4DhVS z7z1M+WR3DKC5ZYKRR5Q+q7chHQN9bFLxh4HvtZgyo3BRxM8fEGafBWu7fpJoS6MdKVh qpt46Vo/9Gc9s+V2EUwy/6OXSC/pIFGzyHyLxqtycbbhtVzTNNkEOBxyNfurYJStvl90 hhjhvY/0TQ4z6onmbqjK50yTXNUMRQnd0TPGS4yTMtD1h8dBFEYubju4m2QYAoOytBuR myQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kk17-20020a17090b4a1100b001f06deff0afsi14500338pjb.82.2022.07.23.00.42.43; Sat, 23 Jul 2022 00:42:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236792AbiGWHiW (ORCPT + 99 others); Sat, 23 Jul 2022 03:38:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229708AbiGWHiU (ORCPT ); Sat, 23 Jul 2022 03:38:20 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E937165A9 for ; Sat, 23 Jul 2022 00:38:19 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LqdRq25n1zGp8s; Sat, 23 Jul 2022 15:37:11 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 23 Jul 2022 15:38:16 +0800 From: Miaohe Lin To: CC: , , , , , , Subject: [PATCH] hugetlb_cgroup: fix wrong hugetlb cgroup numa stat Date: Sat, 23 Jul 2022 15:38:04 +0800 Message-ID: <20220723073804.53035-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We forget to set cft->private for numa stat file. As a result, numa stat of hstates[0] is always showed for all hstates. Encode the hstates index into cft->private to fix this issue. Fixes: f47761999052 ("hugetlb: add hugetlb.*.numa_stat file") Signed-off-by: Miaohe Lin --- mm/hugetlb_cgroup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c index f9942841df18..c86691c431fd 100644 --- a/mm/hugetlb_cgroup.c +++ b/mm/hugetlb_cgroup.c @@ -772,6 +772,7 @@ static void __init __hugetlb_cgroup_file_dfl_init(int idx) /* Add the numa stat file */ cft = &h->cgroup_files_dfl[6]; snprintf(cft->name, MAX_CFTYPE_NAME, "%s.numa_stat", buf); + cft->private = MEMFILE_PRIVATE(idx, 0); cft->seq_show = hugetlb_cgroup_read_numa_stat; cft->flags = CFTYPE_NOT_ON_ROOT; -- 2.23.0