Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp1368792imi; Sat, 23 Jul 2022 03:54:24 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tpr2/WlncuMT/lJy/ws5Aj0ItFvTbolEPUOcRnRYf7iW1uHfj8qndu0Kn+yUMzcMz6Sk7G X-Received: by 2002:a17:907:2cf5:b0:72b:7656:f162 with SMTP id hz21-20020a1709072cf500b0072b7656f162mr2936135ejc.565.1658573663717; Sat, 23 Jul 2022 03:54:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658573663; cv=none; d=google.com; s=arc-20160816; b=hMeYWwyBUDTJqfxLPrOkHP+TFvfxHeJsmAyk/OzEyjrvhBhn5LGzLSGqVnrbAt1ff5 acayPr75HdtnhnckcCf8w790+oeKfbExzh2/tTNVWwhdiFfr6VR06siX4DqC9FMxtgS9 9kWFKshw5dpcchwVrgsqpvfgUArzvNiOWBPn8d/YtgGHT7kvI6AzW+LMTkG5zUWgLNGI XeNmkYc94eka6v2BkysLlqP19hyt3c/yXMbwY1VNxteTnO2bnhC7UhaAngEu0YQcdnKx 6/uivSQ3818g8w1HfcTADo0ZFfZCxyZcIfg9CEKe0sEKedQBj2nPZJZ8aILIkUU0VpJC 271g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=b1BVafOAk45YqVPRpHM5cAQFPWb/GSd6jJ7wqS1ZN38=; b=yfqpG39P68VEzgq2OofbPoOP5Bn5zTCHGmj0NWSVZiLt9uKgDnPAQ4c77fwOlrGwnb lvxy9M3YtsmlFuTJfo8qIUqzLlc9l14nRUezDE+qsDVnsAEjvgppLJmcZ9aLKhnZnvrr R7N/8IJcqyVJjVqr2lPQ9vQmtZWS6B/FJPEvL3WVr11LQbIT2DQakcVlBq8nH6L3ddHJ 4aIcOJVj/8SPJw7BxDxVT3CchwfqnBPsR76huMB0XOMJ0oG7kf7V2AoMMoil6VE7guk7 q+w7P0DRlKk9E6La9+Lp3c8UQpR3zKJIPorqGUiR1BqO3vEO/I3JbBzHaQaG2pF3cqi2 umXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YKTx3NRe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sg32-20020a170907a42000b00722e7e8b484si4445955ejc.625.2022.07.23.03.53.57; Sat, 23 Jul 2022 03:54:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YKTx3NRe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237812AbiGWKBY (ORCPT + 99 others); Sat, 23 Jul 2022 06:01:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237888AbiGWKAX (ORCPT ); Sat, 23 Jul 2022 06:00:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 197AE785B1; Sat, 23 Jul 2022 02:58:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5764C611BD; Sat, 23 Jul 2022 09:58:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 690C5C341C0; Sat, 23 Jul 2022 09:58:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658570303; bh=b3T8UY6FZP2wcxf8N/fTReXZewBuYrszqPfDeP+Iw4Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YKTx3NReB94/BFtQmE/WZ7MMImvZ48fBtQCmwNnd69Tzea9tbbHKU4zLw7t3QuP4/ 3fL/n6S8HHhkXu3N4KVy/kWv660iZlxthlp49c/GQohjNgxkrqXn78cIH1pWLsw9Ol 5RLMqecUuwcaQOxDJgsl2or59OdaMTKWgweMCYSc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Peter Zijlstra (Intel)" , Ingo Molnar , Ben Hutchings Subject: [PATCH 5.10 039/148] objtool/x86: Ignore __x86_indirect_alt_* symbols Date: Sat, 23 Jul 2022 11:54:11 +0200 Message-Id: <20220723095235.268633228@linuxfoundation.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220723095224.302504400@linuxfoundation.org> References: <20220723095224.302504400@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra commit 31197d3a0f1caeb60fb01f6755e28347e4f44037 upstream. Because the __x86_indirect_alt* symbols are just that, objtool will try and validate them as regular symbols, instead of the alternative replacements that they are. This goes sideways for FRAME_POINTER=y builds; which generate a fair amount of warnings. Fixes: 9bc0bb50727c ("objtool/x86: Rewrite retpoline thunk calls") Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ingo Molnar Link: https://lore.kernel.org/r/YNCgxwLBiK9wclYJ@hirez.programming.kicks-ass.net Signed-off-by: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- arch/x86/lib/retpoline.S | 4 ++++ 1 file changed, 4 insertions(+) --- a/arch/x86/lib/retpoline.S +++ b/arch/x86/lib/retpoline.S @@ -58,12 +58,16 @@ SYM_FUNC_START_NOALIGN(__x86_indirect_al 2: .skip 5-(2b-1b), 0x90 SYM_FUNC_END(__x86_indirect_alt_call_\reg) +STACK_FRAME_NON_STANDARD(__x86_indirect_alt_call_\reg) + SYM_FUNC_START_NOALIGN(__x86_indirect_alt_jmp_\reg) ANNOTATE_RETPOLINE_SAFE 1: jmp *%\reg 2: .skip 5-(2b-1b), 0x90 SYM_FUNC_END(__x86_indirect_alt_jmp_\reg) +STACK_FRAME_NON_STANDARD(__x86_indirect_alt_jmp_\reg) + .endm /*