Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <53b307a3-67e0-2acd-5d4a-0970f717afa7@wanadoo.fr>
Date:   Sat, 23 Jul 2022 12:49:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 4/7] spi: a3700: support BE for AC5 SPI driver
Content-Language: en-US
To:     vadym.kochan@plvision.eu
Cc:     broonie@kernel.org, enachman@marvell.com,
        linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
        lnoam@marvell.com
References: <20220723102237.10281-1-vadym.kochan@plvision.eu>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <20220723102237.10281-1-vadym.kochan@plvision.eu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 23/07/2022 à 12:22, Vadym Kochan a écrit :
> From: Noam <lnoam-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
> 
> Tested-by: Raz Adashi <raza-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
> Reviewed-by: Raz Adashi <raza-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Vadym Kochan <vadym.kochan-Nq3fbkz6jlnsq35pWSNszA@public.gmane.org>
> ---
>   drivers/spi/spi-armada-3700.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c
> index d8cc4b270644..386c7959ea93 100644
> --- a/drivers/spi/spi-armada-3700.c
> +++ b/drivers/spi/spi-armada-3700.c
> @@ -497,7 +497,7 @@ static int a3700_spi_fifo_write(struct a3700_spi *a3700_spi)
>   
>   	while (!a3700_is_wfifo_full(a3700_spi) && a3700_spi->buf_len) {
>   		val = *(u32 *)a3700_spi->tx_buf;
> -		spireg_write(a3700_spi, A3700_SPI_DATA_OUT_REG, val);
> +		spireg_write(a3700_spi, A3700_SPI_DATA_OUT_REG, cpu_to_le32(val));
>   		a3700_spi->buf_len -= 4;
>   		a3700_spi->tx_buf += 4;
>   	}
> @@ -519,7 +519,7 @@ static int a3700_spi_fifo_read(struct a3700_spi *a3700_spi)
>   	while (!a3700_is_rfifo_empty(a3700_spi) && a3700_spi->buf_len) {
>   		val = spireg_read(a3700_spi, A3700_SPI_DATA_IN_REG);
>   		if (a3700_spi->buf_len >= 4) {
> -
> +			val = cpu_to_le32(val);

Hi,

even if both should generate the same code, should'nt this be le32_to_cpu()?

CJ

>   			memcpy(a3700_spi->rx_buf, &val, 4);
>   
>   			a3700_spi->buf_len -= 4;