Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp1471880imi; Sat, 23 Jul 2022 06:47:20 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uWLphaYQwXRXgavlQsHMZXEbIo/1UD0heqgpXuU3tM4b3ewDMfQxmFVTtU4N/1reRTORWC X-Received: by 2002:a17:907:96a1:b0:72b:918c:13f with SMTP id hd33-20020a17090796a100b0072b918c013fmr3672231ejc.659.1658584039933; Sat, 23 Jul 2022 06:47:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658584039; cv=none; d=google.com; s=arc-20160816; b=f6cJWRiMTjwQOIIKp+0B/tqKYKgh85GmoYoH2GxJn9WBawWuMBl5ebv30r9QjAL9/P U/RCMEilSH01cTsq3xsgcr6RUI9fPdeuo/i4UXdunIvTTKxfQ/cKbBIlj+572cnvp81M /3NXIcln4VbOs588Yv7jisB50tFMnnWYhLvi8g3BrZAIMeG13+fk+/wlZPiagiFSXwDp 07F5jhPhypOXCESxvnNsRxH674cIN1wS9r5grcwglOzuZlywQinY27eOfmAwrou852lX ZBAMUfbcN0/9CPwit5sVRuRkhDRRfu+E1NP29jfcINzelPiVIEYXNvXhNDteyi31v3hy ysyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hnotxB5Oc/VX76n20x9nu1HrRcKDV9PdbZM9OhqtA6E=; b=I6XYLki9ilZWpfLGdbw/Ue9p1v7jm66tnskMVgq9AnLKbuDezebYIQtsZxk25jopYg gHSC47Z+Qa82hybVhgNV8THm7NlXadEXMSVxthgVGfeAQZxwkaTKOr+YGSYEPSGmZlcN w0J/Vn9xGmNXy65mmFrNdFpnQhOlFwCANg1Q77mdqf8H8BxR7zmkILNPVYqLH3RXVeBw bHINwaat3TDw+cg5fx6jK4sY9Gw97i7AY1a3PXrwUn7W+bvwPe1RWTBREFyH5G/fMa42 n6GQKQz9MQeIpg62lAnj0EoX24gN3tkeCYw2NfOqu5hWDEbmZbn22RqqVC549/16Aktp BVJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=7x827hbe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c11-20020a17090603cb00b00726dbafec2asi7615630eja.446.2022.07.23.06.46.54; Sat, 23 Jul 2022 06:47:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=7x827hbe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235971AbiGWNon (ORCPT + 99 others); Sat, 23 Jul 2022 09:44:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234852AbiGWNom (ORCPT ); Sat, 23 Jul 2022 09:44:42 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9210321E39 for ; Sat, 23 Jul 2022 06:44:41 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id ku18so6590684pjb.2 for ; Sat, 23 Jul 2022 06:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hnotxB5Oc/VX76n20x9nu1HrRcKDV9PdbZM9OhqtA6E=; b=7x827hbe8Wo6IMCLX1aASTMVo7iqsQtSjbd8ValONvs5byHdPFPMxAODQ72v7MUgaf MCPCCG66FBCOih/OZMsNNrwv5y72zJ2zeoI6EyXsPes3675nkmYtNXyl5MjyBxDO5xYM d024O9atQocQ3j+MbfCBMVgnDCyhp6KNg85LLwHh7uX33e08itMbuv/wmL1FDGb668AT ddCsQIjWeIK8tNVmXGi4xZcOK5NIJmDvOuFJfBy6TEYcCQ86pM+0WbMl0D9PBWdlFPXv JgJvlEdCN7J8TDtmDP79jtCRWpBZadrduObH/R4GF1asFedqnZ/4WBReND59uHVv9tQJ Gi2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hnotxB5Oc/VX76n20x9nu1HrRcKDV9PdbZM9OhqtA6E=; b=ppHKQnqwPXaMKMSQJaLTmRSVD0iWe/O/lDljFLq6ZMOKlcAgXNOnEmQk/820WVrO4+ zDKf0JvFZd/YTQlsq8O2VBWPhs2djbpJYZQDYOx8Y5jtvOZPUl05HnINIKpNSKaYDeOl hqFKhCOmfoawgtv7i981atl3rmY60LaMZ2LEs+oMFHLmUvM3Qk72ZH6BjH2T7kx67P0y UiMXu/rte51VK0yNXkdYmx3b+BUA7lQUJoJpRtWAH9Y89LzfYgfekyV0s6cEHEKq57qV Hv+4TjOCuF6FYuIzbgtTlfYH9iqOyCFkxtQrEouSleQMtCD1gitR1Ldj6fo8Hq/NfMCk iskg== X-Gm-Message-State: AJIora/3XjHVlQbx0ZEtHsU76tBUaRjG94NxY4U7YOq1gXG4BNrGgRoM ZvVPSoEgx8FlAuWZtNgoxeHSOg== X-Received: by 2002:a17:903:41c1:b0:16d:59d9:2bae with SMTP id u1-20020a17090341c100b0016d59d92baemr1882187ple.49.1658583881044; Sat, 23 Jul 2022 06:44:41 -0700 (PDT) Received: from localhost ([139.177.225.241]) by smtp.gmail.com with ESMTPSA id w205-20020a627bd6000000b005286697ec68sm5901700pfc.133.2022.07.23.06.44.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Jul 2022 06:44:40 -0700 (PDT) Date: Sat, 23 Jul 2022 21:44:35 +0800 From: Muchun Song To: Miaohe Lin Cc: akpm@linux-foundation.org, keescook@chromium.org, mike.kravetz@oracle.com, almasrymina@google.com, shakeelb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hugetlb_cgroup: fix wrong hugetlb cgroup numa stat Message-ID: References: <20220723073804.53035-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220723073804.53035-1-linmiaohe@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 23, 2022 at 03:38:04PM +0800, Miaohe Lin wrote: > We forget to set cft->private for numa stat file. As a result, numa stat > of hstates[0] is always showed for all hstates. Encode the hstates index > into cft->private to fix this issue. > > Fixes: f47761999052 ("hugetlb: add hugetlb.*.numa_stat file") > Signed-off-by: Miaohe Lin Thanks for fixing this. Acked-by: Muchun Song