Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 23 Jul 2022 11:15:12 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org,
        Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: Re: [PATCH v10 05/12] iommu: Add IOMMU SVA domain support
Message-ID: <20220723141512.GE79279@nvidia.com>
References: <20220705050710.2887204-1-baolu.lu@linux.intel.com>
 <20220705050710.2887204-6-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220705050710.2887204-6-baolu.lu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xz7n0YqVXLR5+vxZP+CRIPStzwzDNllPVBd6rn/0HU73N8+uZLSwKd6pSfda?=
 =?us-ascii?Q?2pctjw4dJLRRQJNBmk1pjUf+bG7HevLHGf652nYBh/qyV1f+enPQcsaHQgei?=
 =?us-ascii?Q?oFbbDeA1bm12EzYhIjF3RvhfHMV7YV2fh3+0v5P++rDwL5eqzHE7qPZPO2H0?=
 =?us-ascii?Q?4Ee35c8bo9xMjeYvRw7F/LqdcnVtiBStwLRAkn7y5r7+H4CjlVo/2WNMDQHu?=
 =?us-ascii?Q?z3l/oec4Hkw+2z4LeLlDnrD9BkYK/8OINYVgSjV2ZRV+yJA8FOB3/MUep4O5?=
 =?us-ascii?Q?fCNsN4ELD4am4lLQ04sCT3Oy9CjGTs5YwtBy3z9WeooNB10kxdWfMAo4CfiH?=
 =?us-ascii?Q?i9p68Z/MtU3H3jlGCqbwZiS4YvTiP9WYZzDUsmPf2DH+IIP6ykGATbcb9UeO?=
 =?us-ascii?Q?G9+SMfnQNqhFuvcdwcDvaYwrTWq1TZdLedqTvRh4Vtci+97PuaNyQQ48/g3J?=
 =?us-ascii?Q?OkRL0m8kSoaFtROc0Vr2i6ARl3IX9JpXH8wUqJfwj28/M8ygggykH1eJJ79z?=
 =?us-ascii?Q?3G6i/oQFSwsF/K9rF1mHVvuZrWJx8/a0T4HVpbhWdpXUu8QbCYYdX5Sd79Xk?=
 =?us-ascii?Q?y3NBZJ/39WHMukh7BV0loyayg8KLSTIs6v5WZYSf0KDVGXyMAT9ePn0cCWpv?=
 =?us-ascii?Q?N2BQ0dgLXvcz1zyuGsFeIGK3as/CH18uZN6WaOzVe/sIy0ZH7A5SmWK8fsuK?=
 =?us-ascii?Q?BAs7Fjl351oirTcsKB4NI9bBchfGpgQz3KQ12aCItu7Od6QOYCIgfiodQzmT?=
 =?us-ascii?Q?siigOXtH8w6kOcSewSl9aHLehLA1AW7mT99+EcaEDro7Wfi+KnP1ti7segre?=
 =?us-ascii?Q?fOakWOAQy1EkWCzs39mE7z8WyAT86T6yOHyHyifenPpekgja6Fq5cz0t0TzY?=
 =?us-ascii?Q?qDVO8wdpuXVXIhFLkOjz6bvDT/JeYjl/qQ0AQkCiKi/XqHPNXW5zjTDvbIVA?=
 =?us-ascii?Q?yn7JgAUNJWaYsd2366nZDwkisPuEF9DyF8GamFPKNIQQSk1EmX5ERDaYsDz9?=
 =?us-ascii?Q?uJT44GfttyOA1ueqrs12Mc5+JKJngvnTl6p9ydSZAPNYndR2GOMY2dlw0Djy?=
 =?us-ascii?Q?KZ26LmM8IkPp4CJPx5plDbCfoSasYkOHZYZ1gvvWO3li+3MHiW+8+4koWB88?=
 =?us-ascii?Q?8kLV6eax/1pReAX7wA3n7d0/VysxgNDqbl/iW3Y0kekKVYs0k4y7TGEKzpbT?=
 =?us-ascii?Q?6ar0HBZaqI0qV/Eaidur47XETfVKD95VyaUL3SYEO/GsjM5ohyCRF/s5TCMI?=
 =?us-ascii?Q?0jL1gRy1QfTk46ZshL3wE9zbz2rz8jzmYtcjRhPi18yj3sRzqXy/mpRZl69x?=
 =?us-ascii?Q?OCBCX7pfrdEv846Oh/+XopT9Ud8FhdFbACrDNw9Tnw1p/VIPKBQ19oUISx2e?=
 =?us-ascii?Q?IGeRdc/5HJCLV1nwuyQXb+ET3m6E6EGM3e8xGxAhamiV36qdJBGU8yPD2S7d?=
 =?us-ascii?Q?TWQCaD/Fj14ZPLC7Ifld21E9QzkzgF4MivQ9aCN2mGelWhk9Ij+7HotaLhat?=
 =?us-ascii?Q?OhxZ3yUMflCHFq5TR8V0FSMyBe9MQnNJAlpTYw8wcnSn5ZOkR3hCs9kBY8ig?=
 =?us-ascii?Q?abmjCVa4KMXU+dpjr6rZfexnMUr5PrZgcavY8Zvc?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88abd1a4-7f93-4399-7615-08da6cb5c36d
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2022 14:15:15.0894
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bxb2ijhSPFPysTJioXTH8WVMdo/7aUyt6LuDlpSW/1UaxaE0UZ7RIl94rjQpIuhY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3308
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 05, 2022 at 01:07:03PM +0800, Lu Baolu wrote:
> The sva iommu_domain represents a hardware pagetable that the IOMMU
> hardware could use for SVA translation. This adds some infrastructure
> to support SVA domain in the iommu common layer. It includes:
> 
> - Extend the iommu_domain to support a new IOMMU_DOMAIN_SVA domain
>   type. The IOMMU drivers that support allocation of the SVA domain
>   should provide its own sva domain specific iommu_domain_ops.
> - Add a helper to allocate an SVA domain. The iommu_domain_free()
>   is still used to free an SVA domain.
> 
> The report_iommu_fault() should be replaced by the new
> iommu_report_device_fault(). Leave the existing fault handler with the
> existing users and the newly added SVA members excludes it.
> 
> Suggested-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Tested-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> Tested-by: Tony Zhu <tony.zhu@intel.com>
> ---
>  include/linux/iommu.h | 24 ++++++++++++++++++++++--
>  drivers/iommu/iommu.c | 20 ++++++++++++++++++++
>  2 files changed, 42 insertions(+), 2 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason