Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp1533014imi; Sat, 23 Jul 2022 08:34:48 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ual0zqjIy5NgXd9wXHGn2Llo3SgbZ+DTXzbkqmjXjMigbcVuBGuWRb4WE0mhmYi2weo46c X-Received: by 2002:a17:90b:3e84:b0:1f0:3f92:8c91 with SMTP id rj4-20020a17090b3e8400b001f03f928c91mr24163468pjb.112.1658590488306; Sat, 23 Jul 2022 08:34:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1658590488; cv=pass; d=google.com; s=arc-20160816; b=At/h0bWMirQK4/zw2X673+4J2m1JYiKFRT/kAIqFgkkF5vwZUXTL2+97ayPv5hiaUT jKExTnCcG27nU43e9Dh2vK3jk7dA6+JTgHK9D1vSYBw2N8PlSnbsOQb9q5yBrfChnuDL xdLWWEfd3fAiJaFgLbBulAU2O97B7O39gFy80+bex7PnTkBR3q6AgfqCQx018UYnKBQ4 VBENx0ozQI3pt7FejGE6ncqTpbSZAuF6PLspOapO9RFcnxzi4bAwo5KYAmO5/vCCJdC6 wxOMb8ZDZs3vz5teUb7BzfIpsmBX8Ni+c2anE40Fce/Y9wTOea2O5JRfPppMpwCOefMB S3Dg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:importance:content-transfer-encoding :mime-version:subject:references:in-reply-to:message-id:cc:to:from :date:dkim-signature; bh=QUHKy4OgEaxbVLogauALC7ife9v5t5FcKwUzAh8eIRk=; b=EMxcHgdghg/LK2uBknKlrq/V7RPci/136u6+sTRX6zKVSZi3BrZfF20VaS3IUlVR7Y y3CuZUEoYtYBlWsd46tFuUx2q7SaVmEicpHiHW9jpPbOE55/DRHx7ICwfA+oTaG3/nCp ZZf/7shOXy/a4XYnR+2KNjI/1TibRB/2P0+jTjW8VYgkpOVjZ/iiT29jESHkuZLrYZ/J b1h//Wgf01BYE5d2twEtGpOlKEIKMstsuAzi6H/1ARnYZSjggTdxydis/cru//4WWwyW oNgRe0WaGejXVb1ueaj+oWGviR+Pw2U+l477mvkim1JHP772b8GlMJ9la/VFWgMHUwsD RcPw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@siddh.me header.s=zmail header.b=AX7PeCKi; arc=pass (i=1 spf=pass spfdomain=siddh.me dkim=pass dkdomain=siddh.me dmarc=pass fromdomain=siddh.me>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siddh.me Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r5-20020a170902c7c500b0016c4f0065d4si7601248pla.590.2022.07.23.08.34.32; Sat, 23 Jul 2022 08:34:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@siddh.me header.s=zmail header.b=AX7PeCKi; arc=pass (i=1 spf=pass spfdomain=siddh.me dkim=pass dkdomain=siddh.me dmarc=pass fromdomain=siddh.me>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siddh.me Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237513AbiGWP3B (ORCPT + 99 others); Sat, 23 Jul 2022 11:29:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237315AbiGWP27 (ORCPT ); Sat, 23 Jul 2022 11:28:59 -0400 Received: from sender-of-o53.zoho.in (sender-of-o53.zoho.in [103.117.158.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2532A1572F; Sat, 23 Jul 2022 08:28:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658590106; cv=none; d=zohomail.in; s=zohoarc; b=Lyjuq3kiDlanKDvP/FngdV62QpvsxmDaU5Bf+c3GbUalfmW6ZEWpY05vprmkOb4UKS1qt9ui3VWDaJHnbOE5c/Ws2a8QSNyl0bCZvnL7e0A3xHSK3iCcY/I81QtLtdZNctgc6wJI/7yZsTiROcQxouOXIsTPTQJvxzSTT+dpVbM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.in; s=zohoarc; t=1658590106; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=QUHKy4OgEaxbVLogauALC7ife9v5t5FcKwUzAh8eIRk=; b=d8O36cgk9f1UBst/XKKzVWaBE4ME9VwSVq+41afy41XVED9ZLZrF9mRmn80zvSHR3nK32RNEoDz6j4UPV0Kb3K7Cy0g6aQlmJgKl9zLhl8HGccPL9G27/yLAnMH6ZNgCHtZXgZOtZHG7rIrNuNZs+uPhCO4HQ00IzVifsYwENcI= ARC-Authentication-Results: i=1; mx.zohomail.in; dkim=pass header.i=siddh.me; spf=pass smtp.mailfrom=code@siddh.me; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658590106; s=zmail; d=siddh.me; i=code@siddh.me; h=Date:Date:From:From:To:To:Cc:Cc:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=QUHKy4OgEaxbVLogauALC7ife9v5t5FcKwUzAh8eIRk=; b=AX7PeCKipWcL4pk8J9TO01kdzl+FTf3hwvGlt+7TUbONwtwX2oQ4FVcUxIkFRrnp 95+19S3rjYI8FzxWHoruMEhjExplwoKmgzCItwqK8hXj2lryYStue6oE1zPGifkDdXB Nmece5GqZ/d/8lyQkNlSscw9ZzenEB8oS+K38+bk= Received: from mail.zoho.in by mx.zoho.in with SMTP id 1658590095403354.57172593740086; Sat, 23 Jul 2022 20:58:15 +0530 (IST) Date: Sat, 23 Jul 2022 20:58:15 +0530 From: Siddh Raman Pant To: "James Bottomley" Cc: "Greg KH" , "David Howells" , "Jarkko Sakkinen" , "James Morris" , "Serge E. Hallyn" , "linux-security-modules" , "keyrings" , "linux-kernel-mentees" , "linux-kernel" Message-ID: <1822bac680f.53b862f8236953.7679004564726067655@siddh.me> In-Reply-To: References: <20220723135035.199188-1-code@siddh.me> <1822b7c129a.14411444236159.6380883938307880248@siddh.me> Subject: Re: [PATCH] keys/keyctl: Use kfree_rcu instead of kfree MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 23 Jul 2022 20:20:49 +0530 James Bottomley wrote: > That doesn't apply in this case, does it? watch and wlist are locally > allocated and neither has been made externally visible if the error leg > is taken, so they should just be locally freed, which is what the code > was doing before this proposed patch. You are correct. Sorry for this, I should have looked at it for a tad bit more. Thanks, Siddh