Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761833AbXFDUGS (ORCPT ); Mon, 4 Jun 2007 16:06:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756573AbXFDUGH (ORCPT ); Mon, 4 Jun 2007 16:06:07 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:53680 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760236AbXFDUGF (ORCPT ); Mon, 4 Jun 2007 16:06:05 -0400 Date: Mon, 4 Jun 2007 22:06:06 +0200 From: Adrian Bunk To: Nitin Gupta Cc: Richard Purdie , Daniel Hazelton , akpm , LKML , Hugh Dickins , Nick Piggin , David Woodhouse Subject: Re: [PATCH -mm 0/5] LZO and swap write failure patches for -mm Message-ID: <20070604200606.GA5500@stusta.de> References: <1180971378.6313.72.camel@localhost.localdomain> <200706041214.38017.dhazelton@enter.net> <1180975976.6313.133.camel@localhost.localdomain> <4cefeab80706041126y5f12402cl61b72ec101dd7915@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4cefeab80706041126y5f12402cl61b72ec101dd7915@mail.gmail.com> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1275 Lines: 41 On Mon, Jun 04, 2007 at 11:56:46PM +0530, Nitin Gupta wrote: > On 6/4/07, Richard Purdie wrote: >... >> The zlib code isn't kernel style and is arguably bloated, perhaps we >> should remove that? > > I don't know - I don't use zlib. > We can make LZO cleaner and perhaps faster. This will be good. >... "cleaner" = much harder to upgrade to new upstream LZO versions -> bad "perhaps faster" = different from the well-known original code and might again contain new bugs -> bad "perhaps faster" = if we fork LZO and actually get it faster, all the other LZO users will not benefit -> bad zlib and LZO are special because they are maintained userspace code imported into the kernel. > Regards, > Nitin cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/