Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 23 Jul 2022 09:16:00 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Vikas Gupta <vikas.gupta@broadcom.com>
Cc:     jiri@nvidia.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, davem@davemloft.net,
        dsahern@kernel.org, stephen@networkplumber.org,
        edumazet@google.com, pabeni@redhat.com, ast@kernel.org,
        leon@kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net,
        michael.chan@broadcom.com, andrew.gospodarek@broadcom.com
Subject: Re: [PATCH net-next v6 1/2] devlink: introduce framework for
 selftests
Message-ID: <20220723091600.1277e903@kernel.org>
In-Reply-To: <20220723042206.8104-2-vikas.gupta@broadcom.com>
References: <20220723042206.8104-1-vikas.gupta@broadcom.com>
        <20220723042206.8104-2-vikas.gupta@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 23 Jul 2022 09:52:05 +0530 Vikas Gupta wrote:
> +enum devlink_attr_selftest_test_id {
> +	DEVLINK_ATTR_SELFTEST_TEST_ID_UNSPEC,
> +	DEVLINK_ATTR_SELFTEST_TEST_ID_FLASH,	/* flag */
> +
> +	__DEVLINK_ATTR_SELFTEST_TEST_ID_MAX,
> +	DEVLINK_ATTR_SELFTEST_TEST_ID_MAX = __DEVLINK_ATTR_SELFTEST_TEST_ID_MAX - 1
> +};
> +
> +enum devlink_selftest_test_status {
> +	DEVLINK_SELFTEST_TEST_STATUS_SKIP,
> +	DEVLINK_SELFTEST_TEST_STATUS_PASS,
> +	DEVLINK_SELFTEST_TEST_STATUS_FAIL
> +};
> +
> +enum devlink_attr_selftest_result {
> +	DEVLINK_ATTR_SELFTEST_RESULT_UNSPEC,
> +	DEVLINK_ATTR_SELFTEST_RESULT,			/* nested */
> +	DEVLINK_ATTR_SELFTEST_RESULT_TEST_ID,		/* u32,
> +							 * enum devlink_attr_selftest_test_id
> +							 */
> +	DEVLINK_ATTR_SELFTEST_RESULT_TEST_STATUS,	/* u8,
> +							 * enum devlink_selftest_test_status
> +							 */
> +
> +	__DEVLINK_ATTR_SELFTEST_RESULT_MAX,
> +	DEVLINK_ATTR_SELFTEST_RESULT_MAX = __DEVLINK_ATTR_SELFTEST_RESULT_MAX - 1

Any thoughts on running:

	sed -i '/_SELFTEST/ {s/_TEST_/_/g}' $patch

on this patch? For example DEVLINK_ATTR_SELFTEST_RESULT_TEST_STATUS
is 40 characters long, ain't nobody typing that, and _TEST is repeated..

Otherwise LGTM!