Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <quic_cang@quicinc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
        "quic_ziqichen@quicinc.com" <quic_ziqichen@quicinc.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>
CC:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Daejun Park <daejun7.park@samsung.com>,
        Jinyoung Choi <j-young.choi@samsung.com>,
        Kiwoong Kim <kwmad.kim@samsung.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
Thread-Topic: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
Thread-Index: AQHYmz2OvInxSH8TlUq8qOHvad4nHq2MbQiA
Date:   Sat, 23 Jul 2022 20:22:58 +0000
Message-ID: <DM6PR04MB65756C2EF5D9F23B5EC9E3A7FC939@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <1658214120-22772-1-git-send-email-quic_cang@quicinc.com>
 <1658214120-22772-2-git-send-email-quic_cang@quicinc.com>
In-Reply-To: <1658214120-22772-2-git-send-email-quic_cang@quicinc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Pft6JTTsGepDZOjxbBpbt8p0r7pW1x2rEZFyIZym+W+r7Kk4v5p8zxZOAZPR?=
 =?us-ascii?Q?mORQFZovBaad4E5lFZLIaovj7uK6swoRChfu62SQ6Q5e68qWI52/FIqAMppP?=
 =?us-ascii?Q?eV80P1EfcOAktUp8ZaYVb7xmaOm6pRSdFerpi5lQYHuN3fvFWM4mnSoNUgC9?=
 =?us-ascii?Q?8ZT900Bpc54RD+ldma1NQQkACWGkiColW9L1dEUqtn+01jxj7JVpwZsA956/?=
 =?us-ascii?Q?yNhjNfg38+p4IKgD1E2PEIrgFB/RlS20UUGO8i+9Q+0Eo9vvVQ/4NKJHajh5?=
 =?us-ascii?Q?kOrYaNvTe5s2yXnsRDzhRwBHMMCz5z4NxyM/2zPmNdH1rV/FGZY//6+d3hWz?=
 =?us-ascii?Q?XFaOWfLk9edLgtRLZ9YOlUhZWw3TCJkKp/NqfZyZJrEpeYgtA9nN+aVICx3q?=
 =?us-ascii?Q?NJHRWBBj+JUfKJuHtqM3Nv1nGgHU6d1aSf7qXIBMJNTjU3fhik2RFL1Qa3Am?=
 =?us-ascii?Q?30/ndRIy4t9hzBgze4BdeFZB/bzXUokCie/PWldtQZjFZ4gw+ZgreR3GZSE8?=
 =?us-ascii?Q?ntBzm3h37L00U0Ik8WYPIcP/49vAudQ7Aqa0YV5B/gKcgKSNp6T9Y2YoAxfs?=
 =?us-ascii?Q?ovRp6RYWQFgX4ElcjvOcEVmaaFJ37DwpR7snpamW7M7jWLNaTzaQuSM394Eb?=
 =?us-ascii?Q?iPvRKI2faN2TJrCERRglTkzySDZNfXRuVWcu6CqSChggoosZo39KKGnBvbvI?=
 =?us-ascii?Q?U+QiqyGGmAZ9Er/8KRC7VBPj8x4eQrXmGROkETzpYCxY45d3j1YyPZBbhmRE?=
 =?us-ascii?Q?DHGnGQy1Cmiwp3U2/bwDzqmrQTDssPuGQBqB34iC/5zN/6lDNZHU/2OGk2vm?=
 =?us-ascii?Q?VxZcElZXsSZE7gUZ2mWeDTjhi18CnUcg3D9MJh4OzTiGySIiHICfYRc/JPqr?=
 =?us-ascii?Q?TjI5Im3/vyG1/t9u5V3z7WUgSizo97bTgNzkPhaoXNlAjte5lcscEvnpLqN+?=
 =?us-ascii?Q?s0xYFfB75APDeQI9GH0DtcoXmcSQ218qvJjMJJdizIHcAkearTlo51857znB?=
 =?us-ascii?Q?3+VWnDVBoWHbkBwnw1pyWBOBvRwZxJd3VnSBsb9o1H7OJT1G5fFSgpOxPkJf?=
 =?us-ascii?Q?XnBrUTB4N35HmRYGxRl3HWMvueDJ7GjFusx7r4Wu2NzrtehlOc6m8j6F2Scs?=
 =?us-ascii?Q?q1tfAtAL/0W25S13ANQtEEQQsE2sL7ZlL92KI6qEp5nHtDukTcYLbhVHbwZG?=
 =?us-ascii?Q?V4gn8ltPIHCfwREIIfZqCx+/kXoOpRqHirwu32kbafDn+2j0O6sYK0OO2rHW?=
 =?us-ascii?Q?H+mUhD1UaQDGDXcpPGLV3T1ncrdZHCt0WonyM0olvfYjvfa7w0/egFwPtVzh?=
 =?us-ascii?Q?xFIm1RaQrX+d/59zpOvi96T2FHCDjV8lXAkKCkn8/i0JTD8mQalXQpUlA8jA?=
 =?us-ascii?Q?HuEDz1myDWy1wFv1AmPKi5szbhR8ieLaFw0F3eARKVdJ6nHOvVJ2iOZOG96y?=
 =?us-ascii?Q?pd5WpcRI2KwJmV4HWhxOI3JpzstpuvdHJUCXsX32uLbfQ3jW6BQV3c6cOWjk?=
 =?us-ascii?Q?6RmaYE42RJjAUfvbKpP3/4h4J+FhyOP3yNZE2+9WxCnAxTQK+9wKqbvDy3fb?=
 =?us-ascii?Q?luJy1B9ggg7I3yVVr1fPZJZH1zpIGtxWWvQKH+FS?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f23de97f-5d0b-481c-2c70-08da6ce9229e
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2022 20:22:58.9692
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wzLpqiJs96vMaNrsnMD1m218A2vPMfzN5CR11nEoU5yLlKxbgiYIpO9mcYUvyVscmG2tn4cQCJsw7SJzSSYU3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR04MB0447
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -static void ufshcd_host_memory_configure(struct ufs_hba *hba)
> +static int ufshcd_host_memory_configure(struct ufs_hba *hba)
>  {
>         struct utp_transfer_req_desc *utrdlp;
>         dma_addr_t cmd_desc_dma_addr;
> @@ -3721,6 +3764,9 @@ static void ufshcd_host_memory_configure(struct
> ufs_hba *hba)
>         int cmd_desc_size;
>         int i;
>=20
> +       if (is_mcq_enabled(hba))
> +               return ufshcd_mcq_memory_configure(hba);
> +
>         utrdlp =3D hba->utrdl_base_addr;
>=20
>         response_offset =3D
> @@ -3759,6 +3805,8 @@ static void ufshcd_host_memory_configure(struct
> ufs_hba *hba)
>=20
>                 ufshcd_init_lrb(hba, &hba->lrb[i], i);
If is_mcq_enabled, do you still call ufshcd_init_lrb?

Thanks,
Avri

>         }