Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <quic_cang@quicinc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
        "quic_ziqichen@quicinc.com" <quic_ziqichen@quicinc.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>
CC:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Daejun Park <daejun7.park@samsung.com>,
        Jinyoung Choi <j-young.choi@samsung.com>,
        Kiwoong Kim <kwmad.kim@samsung.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
Thread-Topic: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
Thread-Index: AQHYmz2OvInxSH8TlUq8qOHvad4nHq2MfEMA
Date:   Sat, 23 Jul 2022 21:23:57 +0000
Message-ID: <DM6PR04MB65756C5A6C5F674B19091F7DFC939@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <1658214120-22772-1-git-send-email-quic_cang@quicinc.com>
 <1658214120-22772-2-git-send-email-quic_cang@quicinc.com>
In-Reply-To: <1658214120-22772-2-git-send-email-quic_cang@quicinc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CPlZ1XaZO39QSjJ84YiH0N3cCKip8vKecsgyWws351a9sgOY4MBxNyevvWUz?=
 =?us-ascii?Q?s5ITKNB4pnnBcBV0VF/6vBSAEQM7U9NeV4wZcT4F3x/xe8JvOrhDFA5cZ8nj?=
 =?us-ascii?Q?6YmD5rj3rRhBvqw4PB/3ucbPlChDnUwkngID4d6EZScE0tu6IFlg2KGTmrLb?=
 =?us-ascii?Q?04+mQuLYmDVDAxL05/NQ43Q24kR2jAsvktNBTGNT/92TSC0ysZAVYTPy2JWx?=
 =?us-ascii?Q?M+sWFk3MGFnyVejCMtGVssTC5DsWjV/7hpNw/wzfzlh+E5tm82jaBjcp8R7H?=
 =?us-ascii?Q?mTBwXc5i7D6bG4tixVrmvtUjDx0g+mhvLOyOQPGhQ83M1DqJi8Z7NKW+LvmZ?=
 =?us-ascii?Q?k4jQSGYk0cWYH8KyUpdPiY/m19BkV5V0PZKyOb86Hrp6IK78DhQLw25AH4ST?=
 =?us-ascii?Q?fHh9QJ0YJOo+RaDWRMCw9QHvKVz1+yxpcMcSrD9dbPwCk/W106wNY//UDgUq?=
 =?us-ascii?Q?MHrU2tUUJBEHVDDDIPIApTC8MiSgJGh2GpFYPdvpJlDTnpZbg6LleoGCeh73?=
 =?us-ascii?Q?C1K12Er76HkPpJY0Q4BrhdMOxrLGkWGipCgDEl2Itrml9FR6rxvwfPQOI9uo?=
 =?us-ascii?Q?AWxrLeTiV7QW6SZLlKoYnwL/p+464gGqTm5LYxcZ9UHu/i1eElekr8P43Kg/?=
 =?us-ascii?Q?5nLUfEyoRKjP4Om4M9LCHth/j4AUpi+c93ydWhq2Q55lppDNDw2UunesdVZn?=
 =?us-ascii?Q?9htiI8SZ3PHJyg5ZLX9vDCTOLxZxo4qCcR/WZjvIc0B0gjaodP0ifBP9pLKg?=
 =?us-ascii?Q?ymWJCedG5W4hoF/r+Riij/XmMAxW/+eDvVe5ml8U6OXhM45WM+9jzwGGwhof?=
 =?us-ascii?Q?wYf818R+zOx4tc0+RiIA7DmMUKOq5VsXbSuIRNaIj1a5p1R1I+zSYZLBg8LA?=
 =?us-ascii?Q?NoybkN7+AtR6JrbY/UDEocr49bb0YDmGEAGlSnLQzLkM5RaFKmFdZrJ8rhB2?=
 =?us-ascii?Q?00AC28XT/Zrc/Pu7o35YOfZp5OKAZ1v9k0cgGhS7ysXzYw44TNqaOCy91hf+?=
 =?us-ascii?Q?lYuvxAdYS1ZyQ92oMdF4W9StkwzFYvKnXLp0SuLBsjLVnDJMb0tw58VXYrrf?=
 =?us-ascii?Q?CQNcUsz7c3z5ZyRvY2MNl3Xp5e0ZseY1fow1WXfvUXDjJHNoPC6G3++dgUHW?=
 =?us-ascii?Q?R44IaPjYJWL+i1SvFk3uZokWm2y7C856liw9TmDii/kU/Q3ev+veQa9mTcBR?=
 =?us-ascii?Q?UfGsoaABfnlYgKpJf84KHyZGpsWwMW78A8HlSwp1Vk7FgGHYcpNRmwrNOWR6?=
 =?us-ascii?Q?JYrsVq0fRnpzbLwB22qDfviihZTnXTtNfBX8MoinZRbczvIt8Qk8OEFTqtxv?=
 =?us-ascii?Q?nZos7UdmTRYKkhk6Xfcs3Hl2RHJnLEJRunlOyvyf+jGuvI36KQhl/pHH4/48?=
 =?us-ascii?Q?gdPBfihREMlpkTKnQkhXDw9S9wXwk+yvv6Ave76DMcr11PIhp1Xy5hyjbEQ0?=
 =?us-ascii?Q?944Hksk7FG0WVUFqFEWG0kWo8NZUJhoG5Vf8ytpPU1cbqtuY0IGuBTqI002v?=
 =?us-ascii?Q?b6v8k9TjmiYo7EZUR+JD0pZJGPKFeUBcpiidNX9s2hpiPSVtAnJZrJ9VMWVv?=
 =?us-ascii?Q?TZ51vxuMnP3sRRY8ZFbl/uZ2lQBvHNZCkhsiFeDg?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11b9ea92-546d-40cf-98a9-08da6cf1a786
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2022 21:23:57.9412
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IZ3bFoELgF8RkbmrZe8d4ClbGxsQerwu5cfe14Ejb7vnvK82wiYRqidAyU4aTFiLPyPoFBHDv1rfG82MgwqsQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5709
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>  static inline
> -void ufshcd_send_command(struct ufs_hba *hba, unsigned int task_tag)
> +void ufshcd_send_command(struct ufs_hba *hba, struct ufshcd_lrb *lrbp,
> +                        struct ufs_hw_queue *hwq)
>  {
> -       struct ufshcd_lrb *lrbp =3D &hba->lrb[task_tag];
>         unsigned long flags;
>=20
>         lrbp->issue_time_stamp =3D ktime_get();
>         lrbp->compl_time_stamp =3D ktime_set(0, 0);
> -       ufshcd_add_command_trace(hba, task_tag, UFS_CMD_SEND);
> +       ufshcd_add_command_trace(hba, lrbp, UFS_CMD_SEND);
>         ufshcd_clk_scaling_start_busy(hba);
>         if (unlikely(ufshcd_should_inform_monitor(hba, lrbp)))
>                 ufshcd_start_monitor(hba, lrbp);
>=20
> -       spin_lock_irqsave(&hba->outstanding_lock, flags);
> -       if (hba->vops && hba->vops->setup_xfer_req)
> -               hba->vops->setup_xfer_req(hba, task_tag, !!lrbp->cmd);
> -       __set_bit(task_tag, &hba->outstanding_reqs);
> -       ufshcd_writel(hba, 1 << task_tag,
> REG_UTP_TRANSFER_REQ_DOOR_BELL);
> -       spin_unlock_irqrestore(&hba->outstanding_lock, flags);
> +       if (is_mcq_enabled(hba)) {
> +               int utrd_size =3D sizeof(struct utp_transfer_req_desc);
Maybe we can map some designated ops, so all those if (is_mcq) can be avoid=
ed in the data-path.
Also maybe we can constify sizeof(struct utp_transfer_req_desc) which is us=
ed now few times.

Thanks,
Avri